Received-SPF: pass (google.com: domain of linux-kernel+bounces-42713-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
From: =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= <ilpo.jarvinen@linux.intel.com>
Date: Mon, 29 Jan 2024 14:46:45 +0200 (EET)
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>, 
    Suma Hegde <suma.hegde@amd.com>
cc: naveenkrishna.chatradhi@amd.com, LKML <linux-kernel@vger.kernel.org>, 
    Carlos Bilbao <carlos.bilbao@amd.com>, Hans de Goede <hdegoede@redhat.com>, 
    platform-driver-x86@vger.kernel.org
Subject: Re: [PATCH] platform/x86/amd/hsmp: switch to use
 device_add_groups()
In-Reply-To: <2024012822-exalted-fidgeting-f180@gregkh>
Message-ID: <0d110d2a-da0c-017a-0e5a-fc6bef7b066a@linux.intel.com>
References: <2024012822-exalted-fidgeting-f180@gregkh>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/mixed; BOUNDARY="8323328-481654086-1706523055=:1439"
Content-ID: <9ec7d7ac-21d3-1810-4e1e-7bd1e6c1a96b@linux.intel.com>

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--8323328-481654086-1706523055=:1439
Content-Type: text/plain; CHARSET=ISO-8859-15
Content-Transfer-Encoding: QUOTED-PRINTABLE
Content-ID: <66ab558a-7c2c-910a-9c17-a61ea96c7b48@linux.intel.com>

+ Cc Suma Hegde.

On Sun, 28 Jan 2024, Greg Kroah-Hartman wrote:

> The use of devm_*() functions works properly for when the device
> structure itself is dynamic, but the hsmp driver is attempting to have a
> local, static, struct device and then calls devm_() functions attaching
> memory to the device that will never be freed.
>=20
> The logic of having a static struct device is almost never a wise
> choice, but for now, just remove the use of devm_device_add_groups() in
> this driver as it obviously is not needed.
>=20
> Cc: Naveen Krishna Chatradhi <naveenkrishna.chatradhi@amd.com>
> Cc: Carlos Bilbao <carlos.bilbao@amd.com>
> Cc: Hans de Goede <hdegoede@redhat.com>
> Cc: "Ilpo J=E4rvinen" <ilpo.jarvinen@linux.intel.com>
> Cc: platform-driver-x86@vger.kernel.org
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> ---
>  drivers/platform/x86/amd/hsmp.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/drivers/platform/x86/amd/hsmp.c b/drivers/platform/x86/amd/h=
smp.c
> index b55d80e29139..49ef0b1d6df0 100644
> --- a/drivers/platform/x86/amd/hsmp.c
> +++ b/drivers/platform/x86/amd/hsmp.c
> @@ -471,7 +471,7 @@ static int hsmp_create_sysfs_interface(void)
>  =09=09if (ret)
>  =09=09=09return ret;
>  =09}
> -=09return devm_device_add_groups(plat_dev.dev, hsmp_attr_grps);
> +=09return device_add_groups(plat_dev.dev, hsmp_attr_grps);
>  }

Thanks Greg for bringing this up. I've added Suma who has some patches=20
which change code around this area.

--=20
 i.
--8323328-481654086-1706523055=:1439--