Received-SPF: pass (google.com: domain of linux-kernel+bounces-43132-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Mon, 29 Jan 2024 16:42:22 +0000
From: Mark Brown <broonie@kernel.org>
To: Tudor Ambarus <tudor.ambarus@linaro.org>
Cc: Sam Protsenko <semen.protsenko@linaro.org>, andi.shyti@kernel.org,
	krzysztof.kozlowski@linaro.org, alim.akhtar@samsung.com,
	jassi.brar@samsung.com, linux-spi@vger.kernel.org,
	linux-samsung-soc@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
	andre.draszik@linaro.org, peter.griffin@linaro.org,
	kernel-team@android.com, willmcvicker@google.com
Subject: Re: [PATCH v3 17/17] spi: s3c64xx: use bitfield access macros
Message-ID: <56f81e10-86b7-4bd6-938c-e2e9acd6a755@sirena.org.uk>
References: <20240126171546.1233172-1-tudor.ambarus@linaro.org>
 <20240126171546.1233172-18-tudor.ambarus@linaro.org>
 <CAPLW+4nL6D7R88Q_kJjAT-bWTFBk8a=FT0vL+fyRgxaDeSyhNw@mail.gmail.com>
 <b5ecacaa-8ccc-4588-b3be-4b5f85813909@linaro.org>
 <CAPLW+4nN--gG9XsOu6a-mo5vcM-GycRrhPQFOtNidfVTM=KonQ@mail.gmail.com>
 <facbcbf3-7dba-43a1-b4fe-ac77b5bef545@linaro.org>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="DaUgeyoITWwGHbnv"
Content-Disposition: inline
In-Reply-To: <facbcbf3-7dba-43a1-b4fe-ac77b5bef545@linaro.org>


--DaUgeyoITWwGHbnv
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sat, Jan 27, 2024 at 03:44:24AM +0000, Tudor Ambarus wrote:
> On 1/27/24 03:38, Sam Protsenko wrote:

> >>>> -               val |=3D S3C64XX_SPI_MODE_BUS_TSZ_HALFWORD;
> >>>> -               val |=3D S3C64XX_SPI_MODE_CH_TSZ_HALFWORD;
> >>>> +               val |=3D FIELD_PREP(S3C64XX_SPI_MODE_BUS_TSZ_MASK,
> >>>> +                                 S3C64XX_SPI_MODE_BUS_TSZ_HALFWORD)=
 |
> >>>> +                      FIELD_PREP(S3C64XX_SPI_MODE_CH_TSZ_MASK,
> >>>> +                                 S3C64XX_SPI_MODE_CH_TSZ_HALFWORD);

> >>> Two people complained it makes the code harder to read. Yet it's not
> >>> addressed in v3. Please see my comments for your previous submission
> >>> explaining what can be done, and also Andi's comment on that matter.

> >> I kept these intentionally. Please read my reply on that matter or the
> >> cover letter to this patch set.

> > I read it. But still don't like it =F0=9F=99=82 I'm sure it's possible =
to do
> > this modification, but at the same time keep the code clean an easy to
> > read. The code above -- I don't like at all, sorry. It was much better
> > before this patch, IMHO.

> Yeah, I guess Mark will tip the scale.

All other things being equal I tend to try not to get too involved with
minor coding style stuff in drivers.  People do seem to like
FIELD_PREP() but I have a hard time getting *too* excited.

--DaUgeyoITWwGHbnv
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmW31W0ACgkQJNaLcl1U
h9D1sgf+LsNlBetwedyUQFVkLWeD2/eL+pfYu8FM0WZj/O6r4MV2XRHnCBXfL473
NLaB0yLgsgtPb86HqHYBS2btNVBJK4PFOcLChFITzvAUc/1VQGEeS7ZCcUF3BNA9
3wqAL3YScnNgFBDTT4Mr/jis+phwYukz8uC+ThBVRFUMQhe/ujrL6yJJAxFjf1Nd
gyAVOQvDDL6FmlGVrUg//dAddncv7HXiXDKv0cLqdtqYKMF7MTBRABw+Cc55NryM
aXw3zjIItX9v4bGy5YB0PcoB0QaOlQaM8UXZ9mxPItbY1AAw6IJzVarKCZUg66HG
9stVfnJhiRnXanRUk/YMGyVbYKT4Cg==
=GxVd
-----END PGP SIGNATURE-----

--DaUgeyoITWwGHbnv--