Received-SPF: pass (google.com: domain of linux-kernel+bounces-43155-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <b1b8545c-d05e-4e99-acae-690c3c052943@amd.com>
Date: Mon, 29 Jan 2024 10:54:53 -0600
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 2/2] drm/amd: Fetch the EDID from _DDC if available for
 eDP
Content-Language: en-US
To: Jani Nikula <jani.nikula@linux.intel.com>, amd-gfx@lists.freedesktop.org,
 Alex Deucher <alexander.deucher@amd.com>,
 Harry Wentland <harry.wentland@amd.com>,
 "Rafael J . Wysocki" <rafael@kernel.org>, Hans de Goede <hdegoede@redhat.com>
Cc: open list <linux-kernel@vger.kernel.org>,
 "open list:DRM DRIVERS" <dri-devel@lists.freedesktop.org>,
 Melissa Wen <mwen@igalia.com>, "open list:ACPI"
 <linux-acpi@vger.kernel.org>, Mark Pearson <mpearson-lenovo@squebb.ca>
References: <20240126184639.8187-1-mario.limonciello@amd.com>
 <20240126184639.8187-3-mario.limonciello@amd.com> <87le88jx63.fsf@intel.com>
 <63c60424-1b2d-4912-81b2-7c7ead4c8289@amd.com> <87cytkjddy.fsf@intel.com>
From: Mario Limonciello <mario.limonciello@amd.com>
In-Reply-To: <87cytkjddy.fsf@intel.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?Vm10TEpJOFVoK3poY3N3bmRlWGhsUjk2OGIrdE95QzZPb2xxbzRBcjRWV2ZY?=
 =?utf-8?B?S3VsZWlidXdWRzhEMXlIbTdjOGtpUHc5ZkFScG9BNWNBSFNTTWw5RVNscExo?=
 =?utf-8?B?c1hoejFwWlpEK3YyOGZLbVpaVWNaS0hHOFBKeXp6OW5XMGNkUVVYQU9TWmhD?=
 =?utf-8?B?eW1xYlRiM01GTmtTd2VpOGU0dFNERmtwV3NSMnlyYTFJMlp0cSswdGhtK0Vs?=
 =?utf-8?B?M0JOSDAzOG9iQVJQQmtXQXJra01NOFhTVGxmL2l2N0lRMmRDNnd5MnJ5d2ha?=
 =?utf-8?B?WC9VTHJITWZEb0o1bXp2QUVDK2lTNHF1TG9MVDFiZGNXbFNUODE3OE11aFU4?=
 =?utf-8?B?WTIvRDNjdHMrb3oydmNJdXlqakROSXZhb05QWWtSeitvaW9MVzJGK1NqV241?=
 =?utf-8?B?NUlkWnhLUHRWMHZycU4rNk9ONzFNaHJrRnhGNWZya0ZQaTJ4TWtlaGxZVHFO?=
 =?utf-8?B?eHRVZXR3TEExUXVBd3MveE1VUFBEWG1wZ0Nhc29qQ2FWbWVMRFF6aTVoWkZD?=
 =?utf-8?B?ekVocno0VGY2VGlYcjloYWlUcStFbzlIK0pZNVNHM0VuY1lDcnp6a2dpc3Z5?=
 =?utf-8?B?YUpXb2dhN3Z0dEY1VmtabnFadUx3UFROa1llM1h5MnFVVTRLVkMyaHNKM2Zj?=
 =?utf-8?B?d1gzR3AxZHo0WVlvMkhqc3NZZ1I5cDgzRFl4a04wK2d5Q1R3RGt3RENHdFNs?=
 =?utf-8?B?U2hSdkJqQlBLakVpSGQ0ZkZoZ0Q1YXo5OHVMZGlRSzhZbU1UcTYvYzErRmVV?=
 =?utf-8?B?TTVKUEFhMWNNc2J0VjZkeDMrSE5nWGZCSk9YcGcxeHNRM2lKSGdmOWthWnBa?=
 =?utf-8?B?VmIzN3k0Wmp6NzNKTDdDUnBmTnJvRGl2QWhLOFJIS3FxVjVpRWQzYTZ1M2Z2?=
 =?utf-8?B?aDdHRDdlZUVpSmlaR2FnM2srSVh3TFdURHU0ZktTUDJNK2hiQk95QlQxcFd3?=
 =?utf-8?B?WXhseE5SUERVZlgrTjk3dDhOSkMxY3ZRK1BSdTgwNk04RURhVEpQdzF2WU5y?=
 =?utf-8?B?eGlCZ3p1c0hQNjYwOVJadVdCTThWWWNtSWhNZmVQQkMvZUZ4MHluOU1UVnVZ?=
 =?utf-8?B?NExRdWdBWTZ3cTBqY0ZGcUJRckZ6Qis5Yk80aGNrRWFvelE4MGlyREh1VXNz?=
 =?utf-8?B?NmNZb0M2dE1iVE5Bc1dHNnNCeE55dHJma2ZpRTRNZXp3clNwbFZOd213ZmZj?=
 =?utf-8?B?R1VKV1RRdzdJNDhiVXBGUnBsSDhqYkNlZzZOaW9wNTJLMkk3U01XRHd1QWRC?=
 =?utf-8?B?Z1Y5ZUpNVmZQdVBWNnFETzBrWDZhUUo0amxTS3FWcWYza2VzdGdoa2Z1WWdv?=
 =?utf-8?B?QzQ4aXk2WE1Kbmh4ZEtHS2lWaFcrMERJYXg4SEFXV21KT3RUZjgzQTZMQkZt?=
 =?utf-8?B?TVJjN1pEckNBTG1ENVdJb2FEZGk3YUV4L25QdjE1bjhHd0hHUjB3VXh2Y1dK?=
 =?utf-8?B?OVRHNHNzR1RqbXVNTG1tb3JOS3l6VTU4UnBqU3BVRHBQcVNJcjZMRXZrNE1I?=
 =?utf-8?B?ZDJSbmhtMHgvbCs2V28vQmJWK1RMYlJwaVNnNW1ZL0pBRURhWmZOUDBVL09L?=
 =?utf-8?B?aVNHRFlESzdHSHVOZHRtdERzQVl3UiswM0NaOU5KdzQ2UmJiY1BHVDhCdGxY?=
 =?utf-8?B?REVDYXBvdUFuSE4wNnRSdmpYZnBOQUxtanZOdTdTVG93UGJDUitBRnI0UXVE?=
 =?utf-8?B?TnEzMy9ZV3NCMjhZT0hVN0hwTDZCU2grSzdydEN2U2FKcnJudkk4Vm5xZzZ4?=
 =?utf-8?B?UUs0N01LTGdxejYvSW5xaWVoMWpZNFlweFdOLzNUZjJ0MzU5TDU3dHY2WjNv?=
 =?utf-8?B?RXpjV1p4N05QaDNJS0taaFJMWXN1UTIzbjVITE0vcVFTc0U1QTIvZXhGZkJR?=
 =?utf-8?B?T3VCRGlTdEgzN08xNWJ1cVpHa2NQb3ZNQ1M5anZ5UTFSemhaTlZNUlFvb1Rq?=
 =?utf-8?B?OHJQR0Fkcm5BRkE3VE14S2NLaDBwTW1Wc0phNk55Z0ZWeWdzU0NOM09wUFdE?=
 =?utf-8?B?aDR0elBzQ2RjaWpZTkFNSXQ2cmVYbXl2RDFJcCtUbTI3TWFSK1VnZDVIVGdj?=
 =?utf-8?B?cHBzS1dPZXJndnhRRFN1d1hjWWh6cDdTcTZkanJSRFUvTTNaWDNtTzN3aFQ3?=
 =?utf-8?Q?rkOgn43xB89u9Ar/AyBgZAE8H?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: acdd31f0-a634-43f0-3fc1-08dc20eb059b
X-MS-Exchange-CrossTenant-AuthSource: MN0PR12MB6101.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Jan 2024 16:54:56.5085
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: fNM32aqQ/rrsFWx31mjN8zaIwWzRPmHawGy5j3FZcMn5Tp4MQr1mFhqnz18tUwK2BJ5bvTAu5UgZNZt3ecdyHA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA3PR12MB9105

On 1/29/2024 10:46, Jani Nikula wrote:
> On Mon, 29 Jan 2024, Mario Limonciello <mario.limonciello@amd.com> wrote:
>> On 1/29/2024 03:39, Jani Nikula wrote:
>>> On Fri, 26 Jan 2024, Mario Limonciello <mario.limonciello@amd.com> wrote:
>>>> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c
>>>> index 9caba10315a8..c7e1563a46d3 100644
>>>> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c
>>>> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c
>>>> @@ -278,6 +278,11 @@ static void amdgpu_connector_get_edid(struct drm_connector *connector)
>>>>    	struct amdgpu_device *adev = drm_to_adev(dev);
>>>>    	struct amdgpu_connector *amdgpu_connector = to_amdgpu_connector(connector);
>>>>    
>>>> +	if (amdgpu_connector->edid)
>>>> +		return;
>>>> +
>>>> +	/* if the BIOS specifies the EDID via _DDC, prefer this */
>>>> +	amdgpu_connector->edid = amdgpu_acpi_edid(adev, connector);
>>>
>>> Imagine the EDID returned by acpi_video_get_edid() has edid->extensions
>>> bigger than 4. Of course it should not, but you have no guarantees, and
>>> it originates outside of the kernel.
>>>
>>> The real fix is to have the function return a struct drm_edid which
>>> tracks the allocation size separately. Unfortunately, it requires a
>>> bunch of changes along the way. We've mostly done it in i915, and I've
>>> sent a series to do this in drm/bridge [1].
> 
> Looking at it again, perhaps the ACPI code should just return a blob,
> and the drm code should have a helper to wrap that around struct
> drm_edid, so that the ACPI code does not have to depend on drm. Basic
> idea remains.

I'd ideally like to split this stuff and Melissa's rework to be 
independent if possible.  I'll see if that's actually feasible.

> 
>>> Bottom line, we should stop using struct edid in drivers. They'll all
>>> parse the info differently, and from what I've seen, often wrong.
>>>
>>>
>>
>> Thanks for the feedback.  In that case this specific change should
>> probably rebase on the Melissa's work
>> https://lore.kernel.org/amd-gfx/20240126163429.56714-1-mwen@igalia.com/
>> after she takes into account the feedback.
>>
>> Let me ask you this though - do you think that after that's done should
>> we let all drivers get EDID from BIOS as a priority?  Or would you
>> prefer that this is unique to amdgpu?
> 
> If the reason for having this is that the panel EDID contains some
> garbage, that's certainly not unique to amdgpu... :p

OK; maybe a helper in DRM that wraps the ACPI code then and amdgpu will 
use the helper for this series.

I'm also thinking it makes sense to have a new /proc/cmdline setup 
option to ignore the BIOS for EDID.  I'm hoping that since Windows uses 
_DDC that BIOS will be higher quality; but you know; BIOS =)

> 
>> Something like:
>>
>> 1) If user specifies on kernel command line and puts an EDID in
>> /lib/firmware use that.
>> 2) If BIOS has EDID in _DDC and it's eDP panel, use that.
> 
> I think we should also look into this. We currently don't do this, and
> it might help with some machines. However, gut feeling says it's
> probably better to keep this as a per driver decision instead of trying
> to bolt it into drm helpers.

OK; I'll wire up the helper and if you want to use in the future you can 
too then.

> 
> BR,
> Jani.
> 
> 
>> 3) Get panel EDID.
>>
>