Received-SPF: pass (google.com: domain of linux-kernel+bounces-43160-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Mon, 29 Jan 2024 16:57:35 +0000
From: Conor Dooley <conor@kernel.org>
To: Michal Simek <michal.simek@amd.com>
Cc: linux-kernel@vger.kernel.org, monstr@monstr.eu, michal.simek@xilinx.com,
	git@xilinx.com, Conor Dooley <conor+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Rob Herring <robh+dt@kernel.org>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" <devicetree@vger.kernel.org>,
	kishore Manne <nava.kishore.manne@amd.com>,
	"moderated list:ARM/ZYNQ ARCHITECTURE" <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] dt-bindings: firmware: xilinx: Describe soc-vvmem subnode
Message-ID: <20240129-vastly-hunk-0680e152c03c@spud>
References: <3869498c995cbb123127122f429e90de0a3f4014.1706531104.git.michal.simek@amd.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="LOozDfvasueM032q"
Content-Disposition: inline
In-Reply-To: <3869498c995cbb123127122f429e90de0a3f4014.1706531104.git.michal.simek@amd.com>


--LOozDfvasueM032q
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Jan 29, 2024 at 01:25:06PM +0100, Michal Simek wrote:
> Describe soc-nvmem subnode as the part of firmware node. The name can't be
> pure nvmem because dt-schema already defines it as array property that's
> why different name should be used.
>=20
> Signed-off-by: Michal Simek <michal.simek@amd.com>
> ---
>=20
> Dt binding for nvmem node has been already merged and it is the part of
> linux-next tree.
> Here is the reference to it just in case:
> https://lore.kernel.org/r/170635581622.41421.8980881999042944764.b4-ty@li=
naro.org
>=20
> ---
>  .../bindings/firmware/xilinx/xlnx,zynqmp-firmware.yaml   | 9 +++++++++
>  1 file changed, 9 insertions(+)
>=20
> diff --git a/Documentation/devicetree/bindings/firmware/xilinx/xlnx,zynqm=
p-firmware.yaml b/Documentation/devicetree/bindings/firmware/xilinx/xlnx,zy=
nqmp-firmware.yaml
> index 7586fbff7ad6..108772ef574f 100644
> --- a/Documentation/devicetree/bindings/firmware/xilinx/xlnx,zynqmp-firmw=
are.yaml
> +++ b/Documentation/devicetree/bindings/firmware/xilinx/xlnx,zynqmp-firmw=
are.yaml
> @@ -62,6 +62,12 @@ properties:
>        interface.
>      type: object
> =20
> +  soc-nvmem:
> +    $ref: /schemas/nvmem/xlnx,zynqmp-nvmem.yaml#
> +    description: The ZynqMP MPSoC provides access to the hardware relate=
d data
> +      like SOC revision, IDCODE and specific purpose efuses.
> +    type: object
> +
>    pcap:
>      $ref: /schemas/fpga/xlnx,zynqmp-pcap-fpga.yaml
>      description: The ZynqMP SoC uses the PCAP (Processor Configuration P=
ort) to
> @@ -110,6 +116,9 @@ examples:
>      firmware {
>        zynqmp_firmware: zynqmp-firmware {
>          #power-domain-cells =3D <1>;
> +        soc-nvmem {
> +          compatible =3D "xlnx,zynqmp-nvmem-fw";
> +        };

Would it not be better to have an actual nvmem-layout in here? The
~empty node here looks rather odd.

Also, there's a type in $subject of nvmem.

Thanks,
Conor.

>          gpio {
>            compatible =3D "xlnx,zynqmp-gpio-modepin";
>            gpio-controller;
> --=20
> 2.36.1
>=20

--LOozDfvasueM032q
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZbfY/wAKCRB4tDGHoIJi
0rNqAP99TXsDxAY96t3sGZNtC3Vrmw+Zgegwmy/rGInLx2ByGwEAtZQ/EQisxfOm
tWkHHbHJ9y+fW5zSNHf2/eVQEco79Q4=
=PUQx
-----END PGP SIGNATURE-----

--LOozDfvasueM032q--