Received-SPF: pass (google.com: domain of linux-kernel+bounces-43198-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <7da8652f-a466-4b38-8d0b-6494e9901a98@amd.com>
Date: Mon, 29 Jan 2024 09:27:21 -0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2 net-next 0/10] pds_core: Various improvements and AQ
 race condition cleanup
Content-Language: en-US
To: Jakub Kicinski <kuba@kernel.org>, Brett Creeley <brett.creeley@amd.com>
Cc: davem@davemloft.net, edumazet@google.com, pabeni@redhat.com,
 netdev@vger.kernel.org, linux-kernel@vger.kernel.org, shannon.nelson@amd.com
References: <20240126174255.17052-1-brett.creeley@amd.com>
 <20240126204423.47c20ef6@kernel.org>
From: Brett Creeley <bcreeley@amd.com>
In-Reply-To: <20240126204423.47c20ef6@kernel.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?Q2w1dnpaV2dicGlzbHpqVXVoSXF1M2x4QmVkWVplTTNNVXhUdXo5TVBsTHJh?=
 =?utf-8?B?dzhiSzhsdjRrdWF3blhTbHZhMTBuNUE2KzM3aEFqVXh2a0J0VEl0L2FxcUxL?=
 =?utf-8?B?alpmQnRDT0dXL05vT3UySk5TSDlVb2FrUCtTbWIwVmhGWGhZcFl6WEY4L3JB?=
 =?utf-8?B?bnEzUjhUODNHSm0wSGdyd3ZGSDM1Ylg4amRFeTRGRlpJY0t5QjZvZVBCY2Va?=
 =?utf-8?B?UDVLb2FtZVlNWGdWZ0hyTERMVTdnQWcyWlZHd09lMXloR1IyY1Qwdm5oTTZ1?=
 =?utf-8?B?T05HY0FqM0d4bHhUc1dxU2tDU2tQQjVodFF6SUUveDV1ek15ZVRneEtLM3pJ?=
 =?utf-8?B?Ky9qN09hNW42YnZHeVA3OGVVWmcvUmdCaEJqN1N5K0hucTZkTENLK1hnbEI1?=
 =?utf-8?B?bHl4eXZDVFloSno2K0VRMUVtU2YvdE1oMUloaEJ4a1g4NGhraWd1L3dndkI1?=
 =?utf-8?B?SmVqUVBtZ2NBQW1nU1RCNmU3Uk5EbUZEeDN2VjgzWTkvRW5UR0tnWk44d2JW?=
 =?utf-8?B?K0FhRERUTE1CRGdTOGNlUVNVL3VpUXAzOHhOdzFubGhiM0ZyaXFBOCtzUHY3?=
 =?utf-8?B?S2lwV1hMc3JFN2g5aHBGSGp5dXVTSG5kQ2pHT09nYU9FTzQ1THMvdTUySDRZ?=
 =?utf-8?B?NHgxS3hMQW1FSEM2SjhDNWdRNXJJY0RwMnZFVnpaYnZFSC9FbVJpd1lSMTMy?=
 =?utf-8?B?L2t4dUEwK0lZRGd2Zm1CU29uMjBQdkVwNUZpOTBkTWMwZWVXUit5MGIzc2sr?=
 =?utf-8?B?dFFMdWZDY25PL3dvZkRUTGFKcHBCUmlXRnVrTWJhRmRGd1MrUWtHUE5WcjRD?=
 =?utf-8?B?eFZsT0p3Q0tyUVdHcndKbHBIc0NYOXovMkc5M3ZFUHJGZUZ0R3BqUkczdHVS?=
 =?utf-8?B?UkVNUHM2L001YUhjMlo0UWduV3d1b29hSWNZUTR0cXN6b3FlM0ZTVFdNOExq?=
 =?utf-8?B?Skl5a0VkYXc1SmlPKzBLNWhSZFEySklwOTNnM3gvMWdlZ280Y083SFZlU2RC?=
 =?utf-8?B?amhha2RUTXBSSWhkWG9CamlOWFpsb3p3bjh2NVdMMVkyK2h6K3JiSXV4SEZZ?=
 =?utf-8?B?M0NoN3JRV3E2Vks5WWxhZzVmOXZTMFNyeDdkQU5OM3M0eW1WQ1ZIWTRnR1Nv?=
 =?utf-8?B?TVo0VTdpMjhSSzAxc2p2U21Dd2tPdkRXSXhKdWNacC9xa2xBUXlPdWxwd2k0?=
 =?utf-8?B?ODlVOElKUXczamN6UkFRUEc0aGVleU0zVkVaSHd0MEFITUEya0JvRkQwVDl2?=
 =?utf-8?B?UFZkV0VxQ2E3S0dNZnczM2tlYVRhVkF0Wm9ZbHdxdkNaVVVzb2QrWlZEclIw?=
 =?utf-8?B?MzVYU2lXQkpLUGREcThVZGhua2xwd21OaDVaMHpUd3cvVXlLck9mc3ZLMUhp?=
 =?utf-8?B?VC9pZXpVdVl2Rmd6MXV5dHRCbEk2dTBCcUV6czVjemdyVHBVUVhUUDdTR2ND?=
 =?utf-8?B?TmNIQllsSjN1OXdmOXFTdHhiTFBGWE5rZzg3eHlZa08reDJXVXI5Zkc5WVI4?=
 =?utf-8?B?aG1sdGJseVB0N1MxU3VIZy9OUlMzeVc5ZDVscTYrYVNra0dLNnNPc0daTGhS?=
 =?utf-8?B?Q3JwWlpRWTBaYnEwVS85SzVPVVh2NTlTN0xvSlRObHVHMFh5UTJoTmVCUWRz?=
 =?utf-8?B?RTl6TG1nZVZaMFBMN0MvVVk2bUN4R0lWVDNBRkk1Y3V6S0FWVGtaQmJPYUxa?=
 =?utf-8?B?dGF3cFdqTGVxVEswUTkxMjNYeWUxOFRlQTdzTllYVDVONHhxeHB1bXFmSzhq?=
 =?utf-8?B?V01IWEtWcFRJbzhzcGxaMS81UHhJTWM3Y0VlT0UyUTBsTkREWm0vRStIUFdN?=
 =?utf-8?B?b0gycWc4YzBEZTRPZjB2eDJIR1YzcXovYk53QWJRZW5JMThBVURYTDQ2OU43?=
 =?utf-8?B?Nit4U0h6bFRSOEc2czgxN1QrckRrSXhLTHBTaEpkQjhUam1XdHNlSlFmVGlF?=
 =?utf-8?B?a2ttY3VlWDNQOFVqUmRCaXM0eWRreHQ5UmZxaUJLcDl5S3AyVnVTdHQ5b2tZ?=
 =?utf-8?B?dFJMTk9maGF6S1lCRXh0MEx6ZUc1eDFZMWxwRHM3ZURaK0J0UVZ3cDJyQXpH?=
 =?utf-8?B?VlFpakwrMXpVSk5Jd2QyWGh4K3B3WDdIbGVsWXFKOWdiZWFITmRmNWNCZHl3?=
 =?utf-8?Q?hqmnxzQwjT9MxHrDcZKwXATQL?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 44687d41-ffd2-4970-e768-08dc20ef8e38
X-MS-Exchange-CrossTenant-AuthSource: PH0PR12MB7982.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Jan 2024 17:27:23.5971
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 40TbV4IKZq3oIzQD3b4Zj8Yth3KFBxW0sxNCj8qIT2nZutf8qELeLN60hJtT3PrUafY2cSDFLzPUb21vOBBttQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB9063

On 1/26/2024 8:44 PM, Jakub Kicinski wrote:
> Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding.
> 
> 
> On Fri, 26 Jan 2024 09:42:45 -0800 Brett Creeley wrote:
>> This series includes the following changes:
>>
>> There can be many users of the pds_core's adminq. This includes
>> pds_core's uses and any clients that depend on it. When the pds_core
>> device goes through a reset for any reason the adminq is freed
>> and reconfigured. There are some gaps in the current implementation
>> that will cause crashes during reset if any of the previously mentioned
>> users of the adminq attempt to use it after it's been freed.
>>
>> Issues around how resets are handled, specifically regarding the driver's
>> error handlers.
> 
> Patches 1, 2 and 4 look like fixes. Is there any reason these are
> targeting net-next? If someone deploys this device at scale rare
> things will happen a lot..

No reason, just an oversight on my part. I actually think patches 1, 2, 
3, 4, 5, and 9 could all go to net. Unfortunately some of these patches 
are intertwined (i.e. patch 10 depends on patch 9).

If I push the previously mentioned patches to net and they get accepted, 
how soon are fixes typically added to the net-next tree so I can 
rebase/re-push the remaining patches?

Thank for the review,

Brett