Received-SPF: pass (google.com: domain of linux-kernel+bounces-43207-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Mon, 29 Jan 2024 17:37:33 +0000
From: Conor Dooley <conor@kernel.org>
To: Luca Weiss <luca.weiss@fairphone.com>
Cc: Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konrad.dybcio@linaro.org>,
	Stanimir Varbanov <stanimir.k.varbanov@gmail.com>,
	Vikash Garodia <quic_vgarodia@quicinc.com>,
	Bryan O'Donoghue <bryan.odonoghue@linaro.org>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>,
	~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org,
	Stanimir Varbanov <stanimir.varbanov@linaro.org>,
	linux-arm-msm@vger.kernel.org, linux-media@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] media: dt-bindings: qcom,sc7280-venus: Allow one IOMMU
 entry
Message-ID: <20240129-numerate-brought-4660c2a89719@spud>
References: <20240129-sc7280-venus-bindings-v1-1-20a9ba194c60@fairphone.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="uIfXiQKiceuPgh4l"
Content-Disposition: inline
In-Reply-To: <20240129-sc7280-venus-bindings-v1-1-20a9ba194c60@fairphone.com>


--uIfXiQKiceuPgh4l
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Jan 29, 2024 at 08:48:54AM +0100, Luca Weiss wrote:
> Some SC7280-based boards crash when providing the "secure_non_pixel"
> context bank, so allow only one iommu in the bindings also.
>=20
> Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>

Do we have any idea why this happens? How is someone supposed to know
whether or not their system requires you to only provide one iommu?
Yes, a crash might be the obvious answer, but is there a way of knowing
without the crashes?

Cheers,
Conor.

> ---
> Reference:
> https://lore.kernel.org/linux-arm-msm/20231201-sc7280-venus-pas-v3-2-bc13=
2dc5fc30@fairphone.com/
> ---
>  Documentation/devicetree/bindings/media/qcom,sc7280-venus.yaml | 1 +
>  1 file changed, 1 insertion(+)
>=20
> diff --git a/Documentation/devicetree/bindings/media/qcom,sc7280-venus.ya=
ml b/Documentation/devicetree/bindings/media/qcom,sc7280-venus.yaml
> index 8f9b6433aeb8..10c334e6b3dc 100644
> --- a/Documentation/devicetree/bindings/media/qcom,sc7280-venus.yaml
> +++ b/Documentation/devicetree/bindings/media/qcom,sc7280-venus.yaml
> @@ -43,6 +43,7 @@ properties:
>        - const: vcodec_bus
> =20
>    iommus:
> +    minItems: 1
>      maxItems: 2
> =20
>    interconnects:
>=20
> ---
> base-commit: 596764183be8ebb13352b281a442a1f1151c9b06
> change-id: 20240129-sc7280-venus-bindings-6e62a99620de
>=20
> Best regards,
> --=20
> Luca Weiss <luca.weiss@fairphone.com>
>=20

--uIfXiQKiceuPgh4l
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZbfiXQAKCRB4tDGHoIJi
0u+kAQD6hQJxEFZGeDrdCSNz807MgW2B9L9wp4d7nPT8zipYcQD+PHraEQhlwbax
l6JDJfuJlD+YZfuAGqEETe5slN7CuA8=
=uaeV
-----END PGP SIGNATURE-----

--uIfXiQKiceuPgh4l--