Received-SPF: pass (google.com: domain of linux-kernel+bounces-43219-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <ef007d96-4aa6-4e29-bbe6-3d6cb82475ba@amd.com>
Date: Mon, 29 Jan 2024 11:43:06 -0600
User-Agent: Mozilla Thunderbird Beta
Subject: Re: [PATCH v4 2/2] remoteproc: enhance rproc_put() for clusters
To: Bjorn Andersson <andersson@kernel.org>
Cc: mathieu.poirier@linaro.org, linux-remoteproc@vger.kernel.org,
 linux-kernel@vger.kernel.org, Tarak Reddy <tarak.reddy@amd.com>
References: <20240103221124.3063683-1-tanmay.shah@amd.com>
 <20240103221124.3063683-3-tanmay.shah@amd.com>
 <4xqmpxq4uqqxmgsf5lzxo3qjxmoeu6cpb4iqvtxefyiqlt3pzk@g76y2r4uxkiw>
Content-Language: en-US
From: Tanmay Shah <tanmay.shah@amd.com>
In-Reply-To: <4xqmpxq4uqqxmgsf5lzxo3qjxmoeu6cpb4iqvtxefyiqlt3pzk@g76y2r4uxkiw>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?SHVVNktMbHNBRHhmVjVrTG1BVk1HRk80UkVGN0VYcm9tekwwL3QvRzN0NkRy?=
 =?utf-8?B?MjZWdW9Mdm10dnRoMnJHSmQyNEpsbXNWTXNhRW9GZWg0VFdqd2x2Y2g3U2xU?=
 =?utf-8?B?RG1Pbk5va1dxcnZBem1Vaks0NENocmt5UXFSQlk2ajUwdHRzZnFuWkdHeGQ1?=
 =?utf-8?B?MFZjYzZqd3pCWmw0YjRaRWVXOVVsNjFlVU9wTmxnVEZIeHoyaW9SUE11WTJC?=
 =?utf-8?B?Zk94djRFWmpsL0FEcUNJZG9wY2FlOG0vNjZUVU1ZckxpRitGdTM1anpBWDFC?=
 =?utf-8?B?UXR1eFdaYnN0dWZBRklRaDU5dVdmbnRBTWR2S1o0dTc1d3BYaC8zWGNSMklT?=
 =?utf-8?B?Zi9uVG53NHpPVE5HUktmeEZVOUJORU42eUU4aEp4TzdUL2N3Q2VnMzB0dmxR?=
 =?utf-8?B?UytYN3Jmck9qazJOZUJrZjhsckxGaVplcW5PK1NxZHZ1TlpvenJkZHdTV2hP?=
 =?utf-8?B?TlFUZUZCaHpWUzFPTlNHbW9HWnJsYXVNeHkySkJzWlJjV0QxdlhBNFNhYW12?=
 =?utf-8?B?SmhhSTdLVzdLTUlZYTlIaWVuaCtEbUZ4dVZPVUlZM3Z0L2hXSENldHJJdEFy?=
 =?utf-8?B?cUxqUW1Jd0hwbG85OG5MbUQvRUVYVDZPTGduZ1AvTUdZL3dZSmRMNmdhNEE4?=
 =?utf-8?B?dkU2UlptVTByT2hmM0FwcVVzQ2xCYkRrWFUyb2hBS2VlL0Z1NjZMS21YQXpk?=
 =?utf-8?B?Qk9MWHVPLzNERzZkbDBYR0RzRkIxMkhQMHl0OUZCSG9jVTFiT1VBSWZoakp1?=
 =?utf-8?B?WFV6dStxQ0Irc2x2WldiOGVldnJleEtnY1Q2WW5IbFJWSmF3VkxTNENLRFJh?=
 =?utf-8?B?aFdnZ0ZtdHFTamtSTVQ2TXJSb0pwODYvSXAwVHlxcFp0RXJOclJlU2ZzYmpI?=
 =?utf-8?B?TklFZlRxVktlczNSQjFSanhZZXhrS0ZBK1AyYm1VOFlTWHlmZFBKTDRPUGlT?=
 =?utf-8?B?bms3QVM2K1VvVVhySWNtM09GVUtSdWZ6K2pIUUkvQlpPaXJOczJRQzVkeXlk?=
 =?utf-8?B?YmNkTWpQRFp6bXBOVEFZVWx3bTVJZi9ZbHRKRXgzM2J1a0NvU3l0dE5rbWdN?=
 =?utf-8?B?S1Y5T0RFdkwvSENaRVVrWHdmeWRhR1pVN2l3LzFNM1hlZDNReS9CMVJobzdS?=
 =?utf-8?B?RmQvTTFUK2dCRGtQOVV4SUZNVkdKdnVOZGdaTk9SeHppMWY1WGQ3aVpsQ2Zl?=
 =?utf-8?B?a21mUm5HYWdkT1BmTkRDSzJCOWtmSEkrQlppQ1JmODY0ODRyMndMUWJ1ZWRN?=
 =?utf-8?B?MEpaRUEweE5sazJNcGFJQ05vd2pyNDhCNlNHVnVQRW15dXVqOXQrcVVMckRQ?=
 =?utf-8?B?UHhsb1VIT3pTMlNXcFBuakw5cnA4K0tZM1kzME9ocXZxK3dDbWp6eFg0V3Ez?=
 =?utf-8?B?RVZhZ1kzM0lLQ0NoVEFQRGV6WlJxdmtRYTRYQVcra3pkVUpzQkFjSW1UeW5C?=
 =?utf-8?B?MG5aNDhyMytxU0ppb254dlZDL2NEcDcrL0NmTTBIOGFjOFoxcDVmTjM2bi9k?=
 =?utf-8?B?MHpOdkNCRzNlZWpCdDZCOXNVeHpaVmtpeEpjYVppNk5IUFhzRGFUVjI5a1Ri?=
 =?utf-8?B?RVdaUFVwdXJLVUlrS0VIVWs2MThnSWhpd1BVMitNeDZuc2lPM3ExVHBUdGlD?=
 =?utf-8?B?cjd0dGkwK2RHWThNWTJJaTZZWmtrZnIxWU1xR0pFa2pzbmlSYVpNVStLYjJG?=
 =?utf-8?B?NCt6TXZmZSt3ZDdPd2svNnpGdU9zaUwvdWJyL0xtQTRrL25FZW4zMThDS3Bt?=
 =?utf-8?B?VmZub0xNTzdtdUZoeGVRTTh1UXdlWklXUTUvNGMvdCtUT1h6RVlTVldWb1ZC?=
 =?utf-8?B?bS8ydUpYSWtoWjIwaC9wa3NDUExFZHlQU2I4ckRNSE9FOEZXWDd2VVdHSUJz?=
 =?utf-8?B?d0hjSWZmS1Z4YzVzcVJCd0JhNUhKL1ZETFdsckZEd25wWFNSaGl3Mm4vdkM2?=
 =?utf-8?B?MEVhMXlyVkFVanhRRERaQlVoSGk5QTd0NitPMDJROTcrK1h3SXpxZ1JxR3g5?=
 =?utf-8?B?MnJCckNPRTFIMDdLcnJUQzNlRzVuT2dIYWhacGUzUTUvVjIrdmhLWXNYY3Bm?=
 =?utf-8?B?SjRQaUUyVlRseVpSMWY0M29DcVRIVWxTZmpxeEV5MFpOb3ZVUm5YTGk4Zitm?=
 =?utf-8?Q?aMJgsa0Xv+elizDw4Bgi0im3+?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0de4e9b9-7210-494f-6172-08dc20f1c1f8
X-MS-Exchange-CrossTenant-AuthSource: BL1PR12MB5874.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Jan 2024 17:43:09.4641
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: SmYn9Oypy0xQhmGKDx3yEYX02K7ccaNizlt+eq7iY5G/4CL3QasYr40drpppyVZS
X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV8PR12MB9449


On 1/26/24 11:38 AM, Bjorn Andersson wrote:
> On Wed, Jan 03, 2024 at 02:11:25PM -0800, Tanmay Shah wrote:
> > This patch enhances rproc_put() to support remoteproc clusters
> > with multiple child nodes as in rproc_get_by_phandle().
> > 
> > Signed-off-by: Tarak Reddy <tarak.reddy@amd.com>
> > Signed-off-by: Tanmay Shah <tanmay.shah@amd.com>
>
> As described in the first patch, this documents that Tarak first
> certified the origin of this patch, then you certify the origin as you
> handle the patch.
>
> But according to From: you're the author, so how could Tarak have
> certified the origin before you authored the patch?
>
> Either correct the author, or add Co-developed-by, if that's what
> happened.
>
> > ---
> >  drivers/remoteproc/remoteproc_core.c | 6 +++++-
> >  1 file changed, 5 insertions(+), 1 deletion(-)
> > 
> > diff --git a/drivers/remoteproc/remoteproc_core.c b/drivers/remoteproc/remoteproc_core.c
> > index 0b3b34085e2f..f276956f2c5c 100644
> > --- a/drivers/remoteproc/remoteproc_core.c
> > +++ b/drivers/remoteproc/remoteproc_core.c
> > @@ -2554,7 +2554,11 @@ EXPORT_SYMBOL(rproc_free);
> >   */
> >  void rproc_put(struct rproc *rproc)
> >  {
> > -	module_put(rproc->dev.parent->driver->owner);
> > +	if (rproc->dev.parent->driver)
> > +		module_put(rproc->dev.parent->driver->owner);
> > +	else
> > +		module_put(rproc->dev.parent->parent->driver->owner);
> > +
>
> This does however highlight a bug that was introduced by patch 1, please
> avoid this by squashing the two patches together (and use
> Co-developed-by as needed).

Thanks Bjorn for catching this. This change originally was developed by Tarak, but I sent upstream based on his patch so I missed

to update his name as author. I should update author name.

However, if we are going to squash this in first patch, then I think, first patch's author will stay as it is.

Following Action Item on me for v5:

1) Fix commit text in first patch.

2) Squash second patch in first.

3) Add my s-o-b signature after Mathieu's

4) Add Tarak's s-o-b as well. As he developed second patch.

Hope got it all.


Thanks,

Tanmay

>
> Regards,
> Bjorn
>
> >  	put_device(&rproc->dev);
> >  }
> >  EXPORT_SYMBOL(rproc_put);
> > -- 
> > 2.25.1
> >