Received-SPF: pass (google.com: domain of linux-kernel+bounces-43301-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Sender: Tejun Heo <htejun@gmail.com>
Date: Mon, 29 Jan 2024 08:16:19 -1000
From: Tejun Heo <tj@kernel.org>
To: Lai Jiangshan <jiangshanlai@gmail.com>
Cc: linux-kernel@vger.kernel.org, Naohiro.Aota@wdc.com,
	kernel-team@meta.com
Subject: Re: [PATCHSET v3 wq/for-6.9] workqueue: Implement system-wide
 max_active for unbound workqueues
Message-ID: <Zbfrc__7_kWow5wG@slm.duckdns.org>
References: <20240125170628.2017784-1-tj@kernel.org>
 <CAJhGHyDHP97ZHbDwPwhiYvBWbzvXw_UnXhPs4RRJ6nQBo3_x=Q@mail.gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <CAJhGHyDHP97ZHbDwPwhiYvBWbzvXw_UnXhPs4RRJ6nQBo3_x=Q@mail.gmail.com>

On Tue, Jan 30, 2024 at 12:07:33AM +0800, Lai Jiangshan wrote:
> Hello, Tejun
> 
> On Fri, Jan 26, 2024 at 1:06 AM Tejun Heo <tj@kernel.org> wrote:
> 
> > This patchset includes the following patches:
> >
> >  0001-workqueue-Move-pwq-max_active-to-wq-max_active.patch
> >  0002-workqueue-Factor-out-pwq_is_empty.patch
> >  0003-workqueue-Replace-pwq_activate_inactive_work-with-__.patch
> >  0004-workqueue-Move-nr_active-handling-into-helpers.patch
> >  0005-workqueue-Make-wq_adjust_max_active-round-robin-pwqs.patch
> >  0006-workqueue-RCU-protect-wq-dfl_pwq-and-implement-acces.patch
> >  0007-workqueue-Move-pwq_dec_nr_in_flight-to-the-end-of-wo.patch
> >  0008-workqueue-Introduce-struct-wq_node_nr_active.patch
> >  0009-workqueue-Implement-system-wide-nr_active-enforcemen.patch
> >  0010-tools-workqueue-wq_dump.py-Add-node_nr-max_active-du.patch
> >
> 
> I just left a small piece of comments on patch 8 and patch 9.
> After they are resolved, for patch 1-9:
> 
> Reviewed-by: Lai Jiangshan <jiangshanlai@gmail.com>

Updated 8 and 9 and applied the series to wq/for-6.9. If there are further
issues, let's address with followup patches.

Thanks a lot for all the reviews. Hopefully, this should address the
max_active issue for the long term.

-- 
tejun