Received-SPF: pass (google.com: domain of linux-kernel+bounces-43312-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
From: Zi Yan <ziy@nvidia.com>
To: linux-mm@kvack.org, linux-kernel@vger.kernel.org
Cc: Zi Yan <ziy@nvidia.com>, "\"Huang, Ying\"" <ying.huang@intel.com>,
 Ryan Roberts <ryan.roberts@arm.com>,
 Andrew Morton <akpm@linux-foundation.org>,
 "\"Matthew Wilcox (Oracle)\"" <willy@infradead.org>,
 David Hildenbrand <david@redhat.com>,
 "\"Yin, Fengwei\"" <fengwei.yin@intel.com>, Yu Zhao <yuzhao@google.com>,
 Vlastimil Babka <vbabka@suse.cz>,
 "\"Kirill A . Shutemov\"" <kirill.shutemov@linux.intel.com>,
 Johannes Weiner <hannes@cmpxchg.org>,
 Baolin Wang <baolin.wang@linux.alibaba.com>,
 Kemeng Shi <shikemeng@huaweicloud.com>,
 Mel Gorman <mgorman@techsingularity.net>,
 Rohan Puri <rohan.puri15@gmail.com>, Mcgrof Chamberlain <mcgrof@kernel.org>,
 Adam Manzanares <a.manzanares@samsung.com>,
 "\"Vishal Moola (Oracle)\"" <vishal.moola@gmail.com>
Subject: Re: [PATCH v2 2/3] mm/compaction: add support for >0 order folio
 memory compaction.
Date: Mon, 29 Jan 2024 13:32:16 -0500
Message-ID: <23BA8CC1-1014-4D09-9C33-938638E13C01@nvidia.com>
In-Reply-To: <20240123034636.1095672-3-zi.yan@sent.com>
References: <20240123034636.1095672-1-zi.yan@sent.com>
 <20240123034636.1095672-3-zi.yan@sent.com>
Content-Type: multipart/signed;
 boundary="=_MailMate_531A4F8A-D19F-4C4D-B350-FBF4281FFA54_=";
 micalg=pgp-sha512; protocol="application/pgp-signature"
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?dJcq20gHcBMTl/q7AEGw6OZNQbrJKj/QVh6JSv9ehlHOWNJZX8jfRC8o+/Pn?=
 =?us-ascii?Q?UeyVyqKgGAxUZZFzMHbM9BR3tK3pzhB+9sbQ3lZaY0qIH3O6O6GUH/RMtamw?=
 =?us-ascii?Q?F5XgvrJMOH9yEyt1/tSx8uZlCtR4kBunbwcXY76LdL8M5/fwe483bA7TQwL+?=
 =?us-ascii?Q?WlCSZyCIX6lRU016NzlqAi88khoaTKEDLPQHoIFFMRXF31I16PUWtYly8f3o?=
 =?us-ascii?Q?OIMH9vNW3nbQhUX31tWPOBff1e+RwGeCaEEIc3w7EqaHbMJSHXZqG47dh+Me?=
 =?us-ascii?Q?ms4sBjopjQraW0ajDmRHWH3DQY1t02NjsMiuqZOFG71hknNQXXcQsrGnGPGv?=
 =?us-ascii?Q?4SsLCfXb51ckmvrpnl88hZNcICDAuBPdsTd8grISr3aPxXgjt0m/Mqk4Boh1?=
 =?us-ascii?Q?UBK0e4J95UFTi8SJTTrFXU62cS1Dhm78RDs4EkQnomhOjy3pyOn6OqRX9vql?=
 =?us-ascii?Q?WqMIoRNSdqLAmDJGyQi0s33+B3gN50pFqgpqlfqvVa4u2NGKYP3rbGypylQ0?=
 =?us-ascii?Q?SlqMr4r5qSPUWw71GFiHOV9oos4obzl3srOmbLBcWmmLHfYh1H00KlubdeiT?=
 =?us-ascii?Q?/3EA6FnWZL9sPop2wDNQlSwfar8tKUgmU3B3OKk3Yo7y24G66f4WhiL7VPFq?=
 =?us-ascii?Q?pO1oxrvafDqmMHP/0ffxl2V6MZ/1gXsh0brJAz5UGY5Dx7DsF+PW93To9jEb?=
 =?us-ascii?Q?I9m6D32dpBZEP1VglC+jEKEu9fpBKTis3kYnNs4MpIXbx3qO2uzda7uAvoaj?=
 =?us-ascii?Q?9FGa4i8AE8iKP4DqPkVf5laHzqynquvhjTmzUNFVz53/IG+0lFQf/pAy21kG?=
 =?us-ascii?Q?nl7SbYXFWDe3lY8+gnegt1ER+Svvkw4hwRYvgwpZdTPoPnvc2HPrHIyG6AVL?=
 =?us-ascii?Q?Feay1LEcFYsOFIhvc3eksPuGp9rjs1u5MQ9NODR6mOmwkhaWHTf3PqF+YylX?=
 =?us-ascii?Q?xaTqk0mz4AMmip7qBSBKNJ9HUWQ0OSR/geuzJXE9coj/0BKwtdbE+PzZrpab?=
 =?us-ascii?Q?ZmNXXSAHf17GgvXQL+l1XJBNCyCD1lKBNyTXvExs0m2T51lUfG7NWyvXrnV0?=
 =?us-ascii?Q?iwrEZAQdB6WZObmOKHKoqNxHajDgs9NkllWmmIFdjmHi8Vh2XMEhfvO3sARo?=
 =?us-ascii?Q?AseQEGK5X+EoQrxPokeVtJcoR2DovHG2kDh0d7eR0ZelN7lTJwIevGiJa+NM?=
 =?us-ascii?Q?uQx/Vu2AyTza+BpN/P4ZFBUDSAIUXRjz8IlQ0Kb9sy7pG8Pb3VT1wk8ydnEs?=
 =?us-ascii?Q?u6axhNXY54wJ0GCstLujUDp4SaIQwyxBl3LfYtAKbT7JqIRX7w6ed9GgsT4g?=
 =?us-ascii?Q?PSqyyNLuNdrqI4Qp9iLapLb1MmLXpVoov5tgbFj/Pw3WC+3esNo3Yg2ZXwnP?=
 =?us-ascii?Q?8YXCkE1JINoABOo8MjDSgk4F9PlamG7aRm/b+ZQ9fievMXfWNrmN0MPx9gi7?=
 =?us-ascii?Q?TzpsaMc9+mu7f9aYy9FtzqksTPgVPsS/XUFiwrW9PPolrNM6cRH4FQetlqKJ?=
 =?us-ascii?Q?VR1ghDjdlnYlG71DcJprMRlYrTMWoE8NufWg21RsH6u3b/Op/DInP4HG3jkG?=
 =?us-ascii?Q?MQf5JTUb3PwWolV3gb4=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1df9edb4-21ed-4387-dcfc-08dc20f8a001
X-MS-Exchange-CrossTenant-AuthSource: DS7PR12MB5744.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Jan 2024 18:32:19.0176
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 5sMCKcXqU7MDosND/swG5RTd8er2DQkyhouPa3rzeH1OiEtt1J8Em9cWLwXJHDPS
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR12MB6368

--=_MailMate_531A4F8A-D19F-4C4D-B350-FBF4281FFA54_=
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

On 22 Jan 2024, at 22:46, Zi Yan wrote:

> From: Zi Yan <ziy@nvidia.com>
>
> Before last commit, memory compaction only migrates order-0 folios and
> skips >0 order folios. Last commit splits all >0 order folios during
> compaction. This commit migrates >0 order folios during compaction by
> keeping isolated free pages at their original size without splitting th=
em
> into order-0 pages and using them directly during migration process.
>
> What is different from the prior implementation:
> 1. All isolated free pages are kept in a NR_PAGE_ORDERS array of page
>    lists, where each page list stores free pages in the same order.
> 2. All free pages are not post_alloc_hook() processed nor buddy pages,
>    although their orders are stored in first page's private like buddy
>    pages.
> 3. During migration, in new page allocation time (i.e., in
>    compaction_alloc()), free pages are then processed by post_alloc_hoo=
k().
>    When migration fails and a new page is returned (i.e., in
>    compaction_free()), free pages are restored by reversing the
>    post_alloc_hook() operations using newly added
>    free_pages_prepare_fpi_none().
>
> Step 3 is done for a latter optimization that splitting and/or merging =
free
> pages during compaction becomes easier.
>
> Note: without splitting free pages, compaction can end prematurely due =
to
> migration will return -ENOMEM even if there is free pages. This happens=

> when no order-0 free page exist and compaction_alloc() return NULL.
>
> Signed-off-by: Zi Yan <ziy@nvidia.com>
> ---
>  mm/compaction.c | 148 +++++++++++++++++++++++++++++-------------------=

>  mm/internal.h   |   9 ++-
>  mm/page_alloc.c |   6 ++
>  3 files changed, 103 insertions(+), 60 deletions(-)
>
<snip>
> @@ -1462,7 +1489,7 @@ fast_isolate_around(struct compact_control *cc, u=
nsigned long pfn)
>  	if (!page)
>  		return;
>
> -	isolate_freepages_block(cc, &start_pfn, end_pfn, &cc->freepages, 1, f=
alse);
> +	isolate_freepages_block(cc, &start_pfn, end_pfn, cc->freepages, 1, fa=
lse);
>
>  	/* Skip this pageblock in the future as it's full or nearly full */
>  	if (start_pfn =3D=3D end_pfn && !cc->no_set_skip_hint)
> @@ -1591,7 +1618,7 @@ static void fast_isolate_freepages(struct compact=
_control *cc)
>  				nr_scanned +=3D nr_isolated - 1;
>  				total_isolated +=3D nr_isolated;
>  				cc->nr_freepages +=3D nr_isolated;
> -				list_add_tail(&page->lru, &cc->freepages);
> +				list_add_tail(&page->lru, &cc->freepages[order].pages);

I did not increase nr_pages here, so compaction_alloc() thought no free p=
age
was isolated.

This is the fix:

diff --git a/mm/compaction.c b/mm/compaction.c
index 335a6f6787e4..fa9993c8a389 100644
--- a/mm/compaction.c
+++ b/mm/compaction.c
@@ -1638,6 +1638,7 @@ static void fast_isolate_freepages(struct compact_c=
ontrol *cc)
                                total_isolated +=3D nr_isolated;
                                cc->nr_freepages +=3D nr_isolated;
                                list_add_tail(&page->lru, &cc->freepages[=
order].pages);
+                               cc->freepages[order].nr_pages++;
                                count_compact_events(COMPACTISOLATED, nr_=
isolated);
                        } else {
                                /* If isolation fails, abort the search *=
/


I will send out v3 once I rerun vm-scalability and thpcompact.

--
Best Regards,
Yan, Zi

--=_MailMate_531A4F8A-D19F-4C4D-B350-FBF4281FFA54_=
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename=signature.asc
Content-Type: application/pgp-signature; name=signature.asc

-----BEGIN PGP SIGNATURE-----

iQJDBAEBCgAtFiEE6rR4j8RuQ2XmaZol4n+egRQHKFQFAmW37zAPHHppeUBudmlk
aWEuY29tAAoJEOJ/noEUByhUqOoP/iGdf1zf+AEQ6shsWVGXQDpaHvSjBYBa1+xe
RWNjX+N2na4MoymOYCtExonMi6Wa5vc5DglfVs6WXN38TQRYybbYAUhFg2soVxx0
Z9y62ixIW//8y2cPfb0fg6WJXw8aIMHkmDK9gf8KTf5nTxOkFBxUcPJsTaB17XZf
yY1I1qljmVNdf85Jy4u36DtoXP0+YqedpjBwrqIgIKgf9TWcRPioNCKb6htzmH+h
c5fOWVAtdBCsCoGyjklP/LJ96rZNgN1i+tw2+uWwpNIeB2HHbJxq4ZLkdM3NC7br
KaOf28TaHg5MTnOyMVurS4ehNJNJbkikxIerDa8qDcxGaNXidGyHwN1FcWkdZJEH
cnnA5Cl/cpCypCOETrSqdOQttNtQbARC66SjumLGnrxrK41O7xTFuDTH1btU3Fu/
rVNmwva7j87P1r6i5M7GjG/acCAc9v6e9kR2555j3M8EbsxHt4MCQNboAlknZbSP
MMCPx5G6w7yjKdqBnGLGvz1pW3TVKqgsOpYCGILnB2kzVgAAD67/Qm7OHdwFxuwF
M5UpXGj8SatAOOoxHAkQQdTDWxauZM7xrAru2jj5ThNjMaRfHANrSVN/Q8/UsdEt
lfNBRqXlJRst5f6XfCQivmD7LvienjVl0TU0FIH1rbzHyHZPj3f1C5rJjq3eKwk0
iV30atSu
=V/a8
-----END PGP SIGNATURE-----

--=_MailMate_531A4F8A-D19F-4C4D-B350-FBF4281FFA54_=--