Received-SPF: pass (google.com: domain of linux-kernel+bounces-43412-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Precedence: bulk
MIME-Version: 1.0
References: <20240129174150.655088-1-dlechner@baylibre.com> <20240129174150.655088-3-dlechner@baylibre.com>
In-Reply-To: <20240129174150.655088-3-dlechner@baylibre.com>
From: David Lechner <dlechner@baylibre.com>
Date: Mon, 29 Jan 2024 13:31:38 -0600
Message-ID: <CAMknhBGEm6EOFf17xiYf0+h0JNS-NtfW3GnpsUc9e8PxCZ7tVw@mail.gmail.com>
Subject: Re: [PATCH 2/2] iio: adc: ad7380: don't use bool in FIELD_PREP
To: Jonathan Cameron <jic23@kernel.org>
Cc: Michael Hennerich <michael.hennerich@analog.com>, =?UTF-8?B?TnVubyBTw6E=?= <nuno.sa@analog.com>, 
	linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, 
	kernel test robot <lkp@intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Mon, Jan 29, 2024 at 11:43=E2=80=AFAM David Lechner <dlechner@baylibre.c=
om> wrote:
>
> Although this technically works, it is better to avoid using bool as
> a bit value.
>
> Fixes sparse warning:
>
>      drivers/iio/adc/ad7380.c:353:34: sparse: sparse: dubious: x & !y
>
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202401280629.5kknB57C-lkp@i=
ntel.com/
> Signed-off-by: David Lechner <dlechner@baylibre.com>
> ---
>  drivers/iio/adc/ad7380.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/iio/adc/ad7380.c b/drivers/iio/adc/ad7380.c
> index 44b8b18ab213..a4aa0db47720 100644
> --- a/drivers/iio/adc/ad7380.c
> +++ b/drivers/iio/adc/ad7380.c
> @@ -350,7 +350,8 @@ static int ad7380_init(struct ad7380_state *st)
>         /* select internal or external reference voltage */
>         ret =3D regmap_update_bits(st->regmap, AD7380_REG_ADDR_CONFIG1,
>                                  AD7380_CONFIG1_REFSEL,
> -                                FIELD_PREP(AD7380_CONFIG1_REFSEL, !!st->=
vref));
> +                                FIELD_PREP(AD7380_CONFIG1_REFSEL,
> +                                           st->vref : 1 : 0));

Somehow managed to introduce a typo between testing and sending. :-(

Will send a v2 with the fix.

>         if (ret < 0)
>                 return ret;
>
> --
> 2.43.0
>