Received: by 2002:a05:7412:d1aa:b0:fc:a2b0:25d7 with SMTP id ba42csp608164rdb; Mon, 29 Jan 2024 12:06:34 -0800 (PST) X-Google-Smtp-Source: AGHT+IFaMJ5QQP0a/Ljum6zDNsuSU77tixWqOB+cL/4EehxdOSCHfXBpbgb21rNw0LupmLitAjhu X-Received: by 2002:a05:622a:d3:b0:42a:8ad4:f723 with SMTP id p19-20020a05622a00d300b0042a8ad4f723mr8098245qtw.5.1706558794703; Mon, 29 Jan 2024 12:06:34 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1706558794; cv=pass; d=google.com; s=arc-20160816; b=WTeA9Bpt27LNY4ql4MlslyevorSNm/O9Fpe2D21wE2q2o1VNOJOtRh5EBNlUBP3zRb q3aAj0KmBaTSMcD1KDBQNflEW9EVc98AFjkkr8rbpIpnditdcyT0PAj+yMiPck03T1gG FwhuUbuyRrEkcJ6JqwYUHQLe83+0NEZ4wRHjlCN8gsJTClo5gFz++PQWNwDL/yCSyRCC BHtnD67voB9Si3cqWXSCMQxTZC8E8ThUphxzyTIiOzx8k764+mthY7KDTUyCeVKvFyeU 7jfSWDk3kwscdIDO533YKoy4q56jSLnwjNtrg+evCXxrT8zwftNj53QJaIfObImZ4P/v FrpA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :subject:cc:to:from:date:dkim-signature; bh=Z7EW/4nYGIdrEtaPS4mrKCgVWTM0w3ifcaCMcp319K4=; fh=240pdl1UqsJsf9eVESbLXEMw5twn48hQBjYwrkWq8BA=; b=JYWB3j+zB2OL/3gVh3t1Ky3b5ooH/4rhftvGEB6veIQXOHCPZaH15LKwZxYoNGAsKm NL4IdrBWtf4skL+Lb8gJt3L52q6hvyUMgFWcUwGqNv1LX1QFEbNDr6H3XLbPKexZfeWC D7sI0FbzIIyafbhveRA5LaDW8QNz41/r/Wu/eKNCgjR8jvod56RypFrcRr/hOfMZPJUS 42S+cJz+gZUkZ71rP/jZ6m3H+CGenYa7AHgkpfCSBelHzdZBJQeSQHEIQIdIClS/mU9n 3isY7NVDcLGksUXgFru1TrRvKw4rfMjj5b5qTog4+qSTKLlQer8UC7TRutYW6RN2GZ10 XxqA== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=kf+NJgmf; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-43450-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-43450-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id b10-20020ac87fca000000b0042ab38d00e2si237137qtk.218.2024.01.29.12.06.34 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Jan 2024 12:06:34 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-43450-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=kf+NJgmf; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-43450-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-43450-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 518B71C2483B for ; Mon, 29 Jan 2024 20:05:53 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id C198276053; Mon, 29 Jan 2024 20:05:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="kf+NJgmf" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A389676023; Mon, 29 Jan 2024 20:05:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706558744; cv=none; b=Uh4i1u1NVF5N3xrSIujXfTw1gKqGWGh6AyeGBqt2JvsY9w3OdfAVU7eeL/M1NXDdsb/tlC20f1Re1KRbkLsj6IvJtctM6ZYshFkKlbjL9EkyzMPjuUsazzu9pFkTlCkaOjz+y9I89zhsPTuk0Wj1hzO5sCis+qW5RqV+q97v6ZA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706558744; c=relaxed/simple; bh=8m6RSucF6xsOWibtMoJwrvmBk6giWU4417H7w22bFAQ=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=kClenbQBROAVc6PwORgtlghjCsXv7f3EsoXm1+6unjFge2fd8StlOywBsh5u7XWhmsRiWEGDNHWqGGv+qnbfL0Rp5JXVmp8G0y9fJ35jP+RO/4A7RfotFI40LyoepGNP2bebkfTwtWaaKxv0yfLV7prhtd7vN+St198N06hkz+c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=kf+NJgmf; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id B4838C433F1; Mon, 29 Jan 2024 20:05:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1706558744; bh=8m6RSucF6xsOWibtMoJwrvmBk6giWU4417H7w22bFAQ=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=kf+NJgmfA2IUhtAFmzQ5aRjWp9TThBFC1IfHNcFCrxx3tHn2M4JVJW5e7P8cqZ5hh fRPG2Ud+zZ5P3C3dFF1W/Jdc1uSfUHemz3bOq8BXuScxO7bDu6+s4zsrJRfn/Cbx1v fSOM2vo/hq/6EhdhcF1TIOfjHz6yxpJaIbCLjm1ZFkN2G2hekMi5+Jo6MD1XpQJ+iT sY42LngM5u+y64wLUvleEw2wGKMp4Xv0Qojhl57A4zI7AGox8FCGWtF6XJIqbILAQ1 +R8Oa42YlAUKTI1zQjXUZ7EnF5lHObEzFqBBGsN7vybJO8HzgGgh3utXSiNFOWI3SM WYd4m6LrU4rHw== Date: Mon, 29 Jan 2024 12:05:42 -0800 From: Jakub Kicinski To: Brett Creeley Cc: Brett Creeley , davem@davemloft.net, edumazet@google.com, pabeni@redhat.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, shannon.nelson@amd.com Subject: Re: [PATCH v2 net-next 0/10] pds_core: Various improvements and AQ race condition cleanup Message-ID: <20240129120542.39757c00@kernel.org> In-Reply-To: <7da8652f-a466-4b38-8d0b-6494e9901a98@amd.com> References: <20240126174255.17052-1-brett.creeley@amd.com> <20240126204423.47c20ef6@kernel.org> <7da8652f-a466-4b38-8d0b-6494e9901a98@amd.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Mon, 29 Jan 2024 09:27:21 -0800 Brett Creeley wrote: > > On Fri, 26 Jan 2024 09:42:45 -0800 Brett Creeley wrote: > >> This series includes the following changes: > >> > >> There can be many users of the pds_core's adminq. This includes > >> pds_core's uses and any clients that depend on it. When the pds_core > >> device goes through a reset for any reason the adminq is freed > >> and reconfigured. There are some gaps in the current implementation > >> that will cause crashes during reset if any of the previously mentioned > >> users of the adminq attempt to use it after it's been freed. > >> > >> Issues around how resets are handled, specifically regarding the driver's > >> error handlers. > > > > Patches 1, 2 and 4 look like fixes. Is there any reason these are > > targeting net-next? If someone deploys this device at scale rare > > things will happen a lot.. > > No reason, just an oversight on my part. I actually think patches 1, 2, > 3, 4, 5, and 9 could all go to net. Unfortunately some of these patches > are intertwined (i.e. patch 10 depends on patch 9). > > If I push the previously mentioned patches to net and they get accepted, > how soon are fixes typically added to the net-next tree so I can > rebase/re-push the remaining patches? net gets merged into net-next very Thursday, exact timing depends on how quickly Linus pulls from us.