Received-SPF: pass (google.com: domain of linux-kernel+bounces-43480-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Mon, 29 Jan 2024 15:39:04 -0500
From: "Liam R. Howlett" <Liam.Howlett@Oracle.com>
To: Lokesh Gidra <lokeshgidra@google.com>
Cc: akpm@linux-foundation.org, linux-fsdevel@vger.kernel.org,
        linux-mm@kvack.org, linux-kernel@vger.kernel.org,
        selinux@vger.kernel.org, surenb@google.com, kernel-team@android.com,
        aarcange@redhat.com, peterx@redhat.com, david@redhat.com,
        axelrasmussen@google.com, bgeffon@google.com, willy@infradead.org,
        jannh@google.com, kaleshsingh@google.com, ngeoffray@google.com,
        timmurray@google.com, rppt@kernel.org
Subject: Re: [PATCH v2 0/3] per-vma locks in userfaultfd
Message-ID: <20240129203904.7dcugltsjajldlea@revolver>
Mail-Followup-To: "Liam R. Howlett" <Liam.Howlett@Oracle.com>,
	Lokesh Gidra <lokeshgidra@google.com>, akpm@linux-foundation.org,
	linux-fsdevel@vger.kernel.org, linux-mm@kvack.org,
	linux-kernel@vger.kernel.org, selinux@vger.kernel.org,
	surenb@google.com, kernel-team@android.com, aarcange@redhat.com,
	peterx@redhat.com, david@redhat.com, axelrasmussen@google.com,
	bgeffon@google.com, willy@infradead.org, jannh@google.com,
	kaleshsingh@google.com, ngeoffray@google.com, timmurray@google.com,
	rppt@kernel.org
References: <20240129193512.123145-1-lokeshgidra@google.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240129193512.123145-1-lokeshgidra@google.com>
User-Agent: NeoMutt/20220429
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?us-ascii?Q?ukIh+X+REqYgcgSp/ihrciTxBm8Nf9wqq2SVNuqgaaH0ZccX51hsEIkVw24g?=
 =?us-ascii?Q?SqDNcW22B0dFt5Awl6adZF0rvVApiV+dOmNYWkQRX6xJRuJGJdJSf4kqzrTJ?=
 =?us-ascii?Q?0m2RAq80ZUYyhu3TBcjI9xFq+LUpKyaEHqc3pAbncakaNIZfAk9HDVp3qnjE?=
 =?us-ascii?Q?dgUoRiq1dgxVXCMkBXcfs4jupxAnXlPVeQSvrLbmCR21VDFEckDyKq4ajNUL?=
 =?us-ascii?Q?UxH2OXmFAJGXDZuH6qvAvBeuCmsrDNqvttE59bAoYlMxxVMNERZvwYAjyvD3?=
 =?us-ascii?Q?/3L4WXqvZMew/VJlzlsrn+upKN2hNZhTbe2TpY9Q1Pe7riMz8EHY7gMJcTYo?=
 =?us-ascii?Q?40SpX8pOyCjb59M9k7zKruAx7zP1If1/1L3XP/zKht69A7NA8zely5o2RpSJ?=
 =?us-ascii?Q?Yaa+uwAjb6ELdU21ameifA9i2/B+SEy6hUU0VnpQ8LG77OzB/OARjBCAj2+A?=
 =?us-ascii?Q?TIunn1OT4skzjHYMGxQrgKb4NmCGaRBEtacyBwTHA4ecy/lRFzlX0QEW0hMp?=
 =?us-ascii?Q?1DOVVr2tQufSCFdVNp6WxJk7Ca1ypPDTaoxOKWvjhoq4e4q8HSNZaEDDkxfY?=
 =?us-ascii?Q?wBx2A1oCcY9LORMmhLjRdVufkMhAHOY0MLwNBSCZOkhD1Xs8oaXaUOPKuIGr?=
 =?us-ascii?Q?w3W5mzXr8QcW69i/ndbfFZquwboS1iuuWPCCRz9kQOcpe2Yt9TA0o3FSEJCq?=
 =?us-ascii?Q?Cm3HLK4jzI7+gQj6hsJyLdKAYq6aaKwGTB9sn4z+LwBxMOm1xkjSr5BPjaB1?=
 =?us-ascii?Q?yfynWYiTQoc5CJZ2s09Dj41gTZLwt7LEb3Y0YwgT2WUDrekrOi98Fo+Tlq4J?=
 =?us-ascii?Q?FLQqyjYVj8jZKHEVPxqew+7OmTtMGf3KIFsufpvp1YSZJAHJea/EDVdFR7Nl?=
 =?us-ascii?Q?1hap8KDwL2uDpMo5vgXnFd3NwsLCIpi34xaYOBg3BYKwbCN5mgdoNIQNPCaw?=
 =?us-ascii?Q?taXAg8I9qtNZYt+7QUDSvXuZd29VqwW8mjpEIgL2j3WHUL7Fca97BKSFgrZ+?=
 =?us-ascii?Q?fzPdOR3glTLJh1+U9UIN6uQ53OjeFCwmkljEArah5vW/dh6bjtOdWXUNzvqT?=
 =?us-ascii?Q?NcXRA56UeVH5MQwmvpZ2u87fPuFOl1dpjtH5BOne58+OQzsXhJjxKcX+nRY/?=
 =?us-ascii?Q?7CO9FN2k6hslS1k1t0m0FW7qAlZV82cfPYCOkEtLrLgeo9WMODldcJZxClbA?=
 =?us-ascii?Q?CznMRzE3PhnBR+2nkNV9/2xnPUDipM4tLqZs07FolW1QVvydEJ547aXYvPV5?=
 =?us-ascii?Q?9XjDhbAC+iqRQXO595xAOI+rPdTIAS3BEHmYZGsb9KB2oH6mKYMNxVIUOjm6?=
 =?us-ascii?Q?/LUeLaYQduH+fKdS/w+xIFUsfRFaHzr5yPOKGGpi3J4/Y0ZynAJLXhTig8QQ?=
 =?us-ascii?Q?nB2Bc3+DEEXL8V10oop4uavbFXuLWKTMgFqGfljJqaBJ5nTIDFBCiVPdUyT4?=
 =?us-ascii?Q?iiaLPRRNv18cVQy98PtEsDbTsSreyCG+PfPhJCAMea9vQcQEgzqLozensLr6?=
 =?us-ascii?Q?lWyJp2lhYGtobVGnjeI8rcClrtJJJLaOaSX4+WPPIq6OKHQu2VjT/OtmzxUn?=
 =?us-ascii?Q?Id3UNL+2obp70kDK1l8BB1OHSjjoEBriiK9bNN95?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	dZJQy+YAptTIOOL4zfrz1aG8+8tngN2/YK9ojDHmpXQOFp+JfnPe3qc3GWejQN3Ue2pki/SKl3h4Xm34+4mMg7uc+wYvrP7WLbW6apfSFhY2XwSNPcYOSGiwfbezm7WIOD4sLpC61NqN+4SFaNHN0/64E/Seo+UpzRu0oEo/CHLSQ6KCAbhg34NFtUK5d7z77f1lPZT3sF/1Uhq/0MUbTzuUNuSoj1qgQ+ycTQPlUe3TIW4jo9+ddSgNWI+EsZAbNNTGMgyVUHF1IFjT1LGveRW/BgjNtFm7bN/efQbjOLZOPv6i6fyV6BxvOp2OB/2L533J7+CVVMYFko8BWlSDTEiKJkf9ld+QFAxTHRe0/is6x2LlzuKQM6V3togA03ztN3N0go0VgXTVP1iEJkQTopPJ+lEI/ASm0460jvciG2llm307mv0jEJ/bQvzIPTcjwO75uIVwSrZYTWPk/qdd6K/NL3MnW1Il2whaWTPkSEXnfcea0H5EcjAUJDlYCSqr1YoxStD+u1HacVi04y5JyfanKzUzCXJmJvMkwLz+ftZL1nEn+hHyARsqU9dT3n9Ml9de1hb1RUg0Lo8o/daXvyWz4iVAWpWRZoVGcW83n10=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d50ec3aa-0e85-432d-89ae-08dc210a56c9
X-MS-Exchange-CrossTenant-AuthSource: DS0PR10MB7933.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Jan 2024 20:39:07.0250
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: k5a/Z02hDaCf6utspHDM3KYhfAj50UlM9Q5l0MT6KY1qmYAlXn9ad4MS6X3SUjTYyb+UDSD9nyhl0EeO3Cs5Fw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN0PR10MB4968
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2024-01-29_13,2024-01-29_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 malwarescore=0 mlxscore=0
 spamscore=0 suspectscore=0 adultscore=0 mlxlogscore=521 phishscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000
 definitions=main-2401290152
X-Proofpoint-ORIG-GUID: xw-7LME-MqOsasFHSgLLeZoRv6qp6eZs
X-Proofpoint-GUID: xw-7LME-MqOsasFHSgLLeZoRv6qp6eZs

* Lokesh Gidra <lokeshgidra@google.com> [240129 14:35]:
> Performing userfaultfd operations (like copy/move etc.) in critical
> section of mmap_lock (read-mode) causes significant contention on the
> lock when operations requiring the lock in write-mode are taking place
> concurrently. We can use per-vma locks instead to significantly reduce
> the contention issue.

Is this really an issue?  I'm surprised so much userfaultfd work is
happening to create contention.  Can you share some numbers and how your
patch set changes the performance?

> 
> Changes since v1 [1]:
> - rebase patches on 'mm-unstable' branch
> 
> [1] https://lore.kernel.org/all/20240126182647.2748949-1-lokeshgidra@google.com/
> 
> Lokesh Gidra (3):
>   userfaultfd: move userfaultfd_ctx struct to header file
>   userfaultfd: protect mmap_changing with rw_sem in userfaulfd_ctx
>   userfaultfd: use per-vma locks in userfaultfd operations
> 
>  fs/userfaultfd.c              |  86 ++++---------
>  include/linux/userfaultfd_k.h |  75 ++++++++---
>  mm/userfaultfd.c              | 229 ++++++++++++++++++++++------------
>  3 files changed, 229 insertions(+), 161 deletions(-)
> 
> -- 
> 2.43.0.429.g432eaa2c6b-goog
> 
>