Received: by 2002:a05:7412:d1aa:b0:fc:a2b0:25d7 with SMTP id ba42csp638974rdb; Mon, 29 Jan 2024 13:17:41 -0800 (PST) X-Google-Smtp-Source: AGHT+IG4r2g0G53NdgQ/wwj0tGoxdMi3MthZwT5HWBf9NDCxZOafSfaOoRZlrw8+Tn2yX2zJqz2+ X-Received: by 2002:a17:903:2450:b0:1d7:620e:d2d8 with SMTP id l16-20020a170903245000b001d7620ed2d8mr4002372pls.41.1706563060696; Mon, 29 Jan 2024 13:17:40 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1706563060; cv=pass; d=google.com; s=arc-20160816; b=ICFrjVfzin7VlTF+lrsJvbU9BQnhSIZH6UBCoQKsmbtPHDHVzqMs0d4t8/ND1YarQl kUL5ilWYzqdWEbQ9ixUB9+bq0WfrJjhdLYVwD/PSGrCBpUgknAfE/RvrS1krNNzugRY3 uTJXauhf7/CtVpamwwOwcxvxRM35PJAnEyp93HdEAqPJNmWa4OB9OiCEStjKA6CWiOdu pogMkZjOQmiP0klyyuDP0t0J0asytCPGUIoQ331quw5Pbjel03Y1ZHrFQ8ecMXVqsT8N WK/vLkcSSO7qCI0vji0tlC1ta25A6utv6q07LH2QFA8uyswO2YfzBVwIL9QHkkNoXfB9 ZJkw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:in-reply-to:content-disposition:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:references :message-id:subject:cc:to:from:date:dkim-signature; bh=IkjdIBKoiOcpY02ZoVDX9S0wFvKlvTpVElGZtMaUhdk=; fh=LRYw7OSkMuas/8+OWptva2F92wLb01JMRcONOs1pGjM=; b=D05B1QGQIxTAYEOQVQJmOuWJeqbF3nyyj9Rrhxrk5qev+fPTS5qpi3xcaKR55wyMjd dLHIqOmUSrQe7VmFLFvdOm9JmylCamPH0A8lgMEN5bIAnBWyQhXkkGT7mIb3XcZOJTxO jH1RIH7B8TbJM35ch8U/FCgZLnHxYoLLKfqKaMNsDaFjnaYv+aNyB/1/vq9CFTpaM3xE rKCp+92O7cY0OquMkWCDeKakjt3Y0sc0R8v/6cfBpqZn5fQvmji+zu2Nb8tMPiUYVIXw 6zOWVAQkObfw9bBBoZDs7Gq6A+cT/Sxbc36JsFGp3x5KGt0NIHrxcVO1fXMg89ScNXk3 6WxQ== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=X37HBjAl; arc=pass (i=1 dkim=pass dkdomain=infradead.org); spf=pass (google.com: domain of linux-kernel+bounces-43447-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-43447-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id b7-20020a170902b60700b001d8a652d259si5619341pls.350.2024.01.29.13.17.40 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Jan 2024 13:17:40 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-43447-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=X37HBjAl; arc=pass (i=1 dkim=pass dkdomain=infradead.org); spf=pass (google.com: domain of linux-kernel+bounces-43447-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-43447-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id B4C59285E65 for ; Mon, 29 Jan 2024 20:01:40 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id D419276040; Mon, 29 Jan 2024 20:01:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="X37HBjAl" Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7B8BB48790; Mon, 29 Jan 2024 20:01:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.137.202.133 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706558496; cv=none; b=jKzh7XLDkKPY61CBeDqziNsULSYkbInci2nleDVv6k7IF83W5beqwZUXtb5VPg2FbjBk6tfCNQSEu0DqzVfnQsBKygCj7XW2+UJTI3RX4KfQlKjqncs4HdZqdnxMN1PpLsWCwlu/8JXIW7HZqdg5Gh+KczuSuxQ9OgJ/XSWdIAY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706558496; c=relaxed/simple; bh=ISg0qWcsic3NhSTT26Ik0LHaKUMiqMelriiZGFHLbPU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=VP6+gmzkJwKUSIKQpj2n0uVZQCxDEJ65yJKEUWwzAWr1B28erC+5SFWU9O7RKmD4CTX3Q54cRDJBbwCR79YySZ5mDdSr8bOaeBV93z/5I0SZqMSbpraJxz+0qnmDsslhuEdNz0Fop+ueHNm+cs2ZkjenRMO9nx2wTEscR1PBbos= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org; spf=none smtp.mailfrom=infradead.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b=X37HBjAl; arc=none smtp.client-ip=198.137.202.133 Authentication-Results: smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=IkjdIBKoiOcpY02ZoVDX9S0wFvKlvTpVElGZtMaUhdk=; b=X37HBjAlM/ZTVyv4M+Ru3y1KCO C6lhWPaBK270WH1qmBnFhd/oyk8xgfveopnpjnJZGxcz8Vf9NtUsiEtSx1FLfBXMiEjRkDivFbkN4 4ZdaWE6ueAlWYVSDxGkd5rF7BFDKmH0DPFm/FS5ocfYe1P/NbrZbPklkeBpNWm6CTgLsQJDkN9xM1 vG2spEQNGsBVFP/KtCe8Xs+m2MOPvZchqnEpAJls51agfmn5ODO7VCouatGuR1oF/a6OF/NHQaObO ah5h7NOO4RmDHijLwtKXnR+TTKQprLT1hvRHV1Yx8HtceS5aIKZTzmwkXKvHY8MG0gwkG6sZh/r5/ pcIK1Asg==; Received: from mcgrof by bombadil.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1rUXoz-0000000EBhU-2uy5; Mon, 29 Jan 2024 20:01:33 +0000 Date: Mon, 29 Jan 2024 12:01:33 -0800 From: Luis Chamberlain To: Christophe Leroy Cc: linux-modules@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/3] module: Use set_memory_rox() Message-ID: References: <98d4db94f19737fe05fd811a4188ff277b83a334.1703143382.git.christophe.leroy@csgroup.eu> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <98d4db94f19737fe05fd811a4188ff277b83a334.1703143382.git.christophe.leroy@csgroup.eu> Sender: Luis Chamberlain On Thu, Dec 21, 2023 at 08:24:23AM +0100, Christophe Leroy wrote: > A couple of architectures seem concerned about calling set_memory_ro() > and set_memory_x() too frequently and have implemented a version of > set_memory_rox(), see commit 60463628c9e0 ("x86/mm: Implement native > set_memory_rox()") and commit 22e99fa56443 ("s390/mm: implement > set_memory_rox()") > > Use set_memory_rox() in modules when STRICT_MODULES_RWX is set. > > Signed-off-by: Christophe Leroy Nice simplification. I applied all 3 patches and pushed! Luis