Received-SPF: pass (google.com: domain of linux-kernel+bounces-43512-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <37af8f84-98bc-4733-bd9c-102b62fdd028@oracle.com>
Date: Mon, 29 Jan 2024 15:17:27 -0600
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] jfs: fix shift-out-of-bounds in dbJoin
To: Matthew Wilcox <willy@infradead.org>
Cc: Manas Ghandat <ghandatmanas@gmail.com>,
        Linux-kernel-mentees@lists.linuxfoundation.org,
        jfs-discussion@lists.sourceforge.net, linux-kernel@vger.kernel.org,
        syzbot+411debe54d318eaed386@syzkaller.appspotmail.com,
        Sasha Levin <sashal@kernel.org>
References: <20231011143937.31996-1-ghandatmanas@gmail.com>
 <Zba9zRWq6rZhWn-p@casper.infradead.org>
 <a25c75af-c961-4ca6-9810-dbcfe64753d5@oracle.com>
 <Zbe8c_CPNP8IdphB@casper.infradead.org>
 <551e1e86-f990-487a-ad88-53799df0882a@oracle.com>
 <ZbfumG4uLUwZkzlf@casper.infradead.org>
Content-Language: en-US
From: Dave Kleikamp <dave.kleikamp@oracle.com>
In-Reply-To: <ZbfumG4uLUwZkzlf@casper.infradead.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?utf-8?B?RXZ6L3RHNjAxaUpmeHJYOFp4L0NkYXl5djNmS1RzcnJMQm9GOUs4OXlIODJU?=
 =?utf-8?B?Z1ZGUHBBQmo0UGRJL1A3Q1pkNE1DcUJzc3dFQ0VQcC9Zbk11NDE5cjNZeStT?=
 =?utf-8?B?bmVsejRZNGw1dVZiTnhmQzVnV2l0K242Vk1wdVhyYWFzZklFeVFieGJPTmU4?=
 =?utf-8?B?T3kxQTd1Yzc5RWNuazJZR1dwaFBKQ3RiT2dDUnRWU1dIaFl4M1A3TTdIcUNL?=
 =?utf-8?B?SVQwdmIxZXdiMmFRbHRieGEwbTNFM1MrODJ5WmM4MHAwUVpWODNIODkrYVVK?=
 =?utf-8?B?RnYyOXdNbVFTN3BDV3Z2a0ZET1VjcmdzRmFxQ2xUNVN4NG4wK1paNFljakNU?=
 =?utf-8?B?K2YvY1picVlvS0xYbExWeWJMeEZuZlp3bklEaWxMcmVJWWpHbU1NNjJjeEt2?=
 =?utf-8?B?STQ0cGNVYzQzMTlQMGlDMXpEdEpzY1NJU2tDeVFOd2FjYldCeEVxdjJQOWYw?=
 =?utf-8?B?eGk0azRFdUNORW4rVXN6Z3YxU0Q2S0tXbytDSHd3UXh2RHVjc2N1dDZLS0ZX?=
 =?utf-8?B?ZXRES1RWdUE1TTIxS3ZRV3I0cHFkdElMZ2VteW15aUNkNm1CbEZ6d0tMd0JX?=
 =?utf-8?B?R2RoNjdiM0FQSkRyWHdSOGh4N3BmbHRyTFVBMjFuQlJLMUdWOVVuVnZjUnBh?=
 =?utf-8?B?QmsxajNiYm00NmVqUXJLSkVqN0R2cjc1VXh4WWk3dnZwUTN2NDJNL3R2Y3RB?=
 =?utf-8?B?MnU5cG40WWNBeTJJak1Qb2J6QkQrV0F2YURyOVRNM2duQ3B1cWQ0eS8xRU0v?=
 =?utf-8?B?L25vTU12bVpuV1lPN1lscXc4dElTRGxYbWIzUjNOOFJSOWVxdk5WRTh3TXdL?=
 =?utf-8?B?WVBJRTdKR0ZhVkNGaHF6OVBwUVhGZ1UyTi85L1JaVm1KMHQrSithbzJXZXhP?=
 =?utf-8?B?SEpQZGl5WnJIbmJOamhaOUROcElZcm84ZHZKa0pvOCtWd0Z6dUFKT2p3YlFX?=
 =?utf-8?B?cTF3ZnRJa2Y3MFFFbFB0b2sxdHRUY1htWWVlTzJxZXNHcklqSnppVkRCMzhD?=
 =?utf-8?B?dENkVWY2Unltd3B1SkZWcmIyaDV4NUJLTTFTM3pxbjRlRkd1NnFRaDlNQjY4?=
 =?utf-8?B?dGhxSk1vcUI0RlpML0VneHN1WE9qNGJoUzAyakhYNDJ2OW9OMTFucGhMNGMz?=
 =?utf-8?B?QTFQM01rQmVVTno5alNwMFJuODJOQW8zbzYxMlk0NHltTVFsa0Q1THpOYWlj?=
 =?utf-8?B?Q0ZFWHRWRXIzVXZzQmtyVFgwclZFcTN3aVhJeXM4b0hFTzJXQmN3YTBQRWtB?=
 =?utf-8?B?QUlkdDRweXJOeVpSVmtjZjZTT2Y4amxPVDBQeE5UVnJEZno5d3NMTzBYbXB1?=
 =?utf-8?B?MjdibXZVOGNDbEFjMDI5RmhhaDJVUjExN0lhS1RhS0xJazdrZEJoUWR3Qmll?=
 =?utf-8?B?b2NVN1FPcFV5UGRQZGUzZUlkT25WaW5pZzNwa3hLbk1wQUJtdEpoalZVN1Rp?=
 =?utf-8?B?SjlaZEhyd0s4RG9jNkI1b1NXcEF1UmhPMlBXNFBmekZYMG56SHFDTzNGc3p0?=
 =?utf-8?B?N25aTWhGMS9UZG1GSnRZVGJqNXk2MDNCVmxzME8zWWFWa09JbFl0VDlhdVFi?=
 =?utf-8?B?empPR0QxMXAreXRpeFQ0SExGb0lpRG5GcW81QmdPNzB5d2IyVDErMnQ2MGo3?=
 =?utf-8?B?a1J1dkxPSk5tR2pQcXVWemlxbS9jMXoyN1BHM2xObkl3UTFXSTdxWk44U3Bm?=
 =?utf-8?B?RG9DSXNVTlg1Um8wVXRFbXdCRmV0alpnR2paREdGMjFBM3hnR29KOWJUZ0I0?=
 =?utf-8?B?RVEyMG85VlQ0bVVMWktRQktWUXVvdU9QWm1rZE9YOWZGWGoyTnhWQUV6RG15?=
 =?utf-8?B?a0MxMWREWmdUWE5PRmsxeUxVYldsb21WbExPTkcvcGlHME53eHRIMUM5a3p6?=
 =?utf-8?B?Vnh0czBVOVBTUWFpWXpJdERtMEJZMGh1dWtRRkdNb0p2ZHVKZ3RNRTZ0Z2p1?=
 =?utf-8?B?M2dqSG9UUGsyQUNTRHA4Z0VzUjdjVjRIdW9PTjNUNkdYdjZCKzhMYVVqQXp2?=
 =?utf-8?B?MHpoOGpwazdmOGp3KzZJcWRYTm5vU2d5R3pLdTdZOVFkbXBpL3FXTUlLanFF?=
 =?utf-8?B?WXdvSStFczZUVEJhaFF2MnZIa1hMU1NFazBEaTJhZGxaYklIeU9xYUc1Z2hY?=
 =?utf-8?B?UG5wOXFSVVBkek1FL0UzbDZNdlpDS0hQVGxnN3FOWmc1TWUvS1U3YmtjQ3R5?=
 =?utf-8?B?R3c9PQ==?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	fxnh3OqW+qYXAdhAT6YHmf7aGLz+yihUb8psKw5t/HEl3RTEGLt/R6X7Lc5s79fY5dKu4qzKAnWMYPs3EPE6vXh1W7NiLzvT2EeU/bhIVwIDK8qQGtKtoqZMSBE1tEi4uOVods9P/DbTk0e1g+MdNohiFQAX887ZtalR6M/t+LCOTLlSMw2O3VRPLsob2PLtjabQTBzZMOudKs9YIwxdra9olrO2Gw84IILyBCYzn8yEDR7QziCTJ4l+LkF0b1LYCkOYMq5FMwyYC37oHYGYLHlqiSNJxz3/wdElRvnU5pYdfr9bgNNbrua3Pihy8LkmTGjVC1KedWO9gjyarPiHseGEwfdS+xe2HiSe6Sqql2oTDF9Y6TXxiBy60coSz1biklDhENxTX5erJxWLFvdC1YZWJItci1xvAnLf6HX6wCZZThHOHm4OiH39eoLqF+CkghC1qo5cnR8x4hb9bD7jn7AYoJGCFBAgWIVU5pv3XXjZznYPdWNGZJn544P5uxun5mVUcREm3Gcm3gZgAVaClTf4yR+U0wjjqPyNwixoZ21hkNvipU5OUPCJxGQ71swPk7RUN0p9ZYTA+HrYM8dkfTLLmArMzXGSbjXn7UBPseM=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a0a25558-d042-4e62-ce55-08dc210fb343
X-MS-Exchange-CrossTenant-AuthSource: MW5PR10MB5738.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Jan 2024 21:17:29.7068
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 2+d2BWgBFtx8wTN3Kc5JZ6b5S0YKfUPMxbiCzkb2jSRDi7Ak/EqeBKYKMN+QhF2s11AfgTRym9FKh3pi2Z4DvNmYRbmZ3217J0/6JxCvb6I=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLAPR10MB4963
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2024-01-29_14,2024-01-29_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 bulkscore=0 spamscore=0
 phishscore=0 adultscore=0 mlxlogscore=817 suspectscore=0 mlxscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000
 definitions=main-2401290157
X-Proofpoint-ORIG-GUID: p2FyNYHdqED_ooO59S8o2d3i4oEG-vZ9
X-Proofpoint-GUID: p2FyNYHdqED_ooO59S8o2d3i4oEG-vZ9

On 1/29/24 12:29PM, Matthew Wilcox wrote:
> On Mon, Jan 29, 2024 at 09:00:56AM -0600, Dave Kleikamp wrote:
>> On 1/29/24 8:55AM, Matthew Wilcox wrote:
>>> On Mon, Jan 29, 2024 at 08:39:18AM -0600, Dave Kleikamp wrote:
>>>> On 1/28/24 2:49PM, Matthew Wilcox wrote:
>>>>> On Wed, Oct 11, 2023 at 08:09:37PM +0530, Manas Ghandat wrote:
>>>>>> Currently while joining the leaf in a buddy system there is shift out
>>>>>> of bound error in calculation of BUDSIZE. Added the required check
>>>>>> to the BUDSIZE and fixed the documentation as well.
>>>>>
>>>>> This patch causes xfstests to fail frequently.  The one this trace is
>>>>> from was generic/074.
>>>>
>>>> Thanks for catching this. The sanity test is not right, so we need to revert
>>>> that one.
>>>
>>> Unfortunately, my overnight test run with this patch reverted crashed
>>> again with the same signature.  I also reverted the parent commit,
>>> and when that crashed I also reverted the parent of that.  Which also
>>> crashed.
>>>
>>> So maybe there's something else that makes this unstable.  Or maybe my
>>> bisect went wrong.  Or _something_.  Anyway, I'm going to spend much of
>>> today hammering on generic/074 with various kernel versions and see what
>>> I can deduce.
>>>
>>> So far I see no evidence that v6.7 crashes with g/074.  And I know that
>>> next-20240125 does crash with g/074.  I'm pretty sure that v6.8-rc1 also
>>> crashes with g/074, but will confirm that.
>>
>> I'll try to beat on it too and see what I find.
>>
>> Sasha, maybe hold up on to all the jfs patches for the time being.
> 
> I have it reproducing easily on cca974daeb6c.  I ran it a lot on
> e0e1958f4c36 and have not reproduced it.  So I'm going back to my
> earlier assertion that cca974daeb6c is bad.  Now, maybe other commits
> are also bad?

I was able to reproduce it too, but not after reverting that one. I 
believe it is the only one causing problems.

I only asked Sasha to hold the other ones as a precaution until we were 
more confident that this one was the problem.

Shaggy