Received-SPF: pass (google.com: domain of linux-kernel+bounces-43580-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Precedence: bulk
MIME-Version: 1.0
References: <202401291043.e62e89dc-oliver.sang@intel.com> <CAHk-=wh0M=e8R=ZXxa4vesLTtvGmYWJ-w1VmXxW5Mva=Nimk4Q@mail.gmail.com>
 <20240129120125.605e97af@gandalf.local.home> <CAHk-=wghx8Abyx_jcSrCDuNj96SuWS0NvNMhfU8VjFGg9bgm_g@mail.gmail.com>
 <CAHk-=whb91PWEaEJpRGsuWaQpYZGj98ji8HC2vvHD4xb_TqhJw@mail.gmail.com>
 <CAHk-=wgp7UkG31=cCcbSdhMv6-vBJ=orktUOUdiLzw4tQ4gDLg@mail.gmail.com>
 <20240129152600.7587d1aa@gandalf.local.home> <CAHk-=wghobf5qCqNUsafkQzNAZBJiS0=7CRjNXNChpoAvTbvUw@mail.gmail.com>
 <20240129172200.1725f01b@gandalf.local.home> <CAHk-=wjV6+U1FQ8wzQ5ASmqGgby+GZ6wpdh0NrJgA43mc+TEwA@mail.gmail.com>
In-Reply-To: <CAHk-=wjV6+U1FQ8wzQ5ASmqGgby+GZ6wpdh0NrJgA43mc+TEwA@mail.gmail.com>
From: Linus Torvalds <torvalds@linux-foundation.org>
Date: Mon, 29 Jan 2024 14:42:47 -0800
Message-ID: <CAHk-=wgOxTeTi02C=kOXsHzuD6XCrV0L1zk1XP9t+a4Wx--xvA@mail.gmail.com>
Subject: Re: [linus:master] [eventfs] 852e46e239: BUG:unable_to_handle_page_fault_for_address
To: Steven Rostedt <rostedt@goodmis.org>
Cc: kernel test robot <oliver.sang@intel.com>, oe-lkp@lists.linux.dev, lkp@intel.com, 
	linux-kernel@vger.kernel.org, Masami Hiramatsu <mhiramat@kernel.org>, 
	Mark Rutland <mark.rutland@arm.com>, Mathieu Desnoyers <mathieu.desnoyers@efficios.com>, 
	Christian Brauner <brauner@kernel.org>, Al Viro <viro@zeniv.linux.org.uk>, 
	Ajay Kaher <ajay.kaher@broadcom.com>, linux-trace-kernel@vger.kernel.org
Content-Type: multipart/mixed; boundary="000000000000683a4e06101d5e02"

--000000000000683a4e06101d5e02
Content-Type: text/plain; charset="UTF-8"

On Mon, 29 Jan 2024 at 14:35, Linus Torvalds
<torvalds@linux-foundation.org> wrote:
>
> So just replace all the d_instantiate() calls there with "d_add()"
> instead. I think that will fix it.

I can confirm that with the mutex deadlock removed and the d_add()
fix, at least things *look* superficially ok.

I didn't actually do anything with it. So it might be leaking dentry
refs like mad or something like that, but at least the obvious cases
look fine.

just for completeness, here's the fixup diff I used.

                  Linus

--000000000000683a4e06101d5e02
Content-Type: text/x-patch; charset="US-ASCII"; name="fixup.diff"
Content-Disposition: attachment; filename="fixup.diff"
Content-Transfer-Encoding: base64
Content-ID: <f_lrzim0me0>
X-Attachment-Id: f_lrzim0me0

IGZzL3RyYWNlZnMvZXZlbnRfaW5vZGUuYyB8IDggKysrLS0tLS0KIDEgZmlsZSBjaGFuZ2VkLCAz
IGluc2VydGlvbnMoKyksIDUgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvZnMvdHJhY2Vmcy9l
dmVudF9pbm9kZS5jIGIvZnMvdHJhY2Vmcy9ldmVudF9pbm9kZS5jCmluZGV4IGNkNmRlMzI0NDQ0
Mi4uNWIzMDdiYjY0ZjhmIDEwMDY0NAotLS0gYS9mcy90cmFjZWZzL2V2ZW50X2lub2RlLmMKKysr
IGIvZnMvdHJhY2Vmcy9ldmVudF9pbm9kZS5jCkBAIC0yMzAsNyArMjMwLDYgQEAgc3RhdGljIHN0
cnVjdCBldmVudGZzX2lub2RlICpldmVudGZzX2ZpbmRfZXZlbnRzKHN0cnVjdCBkZW50cnkgKmRl
bnRyeSkKIHsKIAlzdHJ1Y3QgZXZlbnRmc19pbm9kZSAqZWk7CiAKLQltdXRleF9sb2NrKCZldmVu
dGZzX211dGV4KTsKIAlkbyB7CiAJCS8vIFRoZSBwYXJlbnQgaXMgc3RhYmxlIGJlY2F1c2Ugd2Ug
ZG8gbm90IGRvIHJlbmFtZXMKIAkJZGVudHJ5ID0gZGVudHJ5LT5kX3BhcmVudDsKQEAgLTI0Nyw3
ICsyNDYsNiBAQCBzdGF0aWMgc3RydWN0IGV2ZW50ZnNfaW5vZGUgKmV2ZW50ZnNfZmluZF9ldmVu
dHMoc3RydWN0IGRlbnRyeSAqZGVudHJ5KQogCQl9CiAJCS8vIFdhbGsgdXB3YXJkcyB1bnRpbCB5
b3UgZmluZCB0aGUgZXZlbnRzIGlub2RlCiAJfSB3aGlsZSAoIWVpLT5pc19ldmVudHMpOwotCW11
dGV4X3VubG9jaygmZXZlbnRmc19tdXRleCk7CiAKIAl1cGRhdGVfdG9wX2V2ZW50c19hdHRyKGVp
LCBkZW50cnktPmRfc2IpOwogCkBAIC0zMjQsNyArMzIyLDcgQEAgc3RhdGljIHN0cnVjdCBkZW50
cnkgKmxvb2t1cF9maWxlKHN0cnVjdCBkZW50cnkgKmRlbnRyeSwKIAl0aS0+ZmxhZ3MgPSBUUkFD
RUZTX0VWRU5UX0lOT0RFOwogCXRpLT5wcml2YXRlID0gTlVMTDsJCQkvLyBEaXJlY3RvcmllcyBo
YXZlICdlaScsIGZpbGVzIG5vdAogCi0JZF9pbnN0YW50aWF0ZShkZW50cnksIGlub2RlKTsKKwlk
X2FkZChkZW50cnksIGlub2RlKTsKIAlmc25vdGlmeV9jcmVhdGUoZGVudHJ5LT5kX3BhcmVudC0+
ZF9pbm9kZSwgZGVudHJ5KTsKIAlyZXR1cm4gZXZlbnRmc19lbmRfY3JlYXRpbmcoZGVudHJ5KTsK
IH07CkBAIC0zNjUsNyArMzYzLDcgQEAgc3RhdGljIHN0cnVjdCBkZW50cnkgKmxvb2t1cF9kaXJf
ZW50cnkoc3RydWN0IGRlbnRyeSAqZGVudHJ5LAogICAgICAgICBlaS0+ZGVudHJ5ID0gZGVudHJ5
OwkvLyBSZW1vdmUgbWUhCiAKIAlpbmNfbmxpbmsoaW5vZGUpOwotCWRfaW5zdGFudGlhdGUoZGVu
dHJ5LCBpbm9kZSk7CisJZF9hZGQoZGVudHJ5LCBpbm9kZSk7CiAJaW5jX25saW5rKGRlbnRyeS0+
ZF9wYXJlbnQtPmRfaW5vZGUpOwogCWZzbm90aWZ5X21rZGlyKGRlbnRyeS0+ZF9wYXJlbnQtPmRf
aW5vZGUsIGRlbnRyeSk7CiAJcmV0dXJuIGV2ZW50ZnNfZW5kX2NyZWF0aW5nKGRlbnRyeSk7CkBA
IC03ODYsNyArNzg0LDcgQEAgc3RydWN0IGV2ZW50ZnNfaW5vZGUgKmV2ZW50ZnNfY3JlYXRlX2V2
ZW50c19kaXIoY29uc3QgY2hhciAqbmFtZSwgc3RydWN0IGRlbnRyeQogCiAJLyogZGlyZWN0b3J5
IGlub2RlcyBzdGFydCBvZmYgd2l0aCBpX25saW5rID09IDIgKGZvciAiLiIgZW50cnkpICovCiAJ
aW5jX25saW5rKGlub2RlKTsKLQlkX2luc3RhbnRpYXRlKGRlbnRyeSwgaW5vZGUpOworCWRfYWRk
KGRlbnRyeSwgaW5vZGUpOwogCWluY19ubGluayhkZW50cnktPmRfcGFyZW50LT5kX2lub2RlKTsK
IAlmc25vdGlmeV9ta2RpcihkZW50cnktPmRfcGFyZW50LT5kX2lub2RlLCBkZW50cnkpOwogCXRy
YWNlZnNfZW5kX2NyZWF0aW5nKGRlbnRyeSk7Cg==
--000000000000683a4e06101d5e02--