Received-SPF: pass (google.com: domain of linux-kernel+bounces-43629-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Precedence: bulk
MIME-Version: 1.0
References: <20240129202901.work.282-kees@kernel.org> <20240129215525.4uxchtrywzzsrauc@google.com>
 <202401291357.DAA9670F3@keescook>
In-Reply-To: <202401291357.DAA9670F3@keescook>
From: Andy Shevchenko <andy.shevchenko@gmail.com>
Date: Tue, 30 Jan 2024 01:27:14 +0200
Message-ID: <CAHp75VfgmLoACfjphHi30hSkL0Sa1AueFeG=qGQvwnewqyjrRg@mail.gmail.com>
Subject: Re: [RFC] string: Allow 2-argument strscpy()
To: Kees Cook <keescook@chromium.org>
Cc: Justin Stitt <justinstitt@google.com>, Andy Shevchenko <andy@kernel.org>, 
	Rasmus Villemoes <linux@rasmusvillemoes.dk>, linux-hardening@vger.kernel.org, 
	linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Tue, Jan 30, 2024 at 12:03=E2=80=AFAM Kees Cook <keescook@chromium.org> =
wrote:
> On Mon, Jan 29, 2024 at 09:55:25PM +0000, Justin Stitt wrote:
> > On Mon, Jan 29, 2024 at 12:29:04PM -0800, Kees Cook wrote:

..

> > BTW, this hack for function overloading is insane. Never really looked =
into
> > it before.
>
> It very much is. :P Hence the RFC nature of this patch. I don't think we
> any any other API in the kernel that does this (though there are plenty
> of wild macro wrappers to do similar tricks, like the syscall wrappers).

PCI has a couple of such.

> > I like this, though, should you include documentation changes/additions=
?
>
> Yeah, though I'm not sure how to do this -- kerndoc expects a fixed
> number of arguments. :P Maybe I can just do something like add
> "optional" to @size:

Use ... See again PCI header (pci.h). One of the macros there has a
valid kernel-doc.

>  * strscpy - Copy a C-string into a sized buffer
>  * @p: Where to copy the string to
>  * @q: Where to copy the string from
>  * @size: Size of destination buffer (optional)


--=20
With Best Regards,
Andy Shevchenko