Received-SPF: pass (google.com: domain of linux-kernel+bounces-43641-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <874jevk8j8.wl-kuninori.morimoto.gx@renesas.com>
From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
To: Chancel Liu <chancel.liu@nxp.com>
Cc: lgirdwood@gmail.com,
	broonie@kernel.org,
	perex@perex.cz,
	tiwai@suse.com,
	linux-sound@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ASoC: soc-core.c: Prefer to return dai->driver->name in snd_soc_dai_name_get()
In-Reply-To: <20240129071839.2393483-1-chancel.liu@nxp.com>
References: <20240129071839.2393483-1-chancel.liu@nxp.com>
User-Agent: Wanderlust/2.15.9 Emacs/27.1 Mule/6.0
Content-Type: text/plain; charset=US-ASCII
Date: Mon, 29 Jan 2024 23:46:20 +0000
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?Dy5UtKweR6oWv8u9iU388VXe5BZJcUlWKjAqp99u+okgqsEkbi2dGfnI2hY2?=
 =?us-ascii?Q?azZzBlVc5mglWMBi2AHk5x0YTAaojVfbJPH1JZjIjePUjJGjQ9usFZV9XbKN?=
 =?us-ascii?Q?OccOsbo8k25S5zOU8g+1CikhwTv03uh9HATeYEAWfTQPjayK46TZJeB/Pkr1?=
 =?us-ascii?Q?r6S58MQd+Fg3MTT8nXGQR7bTSVaD2Gqwc5rZCv044zwYuUlPe6nD6zSYYwiZ?=
 =?us-ascii?Q?xunx0QUUc/7BnbqoH2hknyCBJ4HpOkgrNYZxq/0PZDlnt9/WACth+Ja9qinW?=
 =?us-ascii?Q?hHMlQErhwsvuq/+DrzKgx6xg+g5Yv05NODw39E1cKuFELaPaa3goiGgaJvx9?=
 =?us-ascii?Q?4jADlfDWOaXl+rRjmxv9gAzGveCPS8SVCsb2jRBRNheX9HeFS7yB9geYu96h?=
 =?us-ascii?Q?f+3HB9LXgyFga+wgllsH2T8cQY38quxbj72zIlP6RJoMrPZgwVqNVCEMpc3H?=
 =?us-ascii?Q?0rfMfhB3mMnb+jTXri/4AngtzJmW7Blb55gmaviU4WGeZcZuosqI/8PezjCH?=
 =?us-ascii?Q?Q9Qlife7orN1r4xJT3oJdz+SHlpZdQr6mmL4r1bIRQQkldODQe4Cb694DA6b?=
 =?us-ascii?Q?qeQeHSMkPITnO2tGQLFJTXbQqPHzj7zem5KuR2IepJvj5TJ3Dv2X9htFGrz9?=
 =?us-ascii?Q?7d1+p9ySCk0nYq/pOESvBL7BTYVJxVCDC8nNjAF8yqgqa5yE6E9hXTG3vxXx?=
 =?us-ascii?Q?L2BpXzW+rYRo49JecgxdoYewRd5C1FrVeIBoIGwstcQstvBHoojhzPPgSRVD?=
 =?us-ascii?Q?2JJrN7RuVK0kx5ehyW00xSi8Gb/+B8eC2H1Zg+5rk4wh2dsvlx5zyLg6D0la?=
 =?us-ascii?Q?akgmN1w8qr90OpJ2a4dxHw7J2nAz+j0frCOVsLJQKdFkKCUS04q1xo10vKKI?=
 =?us-ascii?Q?fVsStPveBGolLw/HHgJePwww94l/MZ4L0feVOPFCdKIibm+ogay4WJZhTEX3?=
 =?us-ascii?Q?C9vk4Gm6uxoFd4ChQEzEZH50maV4AD5WAyNB8XcurL4OtbWxMK4sg6Q5GNvZ?=
 =?us-ascii?Q?r1l5geYFK0Z+g0gTY0gfDpn5v8+RJ/TgaxoHoUGs/mdOBKoF3qm3h/8XIOzF?=
 =?us-ascii?Q?m54dIaoDqfJ8ssVrdmJF8Ko4vvE7Et+JmKvetH5jJbZZD/68D2bOf7P2awMf?=
 =?us-ascii?Q?BVeFNuDBxAlVMCgHGGffJPUqtSavaNkkYXFRnr01dDdnalwhbbwSadW/6V/h?=
 =?us-ascii?Q?aONmCkwIPKWc8pfL5dy/CO6GknNvxfuiGx8tUSYM82lEoq5r7g76T7eqW3bJ?=
 =?us-ascii?Q?zaAaGbPNbJWrYNxAjamWu3/ex39I6t1XlSOhoBiRThv9RusLqcqCw56RQSfP?=
 =?us-ascii?Q?6gRAtw35d2xqi9aeJd40neICGcnkX9VbeF5UfX7fVRw+YdxLHDuW+dO4+/WI?=
 =?us-ascii?Q?DF+RnDJq4NdU9XyKWP8YTmtqHmZoKIhWtfbLr+Ir6uQRoQ5lWZyEgGYMiaBy?=
 =?us-ascii?Q?usS5OKj98EzhYYQaQToePmmC0tXIWjhM97ioVUXSCixirYEVyIWtMWCC4ecV?=
 =?us-ascii?Q?sQyT3wKhwSk1x6BeqrqcvXQpaoTH6DBAobCB8Pq5H0IBmt3gYpxfxLntMI66?=
 =?us-ascii?Q?DgBk4qsvumkuR3Afkne+ffIT/bNhmjILv5uSnvDhRZYCUGQ1nRIe7dRQNcof?=
 =?us-ascii?Q?6e2fnL9xQCCmHFIhzGTFLik=3D?=
X-OriginatorOrg: renesas.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ad9498de-b0ca-4009-454e-08dc21247e5a
X-MS-Exchange-CrossTenant-AuthSource: TYCPR01MB10914.jpnprd01.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Jan 2024 23:46:20.3067
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 53d82571-da19-47e4-9cb4-625a166a4a2a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: pTuYitezPUk+9cnLJ5l0SJFp39j95wXu1fXMz2SwSrO3mCBVisX3CdggvjxKZ+yNKQpYVJBfW1lDixEn53Iyp4iXAl7KMMumyx4F6Fr8mYTzJAEEGQb/YXH7TKxLtXpD
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TY3PR01MB11472


Hi Chancel

Thank you for the patch

> diff --git a/sound/soc/soc-core.c b/sound/soc/soc-core.c
> index 516350533e73..09467c693627 100644
> --- a/sound/soc/soc-core.c
> +++ b/sound/soc/soc-core.c
> @@ -300,12 +300,12 @@ static int snd_soc_is_matching_dai(const struct snd_soc_dai_link_component *dlc,
>  const char *snd_soc_dai_name_get(struct snd_soc_dai *dai)
>  {
>  	/* see snd_soc_is_matching_dai() */
> -	if (dai->name)
> -		return dai->name;
> -
>  	if (dai->driver->name)
>  		return dai->driver->name;
>  
> +	if (dai->name)
> +		return dai->name;
> +
>  	if (dai->component->name)
>  		return dai->component->name;
>  
> -- 

As above comment indicated, snd_soc_dai_name_get() and
snd_soc_is_matching_dai() are paired.
If you want to update snd_soc_dai_name_get(), updating
snd_soc_is_matching_dai() also is good idea.


Thank you for your help !!

Best regards
---
Renesas Electronics
Ph.D. Kuninori Morimoto