Received: by 2002:a05:7412:d1aa:b0:fc:a2b0:25d7 with SMTP id ba42csp737047rdb; Mon, 29 Jan 2024 17:36:31 -0800 (PST) X-Google-Smtp-Source: AGHT+IEhUWdl/sSiy4EuaC3h7M0BKyophwTxYVRAlos7PBaWVBFqpcUiIdo3nO8NHxhUTGgpAwC3 X-Received: by 2002:a05:6122:16a1:b0:4b7:a77c:d133 with SMTP id 33-20020a05612216a100b004b7a77cd133mr3313658vkl.11.1706578591214; Mon, 29 Jan 2024 17:36:31 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1706578591; cv=pass; d=google.com; s=arc-20160816; b=iQ/5l6tv1ArDv4fERpiqFFDywVtXKEiCh7l0vsGVJqLNGHwJt2WDhwYGCXiEVGwHA/ GMTIqBFmv9RZKW3kgF43FjDS+6yI2sOgPXxPCc4dkK0XfOeu0u8aUzbV6S7aMCDpprCP tEncW+YLpx104fEMbZ4vnFd0wHLB07oUt58/VTXKKS7StvapbE5ZeI9iVpJY8nXAmjQf MBtjn0F4dKsNNPn5or546StjkhZ/uJpab0AkjzvxbP3My3ppCglWBoMlKncXVDAoToc4 GQgQ+daFRZBSyfj8c4XmGYyfGniF3GVCrN8y3kwbD5KC81+aDKvsVnO473pyBWQhd1pV YVCQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=5mrOv/KaRHlajCAYRKUp9Gv9XtpHmCRS/i1xDUtovrg=; fh=BzdeVYqZhG5iuwuKJRNLP969rvCput73lx0iwx2zu7A=; b=VlH+QHefpi7iiLaRGAb6xpL+SRqIHDBZSu1TgLbmcGlyg6ngKqNhWP/tbUTOkXNQ1/ LrciysUNtI2175qmqZjHty1hoMu1tAEdNcW+qGja0eN1F6wDbcwmrUoqnkpse6ujEoD6 lGVXbcnsoliFzEsDhZDYkxt7dZQIxvYrPWICBtYl0VJ7zv1BzqSDEudH/sBf4yLdbiSU ChUEDB03okqztaSsm5gWt8hPNwOjxqAp1L4xEmgTusCji0Bh9Z5EsUN+pjktdtGJ4/3u sQYI9aJPB9wxoSDq2hBu9jHE6OkS6lsPiIe9ldS28zLZLWP/0DNTkYO+NfVMofVLYVJt RouQ== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ar1EzV9w; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-43723-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-43723-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id w21-20020ac857d5000000b0042a9bd3f95asi4776475qta.210.2024.01.29.17.36.31 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Jan 2024 17:36:31 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-43723-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ar1EzV9w; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-43723-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-43723-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id F1F311C21A2C for ; Tue, 30 Jan 2024 01:36:30 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 23A0E36AF5; Tue, 30 Jan 2024 01:36:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="ar1EzV9w" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 49835364AB; Tue, 30 Jan 2024 01:35:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706578559; cv=none; b=ElfeLCKVnrr+ajWowBzW6n0HbJqk8GpUFjG924o1VsYn8i0gSSHsaLfcSYbA/cNhrJlfIRzbDezAWRy8HGwpOQaLxiuKia3X3tJrZphARWBOkynp4fb70wUfAZR0Exn7i4GWy72sKm/8s2Ecz2QL7kEGf1sZIT+gGyCoCYI2do0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706578559; c=relaxed/simple; bh=ZtqTd8FEkkcClpmqlfGDvu7x6/2aDbjjseJMMQvFCaw=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=VIwTugF/iO9yuYoLuCP1dDmWLFrstz5reyDidizMSzpGvhy7e7WthLxmd4GEgXZJr4bEXFZB4jrVi2aToMPBQCh4sCykxiDD8WVAONWzCKGGfgPrJ8mpljqQ2SgkAg8jzETZ3ZMZcridXumKPdNL3X9PTXmukNHJWV1lZ5j5Qxo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=ar1EzV9w; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6E7BFC43399; Tue, 30 Jan 2024 01:35:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1706578558; bh=ZtqTd8FEkkcClpmqlfGDvu7x6/2aDbjjseJMMQvFCaw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ar1EzV9wNYgpLqVA34gUAYP+W08RR2XTVvtZgE00US0nj7kI9ZKC/9C//HPb7yjPx 1P28YQXu6KYnZhxlnPAyRzaD3EoOMiaVBemIcYC0xbUylzOSVORSSk6jrcjA1FOhz/ cG/tuWrU4q4wEt4TNO4bk6MHsQfTZPYx4olpMaknqtNkDxF1YAv8djDsfC/HMrnrXi TD5uvIub3mm3mocZ4dVFSt2/xzN6eCDURNSZ5UJDVTu0ij5WT0G5X/M1nyFryHy/Cx R9c83IgtwWEXPgx8V5U7cFDaq/ZC4y7Ubvj4D3sG0UMkDRG1ezz8rcDh6O1XpvtMVr VUSdhLduqygrw== From: SeongJae Park To: Andrew Morton Cc: SeongJae Park , damon@lists.linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: [PATCH 3/9] mm/damon/dbgfs: implement deprecation notice file Date: Mon, 29 Jan 2024 17:35:42 -0800 Message-Id: <20240130013549.89538-4-sj@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240130013549.89538-1-sj@kernel.org> References: <20240130013549.89538-1-sj@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Implement a read-only file for DAMON debugfs interface deprecation notice, to let users who manually read/write the DAMON debugfs files from their shell command line easily notice the fact. Signed-off-by: SeongJae Park --- mm/damon/dbgfs.c | 20 ++++++++++++++++++-- 1 file changed, 18 insertions(+), 2 deletions(-) diff --git a/mm/damon/dbgfs.c b/mm/damon/dbgfs.c index 7dac24e69e3b..fc6ece5a9f37 100644 --- a/mm/damon/dbgfs.c +++ b/mm/damon/dbgfs.c @@ -805,6 +805,18 @@ static void dbgfs_destroy_ctx(struct damon_ctx *ctx) damon_destroy_ctx(ctx); } +static ssize_t damon_dbgfs_deprecated_read(struct file *file, + char __user *buf, size_t count, loff_t *ppos) +{ + char kbuf[512] = "DAMON debugfs interface is deprecated, " + "so users should move to DAMON_SYSFS. If you cannot, " + "please report your usecase to damon@lists.linux.dev and " + "linux-mm@kvack.org.\n"; + int len = strnlen(kbuf, 1024); + + return simple_read_from_buffer(buf, count, ppos, kbuf, len); +} + /* * Make a context of @name and create a debugfs directory for it. * @@ -1056,6 +1068,10 @@ static int damon_dbgfs_static_file_open(struct inode *inode, struct file *file) return nonseekable_open(inode, file); } +static const struct file_operations deprecated_fops = { + .read = damon_dbgfs_deprecated_read, +}; + static const struct file_operations mk_contexts_fops = { .open = damon_dbgfs_static_file_open, .write = dbgfs_mk_context_write, @@ -1076,9 +1092,9 @@ static int __init __damon_dbgfs_init(void) { struct dentry *dbgfs_root; const char * const file_names[] = {"mk_contexts", "rm_contexts", - "monitor_on"}; + "monitor_on", "DEPRECATED"}; const struct file_operations *fops[] = {&mk_contexts_fops, - &rm_contexts_fops, &monitor_on_fops}; + &rm_contexts_fops, &monitor_on_fops, &deprecated_fops}; int i; dbgfs_root = debugfs_create_dir("damon", NULL); -- 2.39.2