Received: by 2002:a05:7412:d1aa:b0:fc:a2b0:25d7 with SMTP id ba42csp761144rdb; Mon, 29 Jan 2024 18:45:24 -0800 (PST) X-Google-Smtp-Source: AGHT+IEx6co1rjOYJPy/MpOnRAkL8otY2bh5Xs11Z9L4x0kXNZngebxk/CFtj/TDtcIkpo8154q+ X-Received: by 2002:a17:903:230c:b0:1d6:f1c5:bc6a with SMTP id d12-20020a170903230c00b001d6f1c5bc6amr4579969plh.46.1706582724351; Mon, 29 Jan 2024 18:45:24 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1706582724; cv=pass; d=google.com; s=arc-20160816; b=HgZGv/XWma4IG19ydUpvB2TvACPm7tlC1AoIIpDvF6Ak2YOsca3L7OS10dth0UMLU9 YNswTLKYJzspl7asc4wIQHDUuB8KbRKyit/5HTMagmvdNwe9pPhUijtR+OZQ+xs6gNpC LvQXIxbD0ik4QtYCvcuIKzhmD4mcxlqhtilh8sMyF38jO3qcfqTA3R8Jq7zeFIphFD+q n++4BDq6UCpXHvM8pQo+lsHv8NmSVsUTVYiLtwkbFYTouDdXl2iUqWxisBEdmXfaJ5j3 ViP0RB2GB8MxCc8mDuIbo8Kpu7nacUEmVDqTMhsGv/pANgANKDZIXyFJBJsxOSwbDjMY bOQQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=M6ttjQYwKrto5D2RHLbTN3mnyU+mC7uKIL6Z00W0Jkg=; fh=O7AxFKRbXIOyCr5sJyzmLOaOF8ZeJNuxrjba3SqCrx8=; b=nIz7ZgAsEXLzD3TLMM/ZjWeBR+7Jx+d6mjIVNNaDfnUM6LjaXxw43QoOGmZ6YeoodX BQjJbPp/T4JuFGxQ2UnIGSf+FwuLgdUCJJJe4jUgiU9Sc/hr44uCwIVv8MVFGH74mcBG yvqDJJwrJljazT2pDLu9lsOfwc50N/GCyEdKBuA1iMDQz9xE6C60s9ykJN2KBklx5bQc Q1hwW/chQ3bPKFXwtho/RDMPgmkE7dDUq9+I4bQivaAhu34S9O+vBRyWO2aJ8gGyaOgH 7TPA5lm97EHK2SB+zjY/ghB3Sv46RqU7vffIvz24c+X6nilXcK3tlo2bSLFA516/mju5 R/Qw== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2023-11-20 header.b=WB1Y19pC; arc=pass (i=1 spf=pass spfdomain=oracle.com dkim=pass dkdomain=oracle.com dmarc=pass fromdomain=oracle.com); spf=pass (google.com: domain of linux-kernel+bounces-43824-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-43824-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [2604:1380:40f1:3f00::1]) by mx.google.com with ESMTPS id t2-20020a1709028c8200b001d485a81276si6417797plo.262.2024.01.29.18.45.23 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Jan 2024 18:45:24 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-43824-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2023-11-20 header.b=WB1Y19pC; arc=pass (i=1 spf=pass spfdomain=oracle.com dkim=pass dkdomain=oracle.com dmarc=pass fromdomain=oracle.com); spf=pass (google.com: domain of linux-kernel+bounces-43824-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-43824-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 8FF11B27190 for ; Tue, 30 Jan 2024 02:29:06 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id A1EB0381A0; Tue, 30 Jan 2024 02:27:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="WB1Y19pC" Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 646EB364D2; Tue, 30 Jan 2024 02:27:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.165.32 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706581654; cv=none; b=jFNVZeZps+35nsxr4RJYfUb7kbYSaNrW0umDrZYFmtS1nZWhS5jbjKTfYOwfBUodQwaA6DneCFFdm7aLoOc2Va8ChVepQ9+GHpJ/kiMdeyXyWIEWweiHr55nmGrxeDGPkfPUynirruHNaGkiypManfSPUoyq+2smYwN4QlFz8ZU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706581654; c=relaxed/simple; bh=W1lbuevOg4lz80k4e+i9bIkNJZ2002FG6iFJ013m188=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=H4PoZE6dLUSPtPKkvAEuZuLwYwciUYgcHaqyZ1v3nrsn4LyrLLtc1whtg3EKtBb0Ybrif8Iv3vJxxUep9WB0pA98xrlVecD90MrLTFHIXeEe+4DGKjIIngsjw2a4vf9q54rWhKTL2LJa74JtC685DMjXaVNRusdLdxDqgKt339E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oracle.com; spf=pass smtp.mailfrom=oracle.com; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b=WB1Y19pC; arc=none smtp.client-ip=205.220.165.32 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oracle.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oracle.com Received: from pps.filterd (m0246617.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 40TJiSsY007793; Tue, 30 Jan 2024 02:27:29 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-type : content-transfer-encoding; s=corp-2023-11-20; bh=M6ttjQYwKrto5D2RHLbTN3mnyU+mC7uKIL6Z00W0Jkg=; b=WB1Y19pCDjUKaGVaSzXEqmRNkO6oEzmKCxqCOYXOg1+bPbc3w5b9aoseJjI6XAzVPFmF SBATm2+5E1jdWdyPHHkaRFiBw6GYb/+T34iBtsuA1XwBgjZL81cC+42RWE3QW0NQVMZ5 fGtO84MkTdFDhaT+AUCGpoEXUkyQslva4q+sDCV/+yvQALgo7MWNN8YDwetiA4UkIweK Pv1NNBAFnv4jmjy2d4Gz9UxncessXW/LbldICopirZQNgNYN7XX9g37CB93qaGlLYcVp fVkVWor0uHSKjt6A6vH51Jd8s/iMcseIm1yGRJyOalnGMdZO0HYI43JloWudc0/TNEiN ZA== Received: from phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta01.appoci.oracle.com [138.1.114.2]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3vvtcuwft1-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 30 Jan 2024 02:27:29 +0000 Received: from pps.filterd (phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 40U1au6Y014634; Tue, 30 Jan 2024 02:27:28 GMT Received: from pps.reinject (localhost [127.0.0.1]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 3vvr96g504-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 30 Jan 2024 02:27:28 +0000 Received: from phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 40U2RPxi040916; Tue, 30 Jan 2024 02:27:27 GMT Received: from ca-mkp2.ca.oracle.com.com (mpeterse-ol9.allregionaliads.osdevelopmeniad.oraclevcn.com [100.100.251.135]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTP id 3vvr96g4y7-3; Tue, 30 Jan 2024 02:27:27 +0000 From: "Martin K. Petersen" To: Kashyap Desai , Sumit Saxena , Shivasharan S , Chandrakanth patil , "James E . J . Bottomley" , megaraidlinux.pdl@broadcom.com, linux-scsi@vger.kernel.org, Colin Ian King Cc: "Martin K . Petersen" , kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH][next] scsi: megaraid: remove redundant assignment to variable retval Date: Mon, 29 Jan 2024 21:26:59 -0500 Message-ID: <170657812674.784857.7579326201557441300.b4-ty@oracle.com> X-Mailer: git-send-email 2.42.1 In-Reply-To: <20240118121441.2533620-1-colin.i.king@gmail.com> References: <20240118121441.2533620-1-colin.i.king@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-01-29_15,2024-01-29_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 bulkscore=0 malwarescore=0 suspectscore=0 phishscore=0 mlxscore=0 mlxlogscore=879 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000 definitions=main-2401300015 X-Proofpoint-ORIG-GUID: W7Nd81WSNvuI_R4H-0335ZCahUDBeS7e X-Proofpoint-GUID: W7Nd81WSNvuI_R4H-0335ZCahUDBeS7e On Thu, 18 Jan 2024 12:14:41 +0000, Colin Ian King wrote: > The variable retval is being assigned a value that is not being > read afterwards. The assignment is redundant and can be removed. > > Cleans up clang scan warning: > Although the value stored to 'retval' is used in the enclosing > expression, the value is never actually read from 'retval' > [deadcode.DeadStores] > > [...] Applied to 6.9/scsi-queue, thanks! [1/1] scsi: megaraid: remove redundant assignment to variable retval https://git.kernel.org/mkp/scsi/c/9759cdc1bcb8 -- Martin K. Petersen Oracle Linux Engineering