Received-SPF: pass (google.com: domain of linux-kernel+bounces-43864-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
From: Leonardo Bras <leobras@redhat.com>
To: Tejun Heo <tj@kernel.org>
Cc: Leonardo Bras <leobras@redhat.com>,
	Lai Jiangshan <jiangshanlai@gmail.com>,
	linux-kernel@vger.kernel.org,
	Junyao Zhao <junzhao@redhat.com>
Subject: Re: [PATCH v2 1/1] wq: Avoid using isolated cpus' timers on queue_delayed_work
Date: Mon, 29 Jan 2024 23:58:07 -0300
Message-ID: <Zbhlv4EDS8qPmg_3@LeoBras>
In-Reply-To: <ZbhPWSWAZZo8gk-a@slm.duckdns.org>
References: <20240130010046.2730139-2-leobras@redhat.com> <ZbhPWSWAZZo8gk-a@slm.duckdns.org>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: 8bit

On Mon, Jan 29, 2024 at 03:22:33PM -1000, Tejun Heo wrote:
> On Mon, Jan 29, 2024 at 10:00:46PM -0300, Leonardo Bras wrote:
> > When __queue_delayed_work() is called, it chooses a cpu for handling the
> > timer interrupt. As of today, it will pick either the cpu passed as
> > parameter or the last cpu used for this.
> > 
> > This is not good if a system does use CPU isolation, because it can take
> > away some valuable cpu time to:
> > 1 - deal with the timer interrupt,
> > 2 - schedule-out the desired task,
> > 3 - queue work on a random workqueue, and
> > 4 - schedule the desired task back to the cpu.
> > 
> > So to fix this, during __queue_delayed_work(), if cpu isolation is in
> > place, pick a random non-isolated cpu to handle the timer interrupt.
> > 
> > As an optimization, if the current cpu is not isolated, use it instead
> > of looking for another candidate.
> > 
> > Signed-off-by: Leonardo Bras <leobras@redhat.com>
> 
> Applied to wq/for-6.9.
> 
> Thanks.
> 
> -- 
> tejun
> 

Thank you!
Leo