Received-SPF: pass (google.com: domain of linux-kernel+bounces-43872-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Mon, 29 Jan 2024 19:11:23 -0800 (PST)
From: David Rientjes <rientjes@google.com>
To: Zheng Yejian <zhengyejian1@huawei.com>
cc: cl@linux.com, penberg@kernel.org, iamjoonsoo.kim@lge.com, 
    akpm@linux-foundation.org, vbabka@suse.cz, roman.gushchin@linux.dev, 
    42.hyeyoo@gmail.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm/slub: remove parameter 'flags' in
 create_kmalloc_caches()
In-Reply-To: <20240130014107.1262373-1-zhengyejian1@huawei.com>
Message-ID: <388197b3-6193-96ce-8e8d-261c8481eff3@google.com>
References: <20240130014107.1262373-1-zhengyejian1@huawei.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Tue, 30 Jan 2024, Zheng Yejian wrote:

> After commit 16a1d968358a ("mm/slab: remove mm/slab.c and slab_def.h"),
> parameter 'flags' is only passed as 0 in create_kmalloc_caches(), and
> then it is only passed to new_kmalloc_cache().
> 
> So we can change parameter 'flags' to be a local variable with
> initial value 0 in new_kmalloc_cache() and remove parameter 'flags'
> in create_kmalloc_caches(). Also make new_kmalloc_cache() static
> due to it is only used in mm/slab_common.c.
> 
> Signed-off-by: Zheng Yejian <zhengyejian1@huawei.com>

Acked-by: David Rientjes <rientjes@google.com>