Received-SPF: pass (google.com: domain of linux-kernel+bounces-43888-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Mon, 29 Jan 2024 22:19:38 -0500
From: Johannes Weiner <hannes@cmpxchg.org>
To: Chengming Zhou <zhouchengming@bytedance.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Nhat Pham <nphamcs@gmail.com>, Yosry Ahmed <yosryahmed@google.com>,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 01/20] mm: zswap: rename zswap_free_entry to
 zswap_entry_free
Message-ID: <20240130031938.GA772725@cmpxchg.org>
References: <20240130014208.565554-1-hannes@cmpxchg.org>
 <20240130014208.565554-2-hannes@cmpxchg.org>
 <eceb2dc5-f13b-4c54-b2dd-0e4a199c1280@bytedance.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <eceb2dc5-f13b-4c54-b2dd-0e4a199c1280@bytedance.com>

On Tue, Jan 30, 2024 at 11:13:16AM +0800, Chengming Zhou wrote:
> On 2024/1/30 09:36, Johannes Weiner wrote:
> > There is a zswap_entry_ namespace with multiple functions already.
> 
> Another is zswap_invalidate_entry(), maybe zswap_entry_invalidate is better.

You're right.

I originally had a patch for that, but then dropped it because it is
sort of also a tree operation and it looked a bit weird to me.

But I could be persuaded to include it again, no strong preferences
either way.

Thanks