Received-SPF: pass (google.com: domain of linux-kernel+bounces-44047-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Tue, 30 Jan 2024 08:31:07 +0100
From: Wolfram Sang <wsa+renesas@sang-engineering.com>
To: claudiu beznea <claudiu.beznea@tuxon.dev>, ulf.hansson@linaro.org,
	takeshi.saito.xv@renesas.com, masaharu.hayakawa.ry@renesas.com,
	yoshihiro.shimoda.uh@renesas.com, linux-mmc@vger.kernel.org,
	linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
	Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>
Subject: Re: [PATCH v2] mmc: renesas_sdhi: Fix change point of data handling
Message-ID: <Zbilu9u9Z3MeeOb9@ninjato>
Mail-Followup-To: Wolfram Sang <wsa+renesas@sang-engineering.com>,
	claudiu beznea <claudiu.beznea@tuxon.dev>, ulf.hansson@linaro.org,
	takeshi.saito.xv@renesas.com, masaharu.hayakawa.ry@renesas.com,
	yoshihiro.shimoda.uh@renesas.com, linux-mmc@vger.kernel.org,
	linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
	Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>
References: <20240117110646.1317843-1-claudiu.beznea.uj@bp.renesas.com>
 <ZbeEPg1jc5qWJa5m@ninjato>
 <345bc392-cf28-479a-9453-5bc89f635759@tuxon.dev>
 <ZbikovLbujyGS1ub@ninjato>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="GQRaf8k/U09nYrq6"
Content-Disposition: inline
In-Reply-To: <ZbikovLbujyGS1ub@ninjato>


--GQRaf8k/U09nYrq6
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline


> But isn't it equal to the current code then? (Except for one thing: the
> smpcmp bit is only set when there is no cmd error. I need to double
> check but I think I like that.)

I double checked, I really like it. I'd just invert the logic. Pseudo
code:

if (!cmd_error)
	if (SMPCMP == 0) set_bit
else
	mmc_abort_tuning()


--GQRaf8k/U09nYrq6
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAmW4pbsACgkQFA3kzBSg
KbZIbQ//Y36zPSqNnCfwh8mVJf6212a3SsOGiuFkR6GYcAlchDw2ofadF0ts7fL8
H7CNwSQ/13NSNE7BD/jRdzszu5Q+FUAha7+R/MJccwR5Z+an0b2AhC98geyGkm3+
LJWPMx+8YflXxxkJgy2DvkIK+dTHc5rX1sT/8hCtFqAsWs98QAPt6l+1tk65bM7e
QY10mKytTr9qetUbw/60NnlIuU43jMizHaa7/dvh0vob67qA5BDF+WDBPpUUOz/p
T96t2EvqB10E7oOX3n75ZUnXY+j4zTnUohdPlXuc34HmoFf/eGeNNYOmdj7gNhIN
EqkfFNTZt9ZtqntVkEuWV8kwDUjhxhWDjSAsUuLEvzP80cHJiys1Orj1StOzT34X
dSosnhGFNSnTogkkKaJ8L3c/xBFSwfS9IxsAa+4BPev9ABcilA/v2ibkfUqyzQcm
TNyYg3N9EuwHjNe2r2bMDmbFVy9KNdqjiw1YPNOC5kF6s33CAJfAWUWcXcsPjYJk
/ui/GRp6kiIJuAz9JQ7g3V3ziQZOaWtJd7dL3yB7RgGNL5lt1y9gHLrZD16m9/67
qnz9qj8Mg3Q/aSP8+vLRVSkcfrC5Y8eWkuPm8e5dlI9TennnMrKw49EwmuQPXUDX
oudYdpBPDLXLigpAMq0ASDLg9oHhpG2KarT+Z4PLO+yDrhT7404=
=CXPW
-----END PGP SIGNATURE-----

--GQRaf8k/U09nYrq6--