Received: by 2002:a05:7412:d1aa:b0:fc:a2b0:25d7 with SMTP id ba42csp862782rdb; Tue, 30 Jan 2024 00:11:49 -0800 (PST) X-Google-Smtp-Source: AGHT+IHLdCDj43Xq+BpJn41Qm40I+s/0Nimt3T9OYWZiQE2hMyKMZLYQ5WHP6+/Qt8eW0lsaqKo5 X-Received: by 2002:a05:620a:12c5:b0:783:f753:813a with SMTP id e5-20020a05620a12c500b00783f753813amr4192409qkl.54.1706602309393; Tue, 30 Jan 2024 00:11:49 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1706602309; cv=pass; d=google.com; s=arc-20160816; b=rnYxtJN8djGk116l++kTW6fK8doByxAaZZBdMG777F5DrBc14F6FUJyzgkMqaMIGPR VF+2ZEuY1qOYfz/IOk0Hz085iHkRRUK5p2HUkBk3KpJVTllOfxytXuRXE9ir0KWGBJga dMyQQOp76DMK70CFRnumxnFi4bhT0c68zlu94nehPeNB7RDk8t1TytmR2EQJrtmp4OMc jn95MfgjN5Hi491F8/yHk49PY4r32KWUm/m+u6ODOtpJxiTA/lNrgat9/x8/+UOitnlU yPneT1V5Xf4AW2dV9no4YRMY4fSAw2aCaHcnav1MulPyQTMSstVrBAs4gq5/WKjaYFlo HhmQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=cc:to:from:subject:message-id:references:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:in-reply-to:date :dkim-signature; bh=MB0zSqc4v6QJWm2r+bwmMTwgDhYEDBQW95gH3tHtSso=; fh=oocptefG+2lvFQHArvmvqHgNVObzaNhqiaCoJ7BqlI8=; b=yjWahpliNtRvvPU7ZeYw6Z6v8zQoxeiYOS75CsTBlsvwwSxBNCirI7tlULN/fkXSoh 59MinqchCL3eGDLet+EONP82nGKA3xBcpp7cpSnWoEZRGolM0o/wS4q7XRQky8vq1yMM yYQV6M1ZiGpyIJe8fr5pmYYaoSR5WaJRqvZVh0CNI2SE3o3/5mi8bam4d4XIY//PEJLW YVgyjIPcGDib+QkVhiYBlrCh2xYOJYqvVY3Yoskw6FZOHYAth4btAi+sGmCdHHdcsHaH BHbPpzn/QYY97dRfVpKP/Ola1JXtBU2ChFgqodbd3PY8VKUeYozd4MWModDj1KNP6jOJ y88Q== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@google.com header.s=20230601 header.b=zkPBm0bH; arc=pass (i=1 spf=pass spfdomain=flex--yosryahmed.bounces.google.com dkim=pass dkdomain=google.com dmarc=pass fromdomain=google.com); spf=pass (google.com: domain of linux-kernel+bounces-44096-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-44096-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id dz17-20020a05620a2b9100b007847b27b9basi375573qkb.163.2024.01.30.00.11.49 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Jan 2024 00:11:49 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-44096-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20230601 header.b=zkPBm0bH; arc=pass (i=1 spf=pass spfdomain=flex--yosryahmed.bounces.google.com dkim=pass dkdomain=google.com dmarc=pass fromdomain=google.com); spf=pass (google.com: domain of linux-kernel+bounces-44096-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-44096-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 2B2021C23B49 for ; Tue, 30 Jan 2024 08:11:49 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 927B355C33; Tue, 30 Jan 2024 08:11:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="zkPBm0bH" Received: from mail-yw1-f201.google.com (mail-yw1-f201.google.com [209.85.128.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5A4F454736 for ; Tue, 30 Jan 2024 08:11:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706602301; cv=none; b=haGu8DfDX9pJ/aJdQkFAo3aYza/hL+yd8wAj8lsL0moXDCLhcHZ4T7SUGZA4em06oFjEmz40pjp7U/xTtRlXHwe1Nm+Twg00Y3Ytd/paHOb8R8v0AUzYk9p0YGC/G/g+B+cGJkyvu5y9FS5wAQOMilL6P71XnEZlpqTVdTzW9XE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706602301; c=relaxed/simple; bh=tJcfkRLSec8V90fDBMcC8fu9LjoS7gBQvD2cDv827co=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=WMLx94W6UJjFRvbWKqcJEjFUxYVAQWYvYlsI9tLaJ6H4UBh9im2q1zQyf21rHx25Z4RjDMulH2NEqzEPr1+n0ALuz+PZdOfaZhixL+yAHyGwBqyp4sWNRFoByCzoSI44nI87kVivFfRAr/Ooed+nUhybUez/yFVG/w5+p879CLQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--yosryahmed.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=zkPBm0bH; arc=none smtp.client-ip=209.85.128.201 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--yosryahmed.bounces.google.com Received: by mail-yw1-f201.google.com with SMTP id 00721157ae682-602d22a54caso53284047b3.3 for ; Tue, 30 Jan 2024 00:11:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1706602299; x=1707207099; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=MB0zSqc4v6QJWm2r+bwmMTwgDhYEDBQW95gH3tHtSso=; b=zkPBm0bHIAFekSK2nebDKPGlNGrpwG/t87B4Z9sENt7ja5wrRUlJdC1U8SNaPwkEoi +/1ml8+NEeKzesTeBTi3tCWwNvQEcnVaW4roaK6akHLX/BGJ8WSV/0UUbDqMZ2Ijd+98 NAN9L5aec5DETBgu0ucCkRiY03SiosRn9EjY8r+AG/KK39LOgx6iV7gFkv+bYEKPZkd5 A6dVJkcko2GO4ZWS0v4obSXl52gm6vUtWxX3iGwLBvZAij4aTrgk1U+ouAxYA9XJ0Pas bA4ubkNylKA8xDYRzWcs6CM4aFmqvtddHaWYVgAkCUL1ADZGCtFwc2yylkZsdkJFjNHv PzXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706602299; x=1707207099; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=MB0zSqc4v6QJWm2r+bwmMTwgDhYEDBQW95gH3tHtSso=; b=EEwJ9TiS5POr/3wsFE3V2Ho7a6N7S9yWzlnDB1DhMOgQzb73KQNZ8UTIvXqySSd6y3 IDzcfV0efcZLVk4bI1X4VCGGy8klhP6gIi0eyBVRvoyzFCfazDpb+YuAnMrt2VyV2FhH dZ0fRIsojP5q59tR2RmRXYw1N47PH1K2EsrLFje/bQJk+iwNZxDQp7S6khGo5yX1AqxB ZhTPCm3X4vFm1+t+nDMtU/biljdy6cqK7SvqItgVVwGxiCfhiRcL/k/aU8jxp4HnRZ9v DMDvYuvWt985mq8icCN7H2Q/mqlfoBv2OcdFbS3De1K0XrtFY8KREzEpZoAruj3rKGJd xhtg== X-Gm-Message-State: AOJu0Yw0gGaFe9nm4OkAKWd/cS07lzjeg/hmaChTpczN0EFNDS2/5Ch+ Y5Anzno7F9pNOgsyyI0wSXd2+KvtYfmCPm6fK7CohYqjIso8AU8D+QYWQ1CWbeeN7qK7SDjjJas BEi2fIJ0pDJEKNfwPbg== X-Received: from yosry.c.googlers.com ([fda3:e722:ac3:cc00:20:ed76:c0a8:29b4]) (user=yosryahmed job=sendgmr) by 2002:a05:690c:f91:b0:5ff:80cb:23c7 with SMTP id df17-20020a05690c0f9100b005ff80cb23c7mr1764515ywb.1.1706602299330; Tue, 30 Jan 2024 00:11:39 -0800 (PST) Date: Tue, 30 Jan 2024 08:11:37 +0000 In-Reply-To: <20240130014208.565554-8-hannes@cmpxchg.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20240130014208.565554-1-hannes@cmpxchg.org> <20240130014208.565554-8-hannes@cmpxchg.org> Message-ID: Subject: Re: [PATCH 07/20] mm: zswap: break out zwap_compress() From: Yosry Ahmed To: Johannes Weiner Cc: Andrew Morton , Nhat Pham , Chengming Zhou , linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="us-ascii" On Mon, Jan 29, 2024 at 08:36:43PM -0500, Johannes Weiner wrote: > zswap_store() is long and mixes work at the zswap layer with work at > the backend and compression layer. Move compression & backend work to > zswap_compress(), mirroring zswap_decompress(). > > Signed-off-by: Johannes Weiner Acked-by: Yosry Ahmed