Received: by 2002:a05:7412:d1aa:b0:fc:a2b0:25d7 with SMTP id ba42csp863055rdb; Tue, 30 Jan 2024 00:12:35 -0800 (PST) X-Google-Smtp-Source: AGHT+IGK79nggd2/1zbrK6zleoR2VBgfi6U0ns1AS0Sqz2q1rwzqSwF81px+SSnmrr6nmDjPep1i X-Received: by 2002:a05:6402:518b:b0:55e:fe1a:4d2f with SMTP id q11-20020a056402518b00b0055efe1a4d2fmr3697888edd.2.1706602355666; Tue, 30 Jan 2024 00:12:35 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1706602355; cv=pass; d=google.com; s=arc-20160816; b=R3dlWuhQLtLtxXr73fQEgt6bVl0rlx4qNYhZ2Fn08tQ/XPQK9h+IK0zbF3Wf28N6wf 9xD7eaKVrJNWCKNeyNWpopbF2eCpwFAqLC1Vzhma1TXw7fA6hKsz+4wKyAmejJPuk/du gqSHwpw7umzVNjt7QIWlQtDnarBQ8BoWhCP8+0ofHo9BMioJylREcdp1ClCRZLEo9gWS LJYBivNc1ABa1kvrgwJ+Yj+WFvpam15NnE9z6thn/AX4PhXFlqfifTFQgy4HT4QnXGaa 6UT9BAbydG1Cqq7Ou3aeNah2t+jQn6pvRi5JFJAZDe9bvWweyTriRaHKy8j5lJllvACg k/HQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=cc:to:from:subject:message-id:references:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:in-reply-to:date :dkim-signature; bh=KxgbaC8ibp/Nn5JOJr/iczAyfc5yUQS/YUOOzTWbh7Y=; fh=oocptefG+2lvFQHArvmvqHgNVObzaNhqiaCoJ7BqlI8=; b=EfvbTHzhhDtJldLXQV9nle2WJYK7auoS2nPH7QlLQf8aiTYvH0fRaygZjQ1WI/IQJG 1j4KNzJ4lmWtGClEe612oR/50VyQHF+iHhoccLXN6gKBTjSTa/FqHHm0FBTzPP2NHXh9 FmExWTX01sOwWeMq4k2VSCgBGtBh0qjtjUBsspJD/oMr/45ckT+fueyYeEjKlbccl9Lk iwDZBlH4q/dPdwhzkRUKt1xERhbwcU4QuEMwyP/7z0B+fOrUcqZ5JvX1aGmzHudAOuJb LbSUYxq4a+Arpb5cjNj3V5rRPr6tYU7POkybashsN2f/WNzEQskzojE0fiI9pQ5R+02R PwmA== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@google.com header.s=20230601 header.b=kPblFjks; arc=pass (i=1 spf=pass spfdomain=flex--yosryahmed.bounces.google.com dkim=pass dkdomain=google.com dmarc=pass fromdomain=google.com); spf=pass (google.com: domain of linux-kernel+bounces-44098-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-44098-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id w7-20020aa7da47000000b0055ef0c3d3ebsi2057881eds.601.2024.01.30.00.12.35 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Jan 2024 00:12:35 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-44098-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20230601 header.b=kPblFjks; arc=pass (i=1 spf=pass spfdomain=flex--yosryahmed.bounces.google.com dkim=pass dkdomain=google.com dmarc=pass fromdomain=google.com); spf=pass (google.com: domain of linux-kernel+bounces-44098-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-44098-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 2A0D31F23DF7 for ; Tue, 30 Jan 2024 08:12:29 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 486E955C33; Tue, 30 Jan 2024 08:12:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="kPblFjks" Received: from mail-yw1-f201.google.com (mail-yw1-f201.google.com [209.85.128.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0D87A54BF7 for ; Tue, 30 Jan 2024 08:12:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706602344; cv=none; b=IEdlHRcauXwO28rNkO34ZS+BVIMfwO0dTZIwtO7IFj0fCo2btgZeM7vOQGjZ/f+33g6wD3xOPAoq4WGhTTYXi7VYDoThfyFbKsb6zQ27Of77E6Ie9d3jwHFhuG2q4wIosVRMz9JbaxTGSlun6L0rK28x6X/x0bH2EYcMgGotDQc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706602344; c=relaxed/simple; bh=eoDHCGULiZaiVAIT8Qbigxp9/OCrCQz2Ml2F03WV+GI=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=CMNVN8vSXzT4/mVnKAYx3bgLnRftvSYJDCrIcvKmTQFiKd6k8GpvTSUcu10Kk2zqKfjgwnC7ySHRH2A1Fw9ckYsdzwNMkBaFmVVpNry0k1Ku7AbB6pw0gIhCmp87ViOdmC6ko/5ouhEoEcKG+yqC3VlL+kumkWT/oFwixxpV/MI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--yosryahmed.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=kPblFjks; arc=none smtp.client-ip=209.85.128.201 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--yosryahmed.bounces.google.com Received: by mail-yw1-f201.google.com with SMTP id 00721157ae682-603cbb8ebd4so26835837b3.3 for ; Tue, 30 Jan 2024 00:12:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1706602342; x=1707207142; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=KxgbaC8ibp/Nn5JOJr/iczAyfc5yUQS/YUOOzTWbh7Y=; b=kPblFjksl4FRek4KidWqCItqqrvJnsCQTGi9qTe9n4rkQuF1GQ7OajL45EoEi1vORh h6BviDvQpTLHdZQ4NCYy/OZzWIFLHUQnJqFknH2AZB4Mx6uwHQ/oJ6RoiWvhSEn751lK vZMZANhhktujCgYvlvnC7Vuolg/nIU+opc/ScpKqAwDKyKUv76ecftGUzIBINTlMe2I1 DhAS6fI2lFhY08fassGg0Ufij0FV8bTqbz6FuBwbZVk5LApFXQ1JOmafB3AafcLkOcAL V6EMUk86tAZ6px/Y112Q3MxHTfOlfEJsWGBPIy+GtfcriznzaFm0btvohqgAbYxbwGuC wDDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706602342; x=1707207142; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=KxgbaC8ibp/Nn5JOJr/iczAyfc5yUQS/YUOOzTWbh7Y=; b=tpyOg1Cu7MtJQzoUa85+o68ZeZQcFPVSFHm/WXPhRNT0XOOzA4fX6MJkcH+501ZhMA MrBny9MOocc/KVn2Wy4rjDNYhSE/0tJhCt1/V1XfzgIlQpnLmNCp7Xqr3wII+9wV0fSR w16iwmuIiC8Cb2HfY97RxZzkwteNsWJqBBz3Nd71Rp5gQ01y+gSvWa4rSPSinG1CAZOk F79rN++5iUOAm9O9M1Dr4yXAnScd14B1GOCSMgGvxOrq3h1fVJhGOlSUsry2Wt0wEyzb Aa4GnmkwQPBUTIPR6lF0cAIJGccNM1tBK/HMKtKIFIT5MYnmmSV6xYqfBjrHTRJDpYfB ag2w== X-Gm-Message-State: AOJu0YwnPbd19O3fKHPxqxtcMbfsA3ZCqFvvL75Mwr1tFoq86pWdN+v3 NMi+N4DzwRUA4EjfnuB0aQXVuV0UqzeeONNt+1OZK9u742QnAE/mq7pznobLaDlsDIF08JG/JPa PXvYZhW2++uZpJ1xL4A== X-Received: from yosry.c.googlers.com ([fda3:e722:ac3:cc00:20:ed76:c0a8:29b4]) (user=yosryahmed job=sendgmr) by 2002:a05:6902:10c4:b0:dbd:f7e4:c7f5 with SMTP id w4-20020a05690210c400b00dbdf7e4c7f5mr486918ybu.10.1706602341970; Tue, 30 Jan 2024 00:12:21 -0800 (PST) Date: Tue, 30 Jan 2024 08:12:20 +0000 In-Reply-To: <20240130014208.565554-9-hannes@cmpxchg.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20240130014208.565554-1-hannes@cmpxchg.org> <20240130014208.565554-9-hannes@cmpxchg.org> Message-ID: Subject: Re: [PATCH 08/20] mm: zswap: further cleanup zswap_store() From: Yosry Ahmed To: Johannes Weiner Cc: Andrew Morton , Nhat Pham , Chengming Zhou , linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="us-ascii" On Mon, Jan 29, 2024 at 08:36:44PM -0500, Johannes Weiner wrote: > - Remove dupentry, reusing entry works just fine. > - Rename pool to shrink_pool, as this one actually is confusing. > - Remove page, use folio_nid() and kmap_local_folio() directly. > - Set entry->swpentry in a common path. > - Move value and src to local scope of use. > > Signed-off-by: Johannes Weiner Acked-by: Yosry Ahmed