Received-SPF: pass (google.com: domain of linux-kernel+bounces-44131-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <ecd2ffa0-b2b2-3b09-5799-6f7d4d4054c9@quicinc.com>
Date: Tue, 30 Jan 2024 13:56:59 +0530
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.0
Subject: Re: [PATCH] media: dt-bindings: qcom,sc7280-venus: Allow one IOMMU
 entry
Content-Language: en-US
To: Luca Weiss <luca.weiss@fairphone.com>, Conor Dooley <conor@kernel.org>
CC: Bjorn Andersson <andersson@kernel.org>,
        Konrad Dybcio
	<konrad.dybcio@linaro.org>,
        Stanimir Varbanov
	<stanimir.k.varbanov@gmail.com>,
        Bryan O'Donoghue
	<bryan.odonoghue@linaro.org>,
        Mauro Carvalho Chehab <mchehab@kernel.org>,
        Rob
 Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski
	<krzysztof.kozlowski+dt@linaro.org>,
        Conor Dooley <conor+dt@kernel.org>,
        <~postmarketos/upstreaming@lists.sr.ht>, <phone-devel@vger.kernel.org>,
        Stanimir Varbanov <stanimir.varbanov@linaro.org>,
        <linux-arm-msm@vger.kernel.org>, <linux-media@vger.kernel.org>,
        <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>
References: <20240129-sc7280-venus-bindings-v1-1-20a9ba194c60@fairphone.com>
 <20240129-numerate-brought-4660c2a89719@spud>
 <CYRVI1IQ2UKE.15ZGCYLRT3ND3@fairphone.com>
From: Vikash Garodia <quic_vgarodia@quicinc.com>
In-Reply-To: <CYRVI1IQ2UKE.15ZGCYLRT3ND3@fairphone.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit

Hello,

On 1/30/2024 1:17 PM, Luca Weiss wrote:
> On Mon Jan 29, 2024 at 6:37 PM CET, Conor Dooley wrote:
>> On Mon, Jan 29, 2024 at 08:48:54AM +0100, Luca Weiss wrote:
>>> Some SC7280-based boards crash when providing the "secure_non_pixel"
>>> context bank, so allow only one iommu in the bindings also.
>>>
>>> Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
>>
>> Do we have any idea why this happens? How is someone supposed to know
>> whether or not their system requires you to only provide one iommu?
>> Yes, a crash might be the obvious answer, but is there a way of knowing
>> without the crashes?
> 
> +CC Vikash Garodia
> 
> Unfortunately I don't really have much more information than this
> message here:
> https://lore.kernel.org/linux-arm-msm/ff021f49-f81b-0fd1-bd2c-895dbbb03d56@quicinc.com/
> 
> And see also the following replies for a bit more context, like this
> one:
> https://lore.kernel.org/linux-arm-msm/a4e8b531-49f9-f4a1-51cb-e422c56281cc@quicinc.com/
> 
> Maybe Vikash can add some more info regarding this.

0x2184 is a secure SID i.e any transactions with that ID would be access
controlled by trustzone (TZ). SC7280 (chromebook) was designed without TZ, while
some other DT deriving from SC7280 (like qcm6490) might have TZ. Hence it is
good to move the iommu entry from SC7280 to chrome-common.

Regards,
Vikash