Received-SPF: pass (google.com: domain of linux-kernel+bounces-44246-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Tue, 30 Jan 2024 09:22:52 +0000
In-Reply-To: <20240123150112.124084-1-kernel@valentinobst.de>
Precedence: bulk
Mime-Version: 1.0
References: <20240123150112.124084-1-kernel@valentinobst.de>
Message-ID: <20240130092252.1610582-1-aliceryhl@google.com>
Subject: Re: [PATCH v2 00/12] rust: kernel: documentation improvements
From: Alice Ryhl <aliceryhl@google.com>
To: kernel@valentinobst.de
Cc: alex.gaynor@gmail.com, fraunhofer@valentinobst.de, 
	linux-kernel@vger.kernel.org, ojeda@kernel.org, 
	rust-for-linux@vger.kernel.org, wedsonaf@gmail.com, 
	Alice Ryhl <aliceryhl@google.com>
Content-Type: text/plain; charset="utf-8"

Valentin Obst <kernel@valentinobst.de> writes:
> This patch set aims to make small improvements to the documentation of
> the kernel crate. It engages in a few different activities:
> - fixing trivial typos (commit #1),
> - updating code examples to better reflect an idiomatic coding style
>   (commits #2,6),
> - increasing the consistency within the crate's documentation as a whole
>   (commits #3,5,7,8,9,11,12),
> - adding more intra-doc links as well as srctree-relative links to C
>   header files (commits #4,10).

I left one comment [1] on the last patch. With that fixed, you may add:

Reviewed-by: Alice Ryhl <aliceryhl@google.com>

to all of the patches.

(I responded on v1 by accident, but it was v2 that I have reviewed.)

[1]: https://lore.kernel.org/rust-for-linux/CAH5fLghSaorRgDDuqNCN-BhQ86ysX96b=nKM_cZAN0_E6Ai04A@mail.gmail.com/