Received-SPF: pass (google.com: domain of linux-kernel+bounces-44256-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Message-ID: <e45bd402-0c39-4075-a730-1dd5f4fc2208@loongson.cn>
Date: Tue, 30 Jan 2024 17:27:49 +0800
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] sched/doc: Update EM API em_pd_energy to em_cpu_energy
To: Chenggang Wang <wangchenggang@vivo.com>, Jonathan Corbet
 <corbet@lwn.net>, Alex Shi <alexs@kernel.org>,
 Pierre Gondois <Pierre.Gondois@arm.com>, Bjorn Helgaas
 <bhelgaas@google.com>, Dietmar Eggemann <dietmar.eggemann@arm.com>,
 Lukasz Luba <lukasz.luba@arm.com>, linux-doc@vger.kernel.org,
 linux-kernel@vger.kernel.org
References: <TY0PR06MB5470E30E86989E8CD84FCE0DC47D2@TY0PR06MB5470.apcprd06.prod.outlook.com>
 <1706585531-24072-1-git-send-email-wangchenggang@vivo.com>
Content-Language: en-US
From: Yanteng Si <siyanteng@loongson.cn>
In-Reply-To: <1706585531-24072-1-git-send-email-wangchenggang@vivo.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

Hi Chenggang,

在 2024/1/30 11:32, Chenggang Wang 写道:
> The em_pd_energy function name is obsolete and non-existent now.
> ---

It is not a complete patch, at least it is missing a Signed of by; Then, 
could you please explain

the reason for sending again in a short period of time? Perhaps this 
email should be used as

patch v2. see .../Documentation/translations/zh_CN/process/5.Posting.rst


You can also execute this command:

  $:./scripts/checkpatch.pl

Then silence all warnings and errors.


Thanks,

Yanteng

>   Documentation/scheduler/sched-energy.rst                    | 2 +-
>   Documentation/translations/zh_CN/scheduler/sched-energy.rst | 2 +-
>   2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/scheduler/sched-energy.rst b/Documentation/scheduler/sched-energy.rst
> index 70e2921..84b37a2 100644
> --- a/Documentation/scheduler/sched-energy.rst
> +++ b/Documentation/scheduler/sched-energy.rst
> @@ -141,7 +141,7 @@ in its previous activation.
>   find_energy_efficient_cpu() uses compute_energy() to estimate what will be the
>   energy consumed by the system if the waking task was migrated. compute_energy()
>   looks at the current utilization landscape of the CPUs and adjusts it to
> -'simulate' the task migration. The EM framework provides the em_pd_energy() API
> +'simulate' the task migration. The EM framework provides the em_cpu_energy() API
>   which computes the expected energy consumption of each performance domain for
>   the given utilization landscape.
>   
> diff --git a/Documentation/translations/zh_CN/scheduler/sched-energy.rst b/Documentation/translations/zh_CN/scheduler/sched-energy.rst
> index fdbf6cf..03dedc6 100644
> --- a/Documentation/translations/zh_CN/scheduler/sched-energy.rst
> +++ b/Documentation/translations/zh_CN/scheduler/sched-energy.rst
> @@ -119,7 +119,7 @@ EAS覆盖了CFS的任务唤醒平衡代码。在唤醒平衡时，它使用平
>   
>   如果唤醒的任务被迁移，find_energy_efficient_cpu()使用compute_energy()来估算
>   系统将消耗多少能量。compute_energy()检查各CPU当前的利用率情况，并尝试调整来
> -“模拟”任务迁移。EM框架提供了API em_pd_energy()计算每个性能域在给定的利用率条件
> +“模拟”任务迁移。EM框架提供了API em_cpu_energy()计算每个性能域在给定的利用率条件
>   下的预期能量消耗。
>   
>   下面详细介绍一个优化能量消耗的任务放置决策的例子。