Received: by 2002:a05:7412:d1aa:b0:fc:a2b0:25d7 with SMTP id ba42csp909190rdb; Tue, 30 Jan 2024 02:11:47 -0800 (PST) X-Google-Smtp-Source: AGHT+IHaq8M0DL6UcV+AiKRtEnrZjrdZ2M6/Ve51UhMLOdDXcJGoAoYWLxCYPlOEwtzcg3tSmAfO X-Received: by 2002:a05:651c:1255:b0:2cc:e976:5915 with SMTP id h21-20020a05651c125500b002cce9765915mr4695182ljh.49.1706609507251; Tue, 30 Jan 2024 02:11:47 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1706609507; cv=pass; d=google.com; s=arc-20160816; b=XAWgQKRgmaJX+8zTPIAifvXCpJ8p4xU+/Djg9+Q2j0dhb0EgFopbd/bZtnv7qHcRdD 5yd8VT8478hgIcACBQOk4nBPimIPB/sAAgQgB9s6zgac29qpjdRrmwOt6k4+6nptetAC Gzgb12ywmEstids9afB05NIQgEWx4abRVhq1OU4i4tQeHT04o9JC5IBTdI9+kABn3Hoc 2Zk9e+y17rw8DDBIPva7OsKdgaiN8Q+LD8iluDmIi4JMMZ/VVxN+zik1sXME9C6MOblk OBmd0/bTU890LvppPnn4wHkf584Vi8WEOkK1nb1A/peYCH90nG9XDcrYOeiAmem9/hfq 8sTA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:from:references:cc:to:subject :user-agent:mime-version:list-unsubscribe:list-subscribe:list-id :precedence:date:message-id:dkim-signature; bh=2chnDtx7fC/xK0UK9k7nOkhmZ+WTIJOelHVHg2jjY5I=; fh=q74P04jWSmqoiA7Jl0YhJHclvbTye8k9rXnMj+XU6iM=; b=kUy0F1yHEYVZNbznWRFfeYAF7o5S5K0897lJvzVnrjbAb+YMR3GeAhCzaezPABvPsM 1T61Fk5dlnXh+1gJrKy3kqDa67bZWPj5H/tAVJcKcXgM6XDFTWNTSEcLL05ls2MJXx0x wsuESLtoXsm2sv7i9/uXVzO5+pE1EiUN5diBKHoscuL0zx6Yu9kDtC/zsKQyyyJ3gcbt 3RxAluiuNiTBrcFFTVIVlR3AXh3wKrLIS/uNVMGqEPkWubwyNYsrnWwzoCO2hdgZA09F p/OpVkPCfzn+dEw1GQrZMGgf2XH+KQj/RQ21FDR8LgSajvd9nEXnGEtT/ZHFlqKsaJNE L+9Q== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=nnZBm0kw; arc=pass (i=1 dkim=pass dkdomain=intel.com dmarc=pass fromdomain=linux.intel.com); spf=pass (google.com: domain of linux-kernel+bounces-43947-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-43947-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id ig2-20020a056402458200b0055ed779088asi2685457edb.143.2024.01.30.02.11.47 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Jan 2024 02:11:47 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-43947-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=nnZBm0kw; arc=pass (i=1 dkim=pass dkdomain=intel.com dmarc=pass fromdomain=linux.intel.com); spf=pass (google.com: domain of linux-kernel+bounces-43947-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-43947-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 397311F25020 for ; Tue, 30 Jan 2024 05:23:23 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id DF96D381BB; Tue, 30 Jan 2024 05:23:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="nnZBm0kw" Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BB74B381AB; Tue, 30 Jan 2024 05:23:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.11 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706592192; cv=none; b=kdzzHtFUlH3nQK7tDFONnGNLJm0gXvCpRbTu5ZhImkHym/G+ZwgY4F1SwUxE8jEMGB+3H/Yncb/trmZc+Wz2388CNHzknxZZ4oJAsyE1gCJySyZjqLRLaUq2taeR9w0N/cJBDfhiWuMj0H7HQlvF1TlaT7QYtbQj/QgjYzWyFFo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706592192; c=relaxed/simple; bh=2chnDtx7fC/xK0UK9k7nOkhmZ+WTIJOelHVHg2jjY5I=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=V2Tc8wa6AXxvRsTEwHAeTl8+EP39lhovGpPbgFIOQtCS0QcuofJTvaFv9jM2CcY2dI/I46rQ0E+rapLzE54MZpAt1zIUDvYJWI7XRSgsHgAvpwm+jk4nIM9KuKgjk+EISF9IpuZsVvDNoQpyYTTE3xMWgduSV9byzJMwdpXpgMk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=nnZBm0kw; arc=none smtp.client-ip=198.175.65.11 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1706592190; x=1738128190; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=2chnDtx7fC/xK0UK9k7nOkhmZ+WTIJOelHVHg2jjY5I=; b=nnZBm0kwI57oJFXABhnxKd2tONYOyOYq4CvJZJY6BO3uZP+e74pdOeMt joLJVQcitipcNSBRHCIY54IGHzh2EoDzPPadW6KWwsgFwEyo224Uz0ksz 9evpynKd8L+4x6wb0tDK41MzPpHuHtW3uyarqILe+J2cuogJJvZnZorj/ dIy0XfqxRqXFSZ4M/ij4og8YL222ZvjAluHae4qzrX6rIyLjvi2OXf4FL bEmTuQ9VL2k4IIEjGDXKKWXXaxMpYsCa/7WLX1DCKzsggDL5oZqltVCLD kH7o817iK54WpFogRtCbX4QadVnR5eUo+qylZEGrxwybbrz05goAhwCLH A==; X-IronPort-AV: E=McAfee;i="6600,9927,10968"; a="9813240" X-IronPort-AV: E=Sophos;i="6.05,707,1701158400"; d="scan'208";a="9813240" Received: from fmviesa005.fm.intel.com ([10.60.135.145]) by orvoesa103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Jan 2024 21:23:10 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.05,707,1701158400"; d="scan'208";a="3545275" Received: from zhaohaif-mobl.ccr.corp.intel.com (HELO [10.238.130.190]) ([10.238.130.190]) by fmviesa005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Jan 2024 21:23:07 -0800 Message-ID: Date: Tue, 30 Jan 2024 13:23:04 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v12 1/5] PCI: make pci_dev_is_disconnected() helper public for other drivers To: "Tian, Kevin" , "baolu.lu@linux.intel.com" , "bhelgaas@google.com" , "robin.murphy@arm.com" , "jgg@ziepe.ca" Cc: "dwmw2@infradead.org" , "will@kernel.org" , "lukas@wunner.de" , "Liu, Yi L" , "iommu@lists.linux.dev" , "linux-kernel@vger.kernel.org" , "linux-pci@vger.kernel.org" , Haorong Ye References: <20240129034924.817005-1-haifeng.zhao@linux.intel.com> <20240129034924.817005-2-haifeng.zhao@linux.intel.com> From: Ethan Zhao In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 1/29/2024 4:50 PM, Tian, Kevin wrote: >> From: Ethan Zhao >> Sent: Monday, January 29, 2024 11:49 AM >> >> Make pci_dev_is_disconnected() public so that it can be called from >> Intel VT-d driver to quickly fix/workaround the surprise removal >> unplug hang issue for those ATS capable devices on PCIe switch downstream >> hotplug capable ports. >> >> Beside pci_device_is_present() function, this one has no config space > s/Beside/Unlike/ Beside means 'comparing with' here, perhaps it is not clear enough or there is syntax error if used here ? Thanks, Ethan > >> space access, so is light enough to optimize the normal pure surprise >> removal and safe removal flow. > somehow this paragraph belongs to the patch using it. The 1st paragraph > is sufficient for the reason of exposure.