Received-SPF: pass (google.com: domain of linux-kernel+bounces-44386-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Tue, 30 Jan 2024 10:34:22 +0000
From: Mark Rutland <mark.rutland@arm.com>
To: Kemeng Shi <shikemeng@huaweicloud.com>
Cc: catalin.marinas@arm.com, will@kernel.org, revest@chromium.org,
	rostedt@goodmis.org, arnd@arndb.de, pengdonglin@sangfor.com.cn,
	linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64: make member of struct pt_regs and it's offset
 macro in the same order
Message-ID: <ZbjQrtHOvC4Igsur@FVFF77S0Q05N>
References: <20240130175504.106364-1-shikemeng@huaweicloud.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240130175504.106364-1-shikemeng@huaweicloud.com>

On Wed, Jan 31, 2024 at 01:55:04AM +0800, Kemeng Shi wrote:
> In struct pt_regs, member pstate is after member pc. Move offset macro
> of pstate after offset macro of pc to improve readability a little.
> 
> Signed-off-by: Kemeng Shi <shikemeng@huaweicloud.com>

I think this makes sense as a trivial cleanup, so FWIW:

Acked-by: Mark Rutland <mark.rutland@arm.com>

Mark.

> ---
>  arch/arm64/kernel/asm-offsets.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/kernel/asm-offsets.c b/arch/arm64/kernel/asm-offsets.c
> index 5ff1942b04fc..865ba901c233 100644
> --- a/arch/arm64/kernel/asm-offsets.c
> +++ b/arch/arm64/kernel/asm-offsets.c
> @@ -75,8 +75,8 @@ int main(void)
>    DEFINE(S_FP,			offsetof(struct pt_regs, regs[29]));
>    DEFINE(S_LR,			offsetof(struct pt_regs, regs[30]));
>    DEFINE(S_SP,			offsetof(struct pt_regs, sp));
> -  DEFINE(S_PSTATE,		offsetof(struct pt_regs, pstate));
>    DEFINE(S_PC,			offsetof(struct pt_regs, pc));
> +  DEFINE(S_PSTATE,		offsetof(struct pt_regs, pstate));
>    DEFINE(S_SYSCALLNO,		offsetof(struct pt_regs, syscallno));
>    DEFINE(S_SDEI_TTBR1,		offsetof(struct pt_regs, sdei_ttbr1));
>    DEFINE(S_PMR_SAVE,		offsetof(struct pt_regs, pmr_save));
> -- 
> 2.30.0
>