Received-SPF: pass (google.com: domain of linux-kernel+bounces-44447-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <a06713d9-5e29-466c-9eb9-ddb86e2f0677@nvidia.com>
Date: Tue, 30 Jan 2024 11:01:51 +0000
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] soc/tegra: fix build failure on Tegra241
Content-Language: en-US
To: Arnd Bergmann <arnd@kernel.org>, Thierry Reding
 <thierry.reding@gmail.com>, Kartik <kkartik@nvidia.com>
Cc: Arnd Bergmann <arnd@arndb.de>, Rob Herring <robh@kernel.org>,
 linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20240103102654.3779458-1-arnd@kernel.org>
From: Jon Hunter <jonathanh@nvidia.com>
In-Reply-To: <20240103102654.3779458-1-arnd@kernel.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?VWsxd0t3M1BoS2l1ZGZuSWpIVGQ0QWFsY0JNN2dFZngwbHNjZGtlME5jdmpK?=
 =?utf-8?B?WjdJblVzZy9Ia0orMEEyQXlJcHorTnZ1NWtlQXVrblNBUTNTamcvTUZjUk9y?=
 =?utf-8?B?cUZLVnNGV3VieHNDbWljSWxHajgzcFk5LzhBSmpQNTBTWXpZMy83WnZqamxB?=
 =?utf-8?B?Ky9td002RnhRZjAwcHRENkdmVXNmeEdybmtnZEJSWktJM2pKOTB5dG1Bbnll?=
 =?utf-8?B?elVLMHQwYmJPYUN6NitvRjB4WE5ZOGVWemJzNVZaRWJjRnRVWm1hTUJsaVk0?=
 =?utf-8?B?ZHR4K1dKMStlRHNSVkdiMmkzWjgxZEZuM1RiTzErNEJLRU04UHVwL1BUZ1d0?=
 =?utf-8?B?b1ZoUStqV2laL0pXWEx5K2d4c0lNK3NkQzkxQldKTnM4SlN1ODBWcVVkdEpl?=
 =?utf-8?B?YmNZN2dlalpUZnoyT1FJdTNvajhpcFdVMmFnMGNMb1dkRGVXOGdCZTd1Q2Qw?=
 =?utf-8?B?LzlkOVNYeHdzMWRWdG5hdHRpR3ZVWnYreUZJSzVTQVRzcEdBQi96MWhmdktw?=
 =?utf-8?B?ZWoxTlIxQVFzYlYxMnJielFWK20wMU5lQzJFWWZyeVVFbVBHclNuK1ZIVHNE?=
 =?utf-8?B?eVRLUlhqZDN3YUtCRnhWaHpsdnFlTGhuMmVBQlR3bFZVdm5GRmMyeDlaMUFq?=
 =?utf-8?B?aTBoRDhadHhlQWRlblhxL2srUVlka3d1c1BuekpaeEJyY0pVOGxMZWdtTGZY?=
 =?utf-8?B?YkpnTDJPVkxtNzNkbFJlRnBncjFqNk9TQStCRkVOOVVidFRlRmVISm5Bd1Av?=
 =?utf-8?B?UWhMUFlOV0xwYXkyZm5PaGRqTE05dkJKQ3Z6UFU2T25jaHF5aERlbGo3R3E0?=
 =?utf-8?B?SGtvMVZoL2FsRm5zOXNlSzZzNWczOEc3SFkvUmlkL0NJY0NPTmxDb1FtZjN6?=
 =?utf-8?B?U1pZZTZMemdJQlAyNnVMT2NrQkozdzdCalhoVzFRNFlMbmFiNGxUd1ltZzZo?=
 =?utf-8?B?Mk1TU2FlTlJ0c0FKUlRib2lYMU1xelZJSXhvaEU1OWRtbFBtc3FkU2dyUkpJ?=
 =?utf-8?B?eCttNHdtYTR6Ykdkd3htR25QKy9sSG5yVjdJUUJqVHE3emcvK1YzeFpxVHJ6?=
 =?utf-8?B?UmxGUkdSVWJENlJMbDgyb0RpYlJDM2lTMnQyV3JtTWEzTEhHd1Vid2dIcTA5?=
 =?utf-8?B?a3B4bURLZXJJTDlEanRiUDVWR0I4eWk0SEFsUkVpeVc5d2tqVnZSQmRQRXAr?=
 =?utf-8?B?ZjdDWjMyTDlJYXVUcWNpTzFzM1lvOXRnNEFrRHNjeWM2eUhmWHJ6QnR5Um9O?=
 =?utf-8?B?TXExUVVXNUs4OTdicVVGV2dHQXcrU0F4SWhEdTNicmFRa1JsRDRhNlgvamg5?=
 =?utf-8?B?bmdFaGFQbW5ENmE0clBBQTBGWkFWamNjemJPak9ad0dFTGNOaG90aGJVMFN1?=
 =?utf-8?B?bXVVOHI3RTBUWU9HNjh4QW5qT09mN1VBckxudHMwZDFqOFBFUTRsSGFGMmtP?=
 =?utf-8?B?d1owZDdEb05EbEo3N0ZXNnk0bXhZcE5weUtqcjNTUG9mU2JLQWEwM2krcjVS?=
 =?utf-8?B?SWd2STd3aytHZWFvK21PeVRzWG9lc2srVEJraXpPdVp5dHN5ZmU3R0x0aDNu?=
 =?utf-8?B?c0VuRmxMSWZaWXR6L29DR1c5K3RsRm0yZ2Y2UDRtdEV2QUlqaFJZeE5qUWQ2?=
 =?utf-8?B?RHJZUGFlSy83V3FKRiswVERDeHRtbDdIRkhzN0d5TVZmRzBvRm0ray9IbFlN?=
 =?utf-8?B?bmJaUlB1M014bG04ZjVhdGNsYmNyNm13TWpnYlJFVXVxYlg5VEc3MGpoYm5T?=
 =?utf-8?B?YVNMZ0w4dlpKOFZEaVhCWHdobXcvNEVqTmZkRmlncDNUVU92V3pmUVZUNmdm?=
 =?utf-8?B?alBHR1RsclJIQmtnUWp1Z1NsVVVJTHZQVk01NTZQSGNOV2w3Mm9LNHdaY1hB?=
 =?utf-8?B?b0xEZmIzZDBRd1lhWmsyTlFtQ0JzNkY1aVRWejloVXlUcVlKM0g1MUQ1U3hX?=
 =?utf-8?B?aFU3ZFcxM3RUUE5wV2pGQTV2QTlmSVQ0eG1DdVNrNTZhNllBc1owTHJRenpv?=
 =?utf-8?B?dmpTYlJsQ1JMRzFEVHltbUdsdjZ2dm9oMmg4T09YWW5pem1kK2hxRElqK1FL?=
 =?utf-8?B?OWFlN2ZBT3Z2S2k1bEJoOHB2d2tMN1grVHYwV3VWcXJMZG9UUk1Oc1pKdExL?=
 =?utf-8?B?Q3ovQlExeTNaZlF4RTBLajhOUVYxVmZDanBEVmF3emhxemJnaU5ZZWdaaHJX?=
 =?utf-8?B?bkE9PQ==?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 43839504-7c35-4f7c-8a9d-08dc2182df8e
X-MS-Exchange-CrossTenant-AuthSource: CO6PR12MB5444.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Jan 2024 11:01:56.2240
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: fe/Z9Y2NR1v9C+2tKOtOWZLl4eRbZqaietDC9PqN6lwUu4V/iW7lmodxJsQOQNISUbBg9z4F+Xbiu3GGewCJpw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR12MB6077


On 03/01/2024 10:26, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> If all the other SoCs are disabled, the driver fails to build:
> 
> drivers/soc/tegra/fuse/fuse-tegra30.c:684:17: error: 'tegra30_fuse_read' undeclared here (not in a function); did you mean 'tegra_fuse_readl'?
>    684 |         .read = tegra30_fuse_read,
>        |                 ^~~~~~~~~~~~~~~~~
>        |                 tegra_fuse_readl
> drivers/soc/tegra/fuse/fuse-tegra30.c:694:17: error: 'tegra30_fuse_init' undeclared here (not in a function); did you mean 'tegra_fuse_info'?
>    694 |         .init = tegra30_fuse_init,
>        |                 ^~~~~~~~~~~~~~~~~
> 
> Fix the list of SoCs using this function to include the newly added one.
> 
> Fixes: dee509eb9cd5 ("soc/tegra: fuse: Add support for Tegra241")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
>   drivers/soc/tegra/fuse/fuse-tegra30.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/soc/tegra/fuse/fuse-tegra30.c b/drivers/soc/tegra/fuse/fuse-tegra30.c
> index 2070d36c510d..eb14e5ff5a0a 100644
> --- a/drivers/soc/tegra/fuse/fuse-tegra30.c
> +++ b/drivers/soc/tegra/fuse/fuse-tegra30.c
> @@ -38,7 +38,8 @@
>       defined(CONFIG_ARCH_TEGRA_210_SOC) || \
>       defined(CONFIG_ARCH_TEGRA_186_SOC) || \
>       defined(CONFIG_ARCH_TEGRA_194_SOC) || \
> -    defined(CONFIG_ARCH_TEGRA_234_SOC)
> +    defined(CONFIG_ARCH_TEGRA_234_SOC) || \
> +    defined(CONFIG_ARCH_TEGRA_241_SOC)
>   static u32 tegra30_fuse_read_early(struct tegra_fuse *fuse, unsigned int offset)
>   {
>   	if (WARN_ON(!fuse->base))


Thanks for fixing!

Reviewed-by: Jon Hunter <jonathanh@nvidia.com>

Jon

-- 
nvpublic