Received-SPF: pass (google.com: domain of linux-kernel+bounces-44541-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <49bb7b5b-4186-83cc-7e1e-4892c7e8b6ef@axentia.se>
Date: Tue, 30 Jan 2024 12:42:03 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.6.0
Subject: Re: [PATCH v2] dt-bindings: iio: afe: voltage-divider: Add
 io-channel-cells
Content-Language: sv-SE
To: Naresh Solanki <naresh.solanki@9elements.com>,
 Jonathan Cameron <jic23@kernel.org>, Lars-Peter Clausen <lars@metafoo.de>,
 Rob Herring <robh+dt@kernel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
 Conor Dooley <conor+dt@kernel.org>
Cc: mazziesaccount@gmail.com, linux-iio@vger.kernel.org,
 devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20240130111830.4016002-1-naresh.solanki@9elements.com>
From: Peter Rosin <peda@axentia.se>
In-Reply-To: <20240130111830.4016002-1-naresh.solanki@9elements.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?endxbm1CWk0xQWZEOUlwc0Vac0luY2IvcmllK2RzSWhGbW5kYldFVUE1WWJQ?=
 =?utf-8?B?clhGMTUxNEk3OTRkZEpRNkdtRGd4Y3NsNXN1N1lYQ2dNTVBSOWozZXErR3ND?=
 =?utf-8?B?dFVvZzNuUkYyaHMxcmhBcFBrTEhwc1JRc3VBQVFGZGZBMG1aN3liMFZZQnRI?=
 =?utf-8?B?VldCRW1hSHBQSDlQcXlMYUhWQjI4UGdrZkUwUWU3NmwrM0VCRGhQam5WcnNU?=
 =?utf-8?B?dFQrcE5aTStHSFNQSW92Zi9XeXNvTkxTMmw0a0I5bzZWK1hEYUx4ajd1ZVFn?=
 =?utf-8?B?Q1I3ZTJ6RWo2aFlVU25ZRHpuSlBjN0xTdDFlMkVYV3RCTEZnV0d0NWhsak53?=
 =?utf-8?B?K200M1NWRTZpRCswMXVtbWNGMHYvNG5yN1RRejhHbDNYWm5TMHhhY3NwK2hy?=
 =?utf-8?B?SUx6MHlXSHlwWmI0bUJnWWhJZHBjNDB6T2ZCbTd6TU9CaTQ3Q01neGZkVDlx?=
 =?utf-8?B?d2o4bEM3KytlaGdtWi9yK21Ud095OHYzQkgrcjE2dkJqbDdHUC9QUWUrU1lw?=
 =?utf-8?B?QlQweksyZmwveWpBcE12RUdLaGNYSlAxem5nalNpVnZRZDBJdm5BTkhlSGV3?=
 =?utf-8?B?M2s0QVJITkcvNUtqeGF0cENCRUF1MjIzMHdld3YrUDBtR1VOdERJVTZnZTVJ?=
 =?utf-8?B?SU1BaEZ4c0lZQktzdm1WMkJKMmJKLzNUYmRtbHZ1dzJpa3ZjQ1BTTnRWanNV?=
 =?utf-8?B?aUNhVTY4OCtWQkp6L1hVczgyTjR5d1FxUHd4Tlowc0kwa2JiVGtJc243bkJl?=
 =?utf-8?B?Sjg2dWJPU0hyamFzV00wUVVkTmQvT010WjFlUm0zKzdhMTYrZ0ozZFEwVjZr?=
 =?utf-8?B?K1p0cTY1WTNrdlc4OHl3VzBYQnh4ZFBjS2tWTWNTbHd3WFRaSjdCT2MrRUxx?=
 =?utf-8?B?WjR2bE5CRTN3VFhBTnRxT1J0cHFqVGgzQlh5bnJDUGxnZ2ZHanJwRmVEL0k5?=
 =?utf-8?B?OFZZdjR2cG5MZENWbHBlSVN4NzFjbVRkcWxGakZGL0lwbGI3WHJqelNuVVhk?=
 =?utf-8?B?YnlKM25RNDQyOTR4bVZvcjAzakJrMEtXMUxLN0x3bzFZTHkzMTRlUCtSaXNZ?=
 =?utf-8?B?ZnJ4bi9VQ1RZb3RIWXpwTXhZaDFNbW14Y3lBZS82akxuL2xrOUo2V0oxVkll?=
 =?utf-8?B?RWxDWnRhb29oNXp6aDhDK21OUlAvc3dTNmY5QXlGbm1TRWJSV3hHa1dlQ1Qy?=
 =?utf-8?B?UkhPTHI0S3NFeXZpRXpwbzFaK1d0MUJQTEVWc1NNcGVKeHlKc3puMDE4MjZk?=
 =?utf-8?B?S0hKUkpuQ0lCTzN3ODcyYTdvcXhwUzliRTRTdnE4WDY2dzhvZzU1WXZKUVFK?=
 =?utf-8?B?TG9WdWRmaXBwK2xMTWR1bC8weEpDSzJFeE95MWNyRTVSdjN2bmJhUUhSZ0Fp?=
 =?utf-8?B?cVFBNFNaRm0yOFVzY09xMGV6ZGZqcXNuUTZJcUZmeTk4WVVwRjV0N0d4R1JZ?=
 =?utf-8?B?dm00VmN1V0lPbDdYWjJYVXpYYUJjQ1F5MXYvc1J0RzhtVGVoaG85blg2N2hD?=
 =?utf-8?B?MWdiRFAvVmp2OXkzb3ppbzNhMTZWOXl3VE5hZTdVOUFIaG9MV2d3QnBlL3kr?=
 =?utf-8?B?SWVPcVFSdisxR1FZTkZ4ZWF6Rm1TQWZ2T3B0a1lOUFVOSTlHWXNaZ3VFVlRW?=
 =?utf-8?B?YTFPOUN6dVgyUnJiR2dhZWR1emllWTVpSlFEQmpDYTB0VFhnSld2YzRNaS9n?=
 =?utf-8?B?M1RrOEZNOWxmZkMzaGUyUXBXQUhkY2F6K29leFFKNVZSNlY5SzFYS1RPK24v?=
 =?utf-8?B?ZjJhUngvTjhhbFkyQUtOQUVQVWhxQWlUcTM3eDgwT29CbzllVGNWbHFhVTlx?=
 =?utf-8?B?TVZQZjZScmZ3bVR3b1JQMXNKZFE0K3F2TGRMSWJ5K3JXM3FXenhwaTU4azVD?=
 =?utf-8?B?SFphRExVMXU5UmM3dXJjdk1XUE1nNkVmWENhcUkvNTlvdm1MQTkwK1duemw1?=
 =?utf-8?B?MHY0ZEtpaCtuSE14RktLTytEWmMxRzZzcEtoZmRvMXM4WFZ1T2NlU3I4Skt3?=
 =?utf-8?B?TE8rb0tUQ2JMRll3ZEVWQUFsSUpRb0pCQ2NCSjdsTzc0OW16Rll0YVYvT3Nv?=
 =?utf-8?B?WDNyMlhxbnVkRlVGRmxiNGZRVTAwOUVEbUNMTHhiWityOU1mbG0xZlhXSlJE?=
 =?utf-8?Q?ZJcUlo5uwWbmBlIw/9Krz4pS4?=
X-OriginatorOrg: axentia.se
X-MS-Exchange-CrossTenant-Network-Message-Id: 39ba15a3-a8c2-46b1-3e55-08dc21887beb
X-MS-Exchange-CrossTenant-AuthSource: DU0PR02MB8500.eurprd02.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Jan 2024 11:42:05.9244
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4ee68585-03e1-4785-942a-df9c1871a234
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: vF8uepHpnzvaqyP7GZIQwWfSuUvsqPEUyadyAvM4uqfQDyPiO9yWcnqwrvl5/QXd
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR02MB9396

Hi!

2024-01-30 at 12:18, Naresh Solanki wrote:
> voltage-divider is always an iio consumer at the same time it is
> optionally an iio provider.
> Hence add #io-channel-cells
> Also update example.
> 
> Signed-off-by: Naresh Solanki <naresh.solanki@9elements.com>
> ---
>  .../bindings/iio/afe/voltage-divider.yaml          | 14 +++++++++++++-
>  1 file changed, 13 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/iio/afe/voltage-divider.yaml b/Documentation/devicetree/bindings/iio/afe/voltage-divider.yaml
> index dddf97b50549..09f10d7c4e02 100644
> --- a/Documentation/devicetree/bindings/iio/afe/voltage-divider.yaml
> +++ b/Documentation/devicetree/bindings/iio/afe/voltage-divider.yaml
> @@ -39,6 +39,13 @@ properties:
>      description: |
>        Channel node of a voltage io-channel.
>  
> +  '#io-channel-cells':
> +    description:
> +      In addition to consuming the measurement services of an ADC,

It doesn't really need to be an ADC. Anything with a voltage output
channel works (in theory). But sure, normally it would be an ADC...

> +      the voltage divider can act as an provider of measurement

a provider

Cheers,
Peter

> +      services to other devices.
> +    const: 1
> +
>    output-ohms:
..