Received-SPF: pass (google.com: domain of linux-kernel+bounces-44600-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Tue, 30 Jan 2024 12:25:04 +0000
From: Mark Brown <broonie@kernel.org>
To: Dave Martin <Dave.Martin@arm.com>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>,
	Jackson Cooper-Driver <Jackson.Cooper-Driver@arm.com>,
	linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] arm64/sme: Restore SMCR on exit from suspend
Message-ID: <e48c714e-8ea5-49f1-82d3-8d55dc89ce37@sirena.org.uk>
References: <20240130-arm64-sme-resume-v1-0-0e60ebba18df@kernel.org>
 <20240130-arm64-sme-resume-v1-1-0e60ebba18df@kernel.org>
 <ZbjVNggOxxoQXitV@e133380.arm.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="p2+gdtYAXO19PTGN"
Content-Disposition: inline
In-Reply-To: <ZbjVNggOxxoQXitV@e133380.arm.com>


--p2+gdtYAXO19PTGN
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Jan 30, 2024 at 10:53:42AM +0000, Dave Martin wrote:
> On Tue, Jan 30, 2024 at 12:02:48AM +0000, Mark Brown wrote:
> > The fields in SMCR_EL1 reset to an architecturally UNKNOWN value. Since=
 we
> > do not otherwise manage the traps configured in this register at runtim=
e we
> > need to reconfigure them after a suspend in case nothing else was kind
> > enough to preserve them for us.

> Are any other regs affected? =20

> What about SMPRI_EL1?  That seems to be initialised once and for all in
> cpufeatures, so I'd guess it might be affected.

Ah, yes - we should do that too, thanks.  At present we map SMPRI_EL1
out using EL2 controls and just set it to 0 on init so I keep forgetting
about it, I wrote a few lines of code years ago.

> Also, what about the _EL2 regs if the kernel is resuming at EL2
> (without VHE -- or if SME && !VHE not a thing?)

Yeah, I was somewhat confused about where the EL2 handling was in the
resume path and was hoping that if we weren't just rerunning the initial
setup someone would tell me what I'm missing (which appeared to be what
was happening).

The hardware will always have VHE but we could be running nVHE (eg, for
pKVM) so not using it.

--p2+gdtYAXO19PTGN
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmW46p8ACgkQJNaLcl1U
h9CPZAf/SjeSn+2E+55OUBsJw88y3XY3aDeZ72sklbI+xbiEcUI2PyOHWpSdD6zn
W/f8sGWhy4uypX0tfuHo2ZtjyfHT9csAIXTavEUCN9kCBXrAG4zRpX7suUGKK3+U
H15dWNgSe2wLxdpKoUc783cnUHEM1pecU2kSEAuDPRwHkonlIBlw/VZG9o3D5dhN
rWI1DaGGYK7yFg+Q1Auj4k0jBGl2HoAoNLCCKnika3VFM8/6yEukgGYmNTdP5MRJ
jYsdVqKRZ3gyA8S+pU+L9p6zFd9B9Ongo6BRH81cY8Odt3eUOOhXUfyX+wNFcqy9
2RA3WmgIHfErZcfcD12m1d4mMn0KRw==
=D39O
-----END PGP SIGNATURE-----

--p2+gdtYAXO19PTGN--