Received-SPF: pass (google.com: domain of linux-kernel+bounces-44569-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Date: Tue, 30 Jan 2024 14:03:28 +0200
From: Vladimir Oltean <vladimir.oltean@nxp.com>
To: Simon Horman <horms@kernel.org>
Cc: Breno Leitao <leitao@debian.org>, kuba@kernel.org, davem@davemloft.net,
	pabeni@redhat.com, edumazet@google.com,
	Claudiu Manoil <claudiu.manoil@nxp.com>,
	Alexandre Belloni <alexandre.belloni@bootlin.com>,
	UNGLinuxDriver@microchip.com, dsahern@kernel.org, weiwan@google.com,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	Horatiu Vultur <horatiu.vultur@microchip.com>
Subject: Re: [PATCH net 02/10] net: fill in MODULE_DESCRIPTION()s for ocelot
Message-ID: <20240130120328.rmmbgeywvj6jvqkm@skbuf>
References: <20240125193420.533604-1-leitao@debian.org>
 <20240125193420.533604-3-leitao@debian.org>
 <20240130101134.GG349047@kernel.org>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240130101134.GG349047@kernel.org>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?br4hfnNYn+wOC+emar7wSKajtRiRyKi2OW24Uva95G737pR1Xvq+/MJALBXt?=
 =?us-ascii?Q?9dHHfV9so9K9sJWwpB2piwNZy9s+ChVmRVoEepASHuhXqcetuTafY5afX+Za?=
 =?us-ascii?Q?GE/9MXJ5RbBbs2LLvfa4kxuDhBvRygHS5qtA0lpq9uUHi+Kvv22EO7rPUvQE?=
 =?us-ascii?Q?gq01+0EdyvDb+twUpb7YtCZhfJx9j2PNM3Bp5ZXVBLOJfyJCw/R8wN2tAfye?=
 =?us-ascii?Q?20lAKGFiwgmucVX9K2agV4n4zCCcOMowLlDH97sCAOMeugzoBJlm/D4oZTMG?=
 =?us-ascii?Q?uSwrD4EhtAOD9dafeqtNYmYRrXj7/USrjqbsq1w1oKdbhb1QQlJI8nTLuQ6Q?=
 =?us-ascii?Q?pUW4oMQmpcRJQqFvqwE87nEP/i51NRaLSBBxZHmTjMYwQpTY75NIo35dKi7T?=
 =?us-ascii?Q?Oo2YLSxcMZzqfbf+4jRjGA94zTGh/xgJL/SfZq1dp2cEvRwAToA1nvOwzKyu?=
 =?us-ascii?Q?YkY9avWAoSdfSXPMD/C8OZ9eUb8Zz4d/2nySx1kfJYCpzxIiDQfYye4UoHCY?=
 =?us-ascii?Q?BCJENjRIxCpb7P9UBPTlFHNz0K/AeTz3LJFYpnbqhngyjnQ3Wlc441QsdJpL?=
 =?us-ascii?Q?P9mnz+0oDyPoD0lg1nagRWFvwx60MxptJFJxEDtsUHcgQeNf7TCKDtigake+?=
 =?us-ascii?Q?wXHoGobSIoa4tvRv3pMjFYu+DTHSnBHETITS1JXSFO8N2gJ82itnA5Z2rBSN?=
 =?us-ascii?Q?fqS5MgatmFOO7+wdMJuRH9MtdJiJAQDGzCH/Pro0MY/xM+qSh6YgaiQw2jqJ?=
 =?us-ascii?Q?3UYYBRPbHUiAaG4WT8yriSHTTHTFhlt/gj+hnQOSo/LkXFXbOuQD4fxj1p/0?=
 =?us-ascii?Q?vRTCWj5wd6mtTgt4DQZAaLKZGA0Y+ZnzNJFw5OwZEJE3vTp2QNkYpRyWtiCr?=
 =?us-ascii?Q?lvDhC+socgRnXqjAbD1UPdprRXlyuuw3oziX9e+OOqLBXSH9cc4BHYwrppmP?=
 =?us-ascii?Q?2jxA/XPn8cUFMGn1H+9P3rgi2IBdrPu7yWm+qQky1HJY0lLFqU7zyvNngYNf?=
 =?us-ascii?Q?NefGFIUHMOiEKt5qwi2jKx2xMzIS0mKQ+RF5M9IRC+58cwadHGusrLDZDxsr?=
 =?us-ascii?Q?yBWbZzSFmWrqoW66KKvFu+Yo3qVgvVhGi+nfMw9bFNwlCOrymIoy5BxsrD/g?=
 =?us-ascii?Q?wNYqZl3LdGcEJAGLzAhKPziASD5f0O39gUOtHwOgNps79K3gr4lJSUA3Id9p?=
 =?us-ascii?Q?CM2fLDUkGnd/oM2r1qGdNa0glskIv2CpvpV6bGVD4mRqo3Hz1wZhqTyQTgz8?=
 =?us-ascii?Q?NqQhyatBZC1RDBz/iWtZbYvy4VELvCefQ90XNpuS594Uv/7QZBVtnRzJ4H/f?=
 =?us-ascii?Q?VlwY2b70qgoMJu9A5T6uIC0GXva28/HBI6ewnPgHF83xnthtTgjcw+JcrY5c?=
 =?us-ascii?Q?5zR6uHC2YeIRfdfg9dTzRTis6cFgYNXupP9yFv2pquoCp9uA7g6cjv0B726P?=
 =?us-ascii?Q?UlUVTy8dHo+2Indf9bX+inj4+0gj8t7+LJURdkrbVJldAW4ky7cr3ckYqCaX?=
 =?us-ascii?Q?ZwFccn69NHpOIfUuZyTpzOfG7aUf5OxhIH7o2ShZNvl74QKs3adVwweWNs1E?=
 =?us-ascii?Q?XnD/Rgnq4zNIpjLv+kVcnrGdcIcTaypU3B7355geR7MDMKu1lCdutQrH/RbC?=
 =?us-ascii?Q?mg=3D=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b3891d5f-cd9e-4a76-4bc4-08dc218b7a84
X-MS-Exchange-CrossTenant-AuthSource: DBAPR04MB7368.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Jan 2024 12:03:32.0858
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: WMP3qYoYvp0dVUdOFlL5LUGtmLqH4/NNYlSPduEvesnMfiQnsiwKConHPx0EvERE3C8lJld91dTAx4nttMGdAQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8294

On Tue, Jan 30, 2024 at 10:11:34AM +0000, Simon Horman wrote:
> On Thu, Jan 25, 2024 at 11:34:12AM -0800, Breno Leitao wrote:
> > W=1 builds now warn if module is built without a MODULE_DESCRIPTION().
> > Add descriptions to the Ocelot SoCs (VSC7514) helpers driver.
> > 
> > Signed-off-by: Breno Leitao <leitao@debian.org>
> > Reviewed-by: Horatiu Vultur <horatiu.vultur@microchip.com>
> > ---
> >  drivers/net/ethernet/mscc/ocelot.c | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/drivers/net/ethernet/mscc/ocelot.c b/drivers/net/ethernet/mscc/ocelot.c
> > index 56ccbd4c37fe..2194f2a7ab27 100644
> > --- a/drivers/net/ethernet/mscc/ocelot.c
> > +++ b/drivers/net/ethernet/mscc/ocelot.c
> > @@ -3078,4 +3078,5 @@ void ocelot_deinit_port(struct ocelot *ocelot, int port)
> >  }
> >  EXPORT_SYMBOL(ocelot_deinit_port);
> >  
> > +MODULE_DESCRIPTION("Microsemi Ocelot (VSC7514) Switch driver");
> 
> Hi Breno,
> 
> I really appreciate your work in this area.
> 
> WRT this patch, I could well be wrong, but I think this code is also used
> by Felix (VSC9959). If so the description might want tweaking.
> 
> Vladimir, can you shed some light on this?

Thanks for pointing this out, Simon, you are correct. This would be better:

MODULE_DESCRIPTION("Microsemi Ocelot switch family library");

Also, the commit prefix for this driver should be "net: mscc: ocelot:
fill in MODULE_DESCRIPTION()".