Received: by 2002:a05:7412:d1aa:b0:fc:a2b0:25d7 with SMTP id ba42csp979198rdb; Tue, 30 Jan 2024 04:42:25 -0800 (PST) X-Google-Smtp-Source: AGHT+IHks9UWGzJ+uXzf4/5hOGUyrFUwbJIOvk60hs7d12EHCnkPJ23F+4oq5Khif8mOGgKfNXaM X-Received: by 2002:a17:906:c1ca:b0:a35:8419:4bba with SMTP id bw10-20020a170906c1ca00b00a3584194bbamr5443537ejb.7.1706618545023; Tue, 30 Jan 2024 04:42:25 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1706618545; cv=pass; d=google.com; s=arc-20160816; b=r7WyIvkXbk6IWly2WalohXVYsW/jlrlauvbSzCUO6yakPQu8JgQ2Ju+qd8r2XZicWo l2QX3+PeuKLBb6VIXaTRIaeiGAnqFlrodhDdJU4IVa7H960PJKUtnqTVP3S+82O5XnGE dq3FOuyzm0kAQMHG4Hd2DGBK8jKzPUvI/iazyshTL1TgF6icQZWvKEgdvP/u0SauYDkH 9Yv09jccgswwTr5pM1eW3jk1fWYZIlWfZcWP7vKoAXBfsf+waQ7orfXrTm+O8KCpwza1 je+z1MvKj/6PliAD9jUtrLcL+aMI95qVB/7dWU0PhDBZ0bJPAWuwvifuWSQdpOtXYc3c XWbQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:date:message-id; bh=WdB5Mm8q8xrW4YUSCVgijZszEgJql9mjVFVD4HKPmvI=; fh=VVn1or143ocJn81UN5C70YFisJoYbLqtg4Us8PNvf4I=; b=M/8SO9z5hg3dINNXnBRYyegyv4AoTUkkOoRy23F0mDf+R3bHludkdSFwa1ttHq4Y0H l1vZrS2W6mvZc+1io9MmtQsizUA3UM/PhkQrQLjWNq99sBmhkDtOE5k3nfNn4cK0ej78 AqJxxeN1MI9DS3qXVpSI4n84wS+TBqUA/1MHXdAvMPCtMzigeVyAvcDgWpi4Vg9cbMil NOClO3o4Z407YLDOmybZ6vPDSV7UPB9LnFHaE98GTbE/8kkuFGvDRp7ErA6+skAoHdcz bztCvHbbdLmXrdq3Jqyj3GzfZuuW4ME0uY04OsMP+3kUyxjX/TGR7fUhH5wQeZZPRTPF Z2Bg== ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1 spf=pass spfdomain=arm.com dmarc=pass fromdomain=arm.com); spf=pass (google.com: domain of linux-kernel+bounces-44620-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-44620-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id ch20-20020a170906c2d400b00a3554bb5d37si3194437ejb.958.2024.01.30.04.42.24 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Jan 2024 04:42:25 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-44620-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; arc=pass (i=1 spf=pass spfdomain=arm.com dmarc=pass fromdomain=arm.com); spf=pass (google.com: domain of linux-kernel+bounces-44620-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-44620-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 9D0241F22081 for ; Tue, 30 Jan 2024 12:42:24 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 029636A32C; Tue, 30 Jan 2024 12:40:23 +0000 (UTC) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id ACC466A028; Tue, 30 Jan 2024 12:40:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706618422; cv=none; b=Lybnd6d/YW/rCpF0EhzQCsr67GtTXuljPEmNEAAGQYGCF9JIS9QTBcE6+ExE5dkI2YcULNv89deGrN292ipu9cHoYaG2OFncxmQpSnHFlEh1CVHEn1Dx0MNl89dYhqNfxt/oq1lf6ZQzMsHx4bnmzcc/fzg44nI/0+L1DEqGfTs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706618422; c=relaxed/simple; bh=+x2GutARnczCwp8oHhn8Qn8q8WfRfeqIQxjDzAXlzfg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=MEIWnJweYPuOmA9CUCL163C5b1SJILFzGvYOHxeOof74KjZR5lIJtq0xJmewjBp/6buurFARK3wSovarq2y7OxXrtflfJbvvAvnWZFwhrcjuVVX30k4jPXpuTXkqmQPwZ0P1PDYl+//86Yhdfa6bWHN+ZjVvxhx1ToV47D8BCZA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 88463DA7; Tue, 30 Jan 2024 04:41:02 -0800 (PST) Received: from [10.1.197.1] (ewhatever.cambridge.arm.com [10.1.197.1]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id E2EEF3F762; Tue, 30 Jan 2024 04:40:13 -0800 (PST) Message-ID: <69ff07d9-85e2-4cef-8db5-612287ee1638@arm.com> Date: Tue, 30 Jan 2024 12:40:12 +0000 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 07/10] coresight-tpdm: Add pattern registers support for CMB Content-Language: en-US To: Tao Zhang , Mathieu Poirier , Alexander Shishkin , Konrad Dybcio , Mike Leach , Rob Herring , Krzysztof Kozlowski Cc: Jinlong Mao , Leo Yan , Greg Kroah-Hartman , coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Tingwei Zhang , Yuanfang Zhang , Trilok Soni , Song Chai , linux-arm-msm@vger.kernel.org, andersson@kernel.org References: <1706605366-31705-1-git-send-email-quic_taozha@quicinc.com> <1706605366-31705-8-git-send-email-quic_taozha@quicinc.com> From: Suzuki K Poulose In-Reply-To: <1706605366-31705-8-git-send-email-quic_taozha@quicinc.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 30/01/2024 09:02, Tao Zhang wrote: > Timestamps are requested if the monitor’s CMB data set unit input > data matches the value in the Monitor CMB timestamp pattern and mask > registers (M_CMB_TPR and M_CMB_TPMR) when CMB timestamp enabled > via the timestamp insertion enable register bit(CMB_TIER.PATT_TSENAB). > The pattern match trigger output is achieved via setting values into > the CMB trigger pattern and mask registers (CMB_XPR and CMB_XPMR). > After configuring a pattern through these registers, the TPDM subunit > will assert an output trigger every time it receives new input data > that matches the configured pattern value. Values in a given bit > number of the mask register correspond to the same bit number in > the corresponding pattern register. > > Reviewed-by: James Clark > Signed-off-by: Tao Zhang > Signed-off-by: Jinlong Mao > --- > .../testing/sysfs-bus-coresight-devices-tpdm | 30 ++++++ > drivers/hwtracing/coresight/coresight-tpdm.c | 96 ++++++++++++++++++- > drivers/hwtracing/coresight/coresight-tpdm.h | 39 ++++++++ > 3 files changed, 164 insertions(+), 1 deletion(-) > > diff --git a/Documentation/ABI/testing/sysfs-bus-coresight-devices-tpdm b/Documentation/ABI/testing/sysfs-bus-coresight-devices-tpdm > index 6dfb18d6d64a..b6cf050861ed 100644 > --- a/Documentation/ABI/testing/sysfs-bus-coresight-devices-tpdm > +++ b/Documentation/ABI/testing/sysfs-bus-coresight-devices-tpdm > @@ -184,3 +184,33 @@ Description: (Write) Set the data collection mode of CMB tpdm. Continuous > Accepts only one of the 2 values - 0 or 1. > 0 : Continuous CMB collection mode. > 1 : Trace-on-change CMB collection mode. > + > +What: /sys/bus/coresight/devices//cmb_trig_patt/xpr[0:1] > +Date: January 2024 > +KernelVersion 6.9 > +Contact: Jinlong Mao (QUIC) , Tao Zhang (QUIC) > +Description: > + (RW) Set/Get the value of the trigger pattern for the CMB > + subunit TPDM. > + > +What: /sys/bus/coresight/devices//cmb_trig_patt/xpmr[0:1] > +Date: January 2024 > +KernelVersion 6.9 > +Contact: Jinlong Mao (QUIC) , Tao Zhang (QUIC) > +Description: > + (RW) Set/Get the mask of the trigger pattern for the CMB > + subunit TPDM. > + > +What: /sys/bus/coresight/devices//dsb_patt/tpr[0:1] > +Date: January 2024 > +KernelVersion 6.9 > +Contact: Jinlong Mao (QUIC) , Tao Zhang (QUIC) > +Description: > + (RW) Set/Get the value of the pattern for the CMB subunit TPDM. > + > +What: /sys/bus/coresight/devices//dsb_patt/tpmr[0:1] > +Date: January 2024 > +KernelVersion 6.9 > +Contact: Jinlong Mao (QUIC) , Tao Zhang (QUIC) > +Description: > + (RW) Set/Get the mask of the pattern for the CMB subunit TPDM. > diff --git a/drivers/hwtracing/coresight/coresight-tpdm.c b/drivers/hwtracing/coresight/coresight-tpdm.c > index b20071460375..07587287d9fa 100644 > --- a/drivers/hwtracing/coresight/coresight-tpdm.c > +++ b/drivers/hwtracing/coresight/coresight-tpdm.c > @@ -66,6 +66,26 @@ static ssize_t tpdm_simple_dataset_show(struct device *dev, > return -EINVAL; > return sysfs_emit(buf, "0x%x\n", > drvdata->dsb->msr[tpdm_attr->idx]); > + case CMB_TRIG_PATT: > + if (tpdm_attr->idx >= TPDM_CMB_MAX_PATT) > + return -EINVAL; > + return sysfs_emit(buf, "0x%x\n", > + drvdata->cmb->trig_patt[tpdm_attr->idx]); > + case CMB_TRIG_PATT_MASK: > + if (tpdm_attr->idx >= TPDM_CMB_MAX_PATT) > + return -EINVAL; > + return sysfs_emit(buf, "0x%x\n", > + drvdata->cmb->trig_patt_mask[tpdm_attr->idx]); > + case CMB_PATT: > + if (tpdm_attr->idx >= TPDM_CMB_MAX_PATT) > + return -EINVAL; > + return sysfs_emit(buf, "0x%x\n", > + drvdata->cmb->patt_val[tpdm_attr->idx]); > + case CMB_PATT_MASK: > + if (tpdm_attr->idx >= TPDM_CMB_MAX_PATT) > + return -EINVAL; > + return sysfs_emit(buf, "0x%x\n", > + drvdata->cmb->patt_mask[tpdm_attr->idx]); > } > return -EINVAL; > } > @@ -118,6 +138,30 @@ static ssize_t tpdm_simple_dataset_store(struct device *dev, > ret = size; > } > break; > + case CMB_TRIG_PATT: > + if (tpdm_attr->idx < TPDM_CMB_MAX_PATT) { > + drvdata->cmb->trig_patt[tpdm_attr->idx] = val; > + ret = size; > + } > + break; > + case CMB_TRIG_PATT_MASK: > + if (tpdm_attr->idx < TPDM_CMB_MAX_PATT) { > + drvdata->cmb->trig_patt_mask[tpdm_attr->idx] = val; > + ret = size; > + } > + break; > + case CMB_PATT: > + if (tpdm_attr->idx < TPDM_CMB_MAX_PATT) { > + drvdata->cmb->patt_val[tpdm_attr->idx] = val; > + ret = size; > + } > + break; > + case CMB_PATT_MASK: > + if (tpdm_attr->idx < TPDM_CMB_MAX_PATT) { > + drvdata->cmb->patt_mask[tpdm_attr->idx] = val; > + ret = size; > + } > + break; > default: > break; > } > @@ -280,12 +324,32 @@ static void tpdm_enable_dsb(struct tpdm_drvdata *drvdata) > > static void tpdm_enable_cmb(struct tpdm_drvdata *drvdata) > { > - u32 val; > + u32 val, i; > > if (!tpdm_has_cmb_dataset(drvdata)) > return; > > + /* Configure pattern registers */ > + for (i = 0; i < TPDM_CMB_MAX_PATT; i++) { > + writel_relaxed(drvdata->cmb->patt_val[i], > + drvdata->base + TPDM_CMB_TPR(i)); > + writel_relaxed(drvdata->cmb->patt_mask[i], > + drvdata->base + TPDM_CMB_TPMR(i)); > + writel_relaxed(drvdata->cmb->trig_patt[i], > + drvdata->base + TPDM_CMB_XPR(i)); > + writel_relaxed(drvdata->cmb->trig_patt_mask[i], > + drvdata->base + TPDM_CMB_XPMR(i)); > + } > + > val = readl_relaxed(drvdata->base + TPDM_CMB_CR); > + /* > + * Set to 0 for continuous CMB collection mode, > + * 1 for trace-on-change CMB collection mode. > + */ > + if (drvdata->cmb->trace_mode) > + val |= TPDM_CMB_CR_MODE; > + else > + val &= ~TPDM_CMB_CR_MODE; > /* Set the enable bit of CMB control register to 1 */ > val |= TPDM_CMB_CR_ENA; > writel_relaxed(val, drvdata->base + TPDM_CMB_CR); > @@ -887,6 +951,22 @@ static struct attribute *tpdm_dsb_msr_attrs[] = { > NULL, > }; > > +static struct attribute *tpdm_cmb_trig_patt_attrs[] = { > + CMB_TRIG_PATT_ATTR(0), > + CMB_TRIG_PATT_ATTR(1), > + CMB_TRIG_PATT_MASK_ATTR(0), > + CMB_TRIG_PATT_MASK_ATTR(1), > + NULL, > +}; > + > +static struct attribute *tpdm_cmb_patt_attrs[] = { > + CMB_PATT_ATTR(0), > + CMB_PATT_ATTR(1), > + CMB_PATT_MASK_ATTR(0), > + CMB_PATT_MASK_ATTR(1), > + NULL, > +}; > + > static struct attribute *tpdm_dsb_attrs[] = { > &dev_attr_dsb_mode.attr, > &dev_attr_dsb_trig_ts.attr, > @@ -933,6 +1013,18 @@ static struct attribute_group tpdm_cmb_attr_grp = { > .is_visible = tpdm_cmb_is_visible, > }; > > +static struct attribute_group tpdm_cmb_trig_patt_grp = { > + .attrs = tpdm_cmb_trig_patt_attrs, > + .is_visible = tpdm_cmb_is_visible, > + .name = "cmb_trig_patt", > +}; > + > +static struct attribute_group tpdm_cmb_patt_grp = { > + .attrs = tpdm_cmb_patt_attrs, > + .is_visible = tpdm_cmb_is_visible, > + .name = "cmb_patt", > +}; > + > static const struct attribute_group *tpdm_attr_grps[] = { > &tpdm_attr_grp, > &tpdm_dsb_attr_grp, > @@ -941,6 +1033,8 @@ static const struct attribute_group *tpdm_attr_grps[] = { > &tpdm_dsb_patt_grp, > &tpdm_dsb_msr_grp, > &tpdm_cmb_attr_grp, > + &tpdm_cmb_trig_patt_grp, > + &tpdm_cmb_patt_grp, > NULL, > }; > > diff --git a/drivers/hwtracing/coresight/coresight-tpdm.h b/drivers/hwtracing/coresight/coresight-tpdm.h > index 2af92c270ed1..8cb8a9b35384 100644 > --- a/drivers/hwtracing/coresight/coresight-tpdm.h > +++ b/drivers/hwtracing/coresight/coresight-tpdm.h > @@ -11,12 +11,23 @@ > > /* CMB Subunit Registers */ > #define TPDM_CMB_CR (0xA00) > +/*CMB subunit timestamp pattern registers*/ > +#define TPDM_CMB_TPR(n) (0xA08 + (n * 4)) > +/*CMB subunit timestamp pattern mask registers*/ > +#define TPDM_CMB_TPMR(n) (0xA10 + (n * 4)) > +/*CMB subunit trigger pattern registers*/ > +#define TPDM_CMB_XPR(n) (0xA18 + (n * 4)) > +/*CMB subunit trigger pattern mask registers*/ minor nit: Leave a space after/before '/*' & '*/' Suzuki