Received-SPF: pass (google.com: domain of linux-kernel+bounces-44703-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Tue, 30 Jan 2024 14:34:00 +0100
From: Andrew Lunn <andrew@lunn.ch>
To: Bastien Curutchet <bastien.curutchet@bootlin.com>
Cc: "David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Richard Cochran <richardcochran@gmail.com>,
	Heiner Kallweit <hkallweit1@gmail.com>,
	Russell King <linux@armlinux.org.uk>, netdev@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
	Herve Codina <herve.codina@bootlin.com>
Subject: Re: [PATCH 1/2] dt-bindings: net: Add TI DP83640
Message-ID: <dc81a307-3541-47e2-9c72-d661e76889bf@lunn.ch>
References: <20240130085935.33722-1-bastien.curutchet@bootlin.com>
 <20240130085935.33722-2-bastien.curutchet@bootlin.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240130085935.33722-2-bastien.curutchet@bootlin.com>

> +  ti,led-config:
> +    $ref: /schemas/types.yaml#/definitions/uint32
> +    enum: [1, 2, 3]
> +    description: |
> +      If present, configures the LED Mode (values defined in
> +      dt-bindings/net/ti-dp83640.h).
> +      LED configuration can also be strapped. If the strap pin is not set
> +      correctly or not set at all then this can be used to configure it.
> +       - 1     = Mode 1
> +        LED_LINK = ON for Good Link, OFF for No Link
> +        LED_SPEED = ON in 100 Mb/s, OFF in 10 Mb/s
> +        LED_ACT = ON for Activity, OFF for No Activity
> +       - 2     = Mode 2
> +        LED_LINK = ON for Good Link, BLINK for Activity
> +        LED_SPEED = ON in 100 Mb/s, OFF in 10 Mb/s
> +        LED_ACT = ON for Collision, OFF for No Collision
> +       - 3     = Mode 3
> +        LED_LINK = ON for Good Link, BLINK for Activity
> +        LED_SPEED = ON in 100 Mb/s, OFF in 10 Mb/s
> +        LED_ACT = ON for Full Duplex, OFF for Half Duplex
> +       - unset = Configured by straps

Please look at have the Marvell PHY driver supports LEDs via
/sys/class/leds. Now we have a generic way to supports LEDs, DT
properties like this will not be accepted.

> +
> +  ti,phy-control-frames:
> +    $ref: /schemas/types.yaml#/definitions/uint32
> +    enum: [0, 1]
> +    description: |
> +      If present, enables or disables the PHY control frames.
> +      PHY Control Frames support can also be strapped. If the strap pin is not
> +      set correctly or not set at all then this can be used to configure it.
> +       - 0     = PHY Control Frames disabled
> +       - 1     = PHY Control Frames enabled
> +       - unset = Configured by straps

What is a control frame?

> +
> +  ti,energy-detect-en:
> +    $ref: /schemas/types.yaml#/definitions/flag
> +    description: |
> +      If present, Energy Detect Mode is enabled. If not present, Energy Detect
> +      Mode is disabled. This feature can not be strapped.

Please use the phy tunable ETHTOOL_PHY_EDPD. There are a few examples
you can copy.

    Andrew