Received-SPF: pass (google.com: domain of linux-kernel+bounces-44708-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Precedence: bulk
MIME-Version: 1.0
References: <20240125231840.1647951-1-irogers@google.com> <CAEf4BzamUW+O35hfj-SctPo0Z-oZk5u-96fvD0cFPDZTwFyiMg@mail.gmail.com>
In-Reply-To: <CAEf4BzamUW+O35hfj-SctPo0Z-oZk5u-96fvD0cFPDZTwFyiMg@mail.gmail.com>
From: Ian Rogers <irogers@google.com>
Date: Tue, 30 Jan 2024 05:41:47 -0800
Message-ID: <CAP-5=fWd3U4VTU7Quj+EjdU8F_o3VwprUz18PeAGfphgUS7vPg@mail.gmail.com>
Subject: Re: [PATCH v3] libbpf: Add some details for BTF parsing failures
To: Andrii Nakryiko <andrii.nakryiko@gmail.com>
Cc: Alan Maguire <alan.maguire@oracle.com>, Alexei Starovoitov <ast@kernel.org>, 
	Daniel Borkmann <daniel@iogearbox.net>, Andrii Nakryiko <andrii@kernel.org>, 
	Martin KaFai Lau <martin.lau@linux.dev>, Song Liu <song@kernel.org>, 
	Yonghong Song <yonghong.song@linux.dev>, John Fastabend <john.fastabend@gmail.com>, 
	KP Singh <kpsingh@kernel.org>, Stanislav Fomichev <sdf@google.com>, Hao Luo <haoluo@google.com>, 
	Jiri Olsa <jolsa@kernel.org>, bpf@vger.kernel.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Mon, Jan 29, 2024 at 4:43=E2=80=AFPM Andrii Nakryiko
<andrii.nakryiko@gmail.com> wrote:
>
> On Thu, Jan 25, 2024 at 3:18=E2=80=AFPM Ian Rogers <irogers@google.com> w=
rote:
> >
> > As CONFIG_DEBUG_INFO_BTF is default off the existing "failed to find
> > valid kernel BTF" message makes diagnosing the kernel build issue some
> > what cryptic. Add a little more detail with the hope of helping users.
> >
> > Before:
> > ```
> > libbpf: failed to find valid kernel BTF
> > libbpf: Error loading vmlinux BTF: -3
> > ```
> >
> > After not accessible:
> > ```
> > libbpf: access to canonical vmlinux (/sys/kernel/btf/vmlinux) to load B=
TF failed: No such file or directory
> > libbpf: was CONFIG_DEBUG_INFO_BTF enabled?
> > libbpf: failed to find valid kernel BTF
> > libbpf: Error loading vmlinux BTF: -3
> > ```
> >
> > After not readable:
> > ```
> > libbpf: unable to read canonical vmlinux (/sys/kernel/btf/vmlinux): Per=
mission denied
> > libbpf: failed to find valid kernel BTF
> > libbpf: Error loading vmlinux BTF: -3
> > ```
> >
> > Closes: https://lore.kernel.org/bpf/CAP-5=3DfU+DN_+Y=3DY4gtELUsJxKNDDCO=
vJzPHvjUVaUoeFAzNnig@mail.gmail.com/
> > Signed-off-by: Ian Rogers <irogers@google.com>
> >
> > ---
> > v3. Try to address review comments from Andrii Nakryiko.
>
> I did some further simplifications and clean ups while applying.
>
> I dropped an extra faccessat(R_OK) check for /sys/kernel/btf/vmlinux
> and instead if F_OK passes, just go ahead and try to parse
> /sys/kernel/btf/vmlinux. If we have no access, we should get -EPERM or
> -EACCESS (I didn't check which), otherwise we'll either parse or won't
> find any BTF, both are errors. If /sys/kernel/btf/vmlinux exists,
> there seems to be little point nowadays to try fallback locations,
> kernel clearly is modern enough to generate /sys/kernel/btf/vmlinux,
> so we just bail out with error.
>
> Please check the landed commit in bpf-next and let me know if it
> doesn't cover your use case properly.

It does, thanks Andrii!

Ian

> > ---
> >  tools/lib/bpf/btf.c | 35 +++++++++++++++++++++++++++--------
> >  1 file changed, 27 insertions(+), 8 deletions(-)
> >
> > diff --git a/tools/lib/bpf/btf.c b/tools/lib/bpf/btf.c
> > index ec92b87cae01..45983f42aba9 100644
> > --- a/tools/lib/bpf/btf.c
> > +++ b/tools/lib/bpf/btf.c
> > @@ -4932,10 +4932,9 @@ static int btf_dedup_remap_types(struct btf_dedu=
p *d)
> >   */
> >  struct btf *btf__load_vmlinux_btf(void)
> >  {
> > +       const char *canonical_vmlinux =3D "/sys/kernel/btf/vmlinux";
> > +       /* fall back locations, trying to find vmlinux on disk */
> >         const char *locations[] =3D {
> > -               /* try canonical vmlinux BTF through sysfs first */
> > -               "/sys/kernel/btf/vmlinux",
> > -               /* fall back to trying to find vmlinux on disk otherwis=
e */
> >                 "/boot/vmlinux-%1$s",
> >                 "/lib/modules/%1$s/vmlinux-%1$s",
> >                 "/lib/modules/%1$s/build/vmlinux",
> > @@ -4946,14 +4945,34 @@ struct btf *btf__load_vmlinux_btf(void)
> >         };
> >         char path[PATH_MAX + 1];
> >         struct utsname buf;
> > -       struct btf *btf;
> > +       struct btf *btf =3D NULL;
> >         int i, err;
> >
> > -       uname(&buf);
> > +       /* is canonical sysfs location accessible? */
> > +       err =3D faccessat(AT_FDCWD, canonical_vmlinux, F_OK, AT_EACCESS=
);
> > +       if (err) {
> > +               pr_warn("access to canonical vmlinux (%s) to load BTF f=
ailed: %s\n",
> > +                       canonical_vmlinux, strerror(errno));
> > +               pr_warn("was CONFIG_DEBUG_INFO_BTF enabled?\n");
> > +       } else {
> > +               err =3D faccessat(AT_FDCWD, canonical_vmlinux, R_OK, AT=
_EACCESS);
> > +               if (err) {
> > +                       pr_warn("unable to read canonical vmlinux (%s):=
 %s\n",
> > +                               canonical_vmlinux, strerror(errno));
> > +               }
> > +       }
> > +       if (!err) {
> > +               /* load canonical and return any parsing failures */
> > +               btf =3D btf__parse(canonical_vmlinux, NULL);
> > +               err =3D libbpf_get_error(btf);
> > +               pr_debug("loading kernel BTF '%s': %d\n", canonical_vml=
inux, err);
> > +               return btf;
> > +       }
> >
> > +       /* try fallback locations */
> > +       uname(&buf);
> >         for (i =3D 0; i < ARRAY_SIZE(locations); i++) {
> >                 snprintf(path, PATH_MAX, locations[i], buf.release);
> > -
> >                 if (faccessat(AT_FDCWD, path, R_OK, AT_EACCESS))
> >                         continue;
> >
> > @@ -4965,9 +4984,9 @@ struct btf *btf__load_vmlinux_btf(void)
> >
> >                 return btf;
> >         }
> > -
> >         pr_warn("failed to find valid kernel BTF\n");
> > -       return libbpf_err_ptr(-ESRCH);
> > +       /* return the last error or ESRCH if no fallback locations were=
 found */
> > +       return btf ?: libbpf_err_ptr(-ESRCH);
> >  }
> >
> >  struct btf *libbpf_find_kernel_btf(void) __attribute__((alias("btf__lo=
ad_vmlinux_btf")));
> > --
> > 2.43.0.429.g432eaa2c6b-goog
> >