Received: by 2002:a05:7412:d1aa:b0:fc:a2b0:25d7 with SMTP id ba42csp1017496rdb; Tue, 30 Jan 2024 05:49:52 -0800 (PST) X-Google-Smtp-Source: AGHT+IFx48qAVzvbwjoU+xoslcJkiiEu6fOiQ2vou06ALvtQDzEzZkO9S0hF62Qd83tlTe3Fgjqu X-Received: by 2002:a05:6a21:3502:b0:199:e4ab:691c with SMTP id zc2-20020a056a21350200b00199e4ab691cmr7080853pzb.8.1706622592271; Tue, 30 Jan 2024 05:49:52 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1706622592; cv=pass; d=google.com; s=arc-20160816; b=wvQuxwGn6r0MS8LFwDyYq32dXyzIN0swi+IfGwAKLpQwxZBM2K9c5JnjCBGO4EcxFH mmp+7x6xmPnKOfhtyVSQ4VeUmZ7sXOItFnaJgii1WAdVNd41zsgPBeZlJi/bxJvV/z70 yoJ1lEaomPsyzve8yzcDSRBQgH8mNU6nwFN54E/m2PaZF/For5W8B6cmRJq0e8uNwnfy zOclxa2DFvfoLjg0xOUxznJ4iNWw3lI2bU+ORTjdagwPrmyjCvG4B6K+BeyVQz8b1Oqw TXADINSTOJHZ5HGL4OEWaLZlIIo/x9N5RDm7pkYOtJ4dwrI/h61iFfMQaFEcUuJ0feG8 pvhA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=vd//V4XYtNdO2bVzPimQHhpuzy1TW7+TDVfUFwizcWs=; fh=3sbwQQlgkd3sAYPIXp1nzCoghJpbsNBjbjFjXieOdqU=; b=aDDAhStCRfR6YWTrGUlDciG9IIGSQIfAM6gOJ07daPfpkWZToipFDU6oEJeabk3lF2 /z+mOdnTBc+sgInezWavx2s02JdxD70KA76U+Z4xAmObKoC5lDkdoPK+zjWVPquTqI1C 0Cn/JSL4DbC7A/I7YQHRhXps+iqCl3hZ8qyZclkjr25xSuj/yg9GOmrrVNyopfFTUvAW wuLXgkhZ939vASzV3WGbl+pcIUnZv/Yx5iNSDYo4J9ituuXK6J9iV8DVCQ3ZuiC4oXmi yG5d7FYcrH5P9OLPuqH9PH+ww+6nphz67QgSgIQkGUZNb57esmNi95fvSlEgA/Sr+b9v gU5A== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=0EyaNAy3; arc=pass (i=1 spf=pass spfdomain=lunn.ch dkim=pass dkdomain=lunn.ch dmarc=pass fromdomain=lunn.ch); spf=pass (google.com: domain of linux-kernel+bounces-44716-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-44716-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id j11-20020a056a00234b00b006ddc328a561si47965pfj.362.2024.01.30.05.49.52 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Jan 2024 05:49:52 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-44716-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=0EyaNAy3; arc=pass (i=1 spf=pass spfdomain=lunn.ch dkim=pass dkdomain=lunn.ch dmarc=pass fromdomain=lunn.ch); spf=pass (google.com: domain of linux-kernel+bounces-44716-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-44716-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id C550A28B544 for ; Tue, 30 Jan 2024 13:48:53 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 33E9B6D1D7; Tue, 30 Jan 2024 13:48:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="0EyaNAy3" Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A37376D1B5; Tue, 30 Jan 2024 13:48:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=156.67.10.101 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706622523; cv=none; b=O6BNzHKvnPKm5ffaXIWSHgl2tmd3cWujsPqK4pIfhtqF69W9C8sDFu8BDzJgVbwolNILylywzCgrADwC+nwAPgMQ96vG9p5uxU746nJwCX4Tf4i6FsNpIJeSMhQeIDww9IJ3pJxF0indGyG6HyhA1TLCeMOdmPmEsd4RukkdF+8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706622523; c=relaxed/simple; bh=LX2Fic2UMf7KjX8p2W2+sSCjFDYmcP3OxJ1aZl3nnnY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=M0rAoKME5hVKoCoJirZswaCkp01Ozw8hfJxZQcqUxIcA20jIEmg30BchSq4qRMuJhP+j7I0drH8qa/0jz+rx60rYNgQRKkyL5k2cg2wpyX7Ahei8bqA262dBsWzJatpL3tPWdPPE9IuejT/S0qhxAQ6AJXX+lLIXpLjpX13AgSc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch; spf=pass smtp.mailfrom=lunn.ch; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b=0EyaNAy3; arc=none smtp.client-ip=156.67.10.101 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lunn.ch DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=vd//V4XYtNdO2bVzPimQHhpuzy1TW7+TDVfUFwizcWs=; b=0EyaNAy3PN3WNXOZkObkKOnf7m l+LjuYFxeSmhk3U5RzxxGCO0Ob/JJ5phV2UidjoFY6TDp/w1VAOw5GU0j/6w7dWlLI65z+naIqFmw nV0n25zGIlwSGH0LXks3/JplBRPXEwI4GX7pzoZ7e+w37JMlEZfKniz/sYw3x4tI8BxM=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1rUoTM-006UoM-Ti; Tue, 30 Jan 2024 14:48:20 +0100 Date: Tue, 30 Jan 2024 14:48:20 +0100 From: Andrew Lunn To: Jisheng Zhang Cc: Petr Tesarik , Alexandre Torgue , Jose Abreu , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Maxime Coquelin , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , "open list:STMMAC ETHERNET DRIVER" , "moderated list:ARM/STM32 ARCHITECTURE" , "moderated list:ARM/STM32 ARCHITECTURE" , open list , "open list:ARM/Allwinner sunXi SoC support" , Marc Haber , Florian Fainelli , stable@vger.kernel.org Subject: Re: [PATCH net v2] net: stmmac: protect updates of 64-bit statistics counters Message-ID: References: <20240128193529.24677-1-petr@tesarici.cz> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: > PS: when I sent the above "net: stmmac: use per-queue 64 bit statistics > where necessary", I had an impression: there are too much statistics in > stmmac driver, I didn't see so many statistics in other eth drivers, is > it possible to remove some useless or not that useful statistic members? These counters might be considered ABI. We don't want to cause regressions in somebodies testing, or even billing scripts because we remove a counter which somebody is using. Andrew