Received-SPF: pass (google.com: domain of linux-kernel+bounces-44710-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Message-ID: <f3bd1cd4-5f19-4710-a016-85d38dff11f1@wolfvision.net>
Date: Tue, 30 Jan 2024 14:43:04 +0100
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 1/2] ASoC: dt-bindings: xmos,xvf3500: add XMOS XVF3500
 voice processor
Content-Language: en-US
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
 Liam Girdwood <lgirdwood@gmail.com>, Mark Brown <broonie@kernel.org>,
 Rob Herring <robh+dt@kernel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
 Conor Dooley <conor+dt@kernel.org>, Matthias Kaehlcke <mka@chromium.org>,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-sound@vger.kernel.org, devicetree@vger.kernel.org,
 linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org
References: <20240130-onboard_xvf3500-v1-0-51b5398406cb@wolfvision.net>
 <20240130-onboard_xvf3500-v1-1-51b5398406cb@wolfvision.net>
 <ceb75d84-3e6f-40cd-97cb-ee6ccb14e7a6@linaro.org>
From: Javier Carrasco <javier.carrasco@wolfvision.net>
In-Reply-To: <ceb75d84-3e6f-40cd-97cb-ee6ccb14e7a6@linaro.org>
Content-Type: text/plain; charset=UTF-8
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?cnZ2YW5SWHNBM2g5cjhGTEFDTWdxakZRaVJPZ0V1TEpNRFBWNkNxMnlxU25H?=
 =?utf-8?B?UHlLNkVzTFpsdUszWnZ1NU5QUVk1TE9nVEVUTTIyVXdJdXQ0elRlWktXR041?=
 =?utf-8?B?amd4d2RIbnUzenJDcWdZU0Z1YVdic1RnQTB5MkI4L0Q0RGFlZENXaThGelVh?=
 =?utf-8?B?eHZyUFhrUStlN0VYS3pBbEJuVDlxVlNYU2MzWmpEeW9uWXIwNzRjQjE3Z0pa?=
 =?utf-8?B?eE1qOE02YUFMSm5GU09vRzM1bmYwOGNWZ0dXYjNmay81NnFnTDNMRm9nN2M4?=
 =?utf-8?B?STlRQVVCbUpqZWdWMUh1V0ppUTZZSUhuWUZnL0U5eVJBRTNKZEIyVUZzNzZE?=
 =?utf-8?B?Mks5RVpoU2I5a3Q0VWtDU2Q0YVdCeGtmcHdLMlY0ZnRDcXlwUmw0eUx1enRy?=
 =?utf-8?B?dUl4dDNtakZxS3N2bDZHQ3RQL25LTTd0Mk1hSnYrZG1rZEUzeWEwRytFM0tN?=
 =?utf-8?B?RWNqc2tZMEhzOUZ5Tjh1dFlkR1RTZk1aSkhlZTAzWUxLOHZNSWZzdVZQWVpw?=
 =?utf-8?B?UWgyRUVTR1NYa0UrWmxPY1NlL0ZXaGdxYnhqcnV4TmxKWVBOWHYvTCsvMmlX?=
 =?utf-8?B?eGlZbkhPVHNNRlhzdDFuUnZZWjVmZXJ1Y2pwdHdVSzBMdFozTFZ3bWlIQVlG?=
 =?utf-8?B?S0JockE4SkROUk1KdEZPclpuMmZDTFZFQWNpUUlGRHd2eWlQbTR1am54M0hk?=
 =?utf-8?B?bTdjZytYcHdFTE0vYm5ZeEJUWDY2dnNTNUpnZ3dtKy9YamcvKzJSbDlUUElh?=
 =?utf-8?B?a3RpRFdTZ1A5TFl6cWY2cnJoRWIyak0xZmJlak13dWdQMHZpU3grcEtiQVZT?=
 =?utf-8?B?NlVGb3ZGM0pYNUEzUXpYQ1FYL3hCNzBCR05YQlRFVVZZR3ZaanFWaWErYTNh?=
 =?utf-8?B?ZTMzazVZeXZvNURxblVDRWJwN0F6UVEzSXlKRXFuYWs3YXcvRW9rV2RINGZF?=
 =?utf-8?B?MU41L21LOG9ORlhnWlpNQ216Q21HMU5SMDlLTU9qdlNqd05WZTFDdWNGeEl5?=
 =?utf-8?B?R29EcHpuaTV6Y2Y3Wk55Uzl3MTFHamdRZXBuSmdkaGFwcDhYVkI4UDNQWUs5?=
 =?utf-8?B?RnBYTS9ULys4WUVqR0dWNXZRcnl1a3oxTXJyZDZCeG5YOTJteVFJWlc4c0ll?=
 =?utf-8?B?ZkJudVYySWh1d1JWSVdvRFhjMVIyRmJQT2x3cEZ6ck0ybzZaMlVWeTR1TXI2?=
 =?utf-8?B?WTJZQ1dISjB6cVlqam5tQTl4aERhdXdWdTBzcWZhMm51ZlV0eHJnRnVnRzh0?=
 =?utf-8?B?RlMxSzFQRWViR205b0FtTlo4NVdmWFNBVHdLWkxsOWR6MUUwYThzdkY1ZGwr?=
 =?utf-8?B?VVJ6aW1VM0Z1a2FCUGJnL1VEUVUwU2hJOGVlZkZtYmp0b0ZueEc0d2gwMC8v?=
 =?utf-8?B?UXhsVlBUYXBIYVhwbGpVYndnNmhLbkcrRkpnS0tLWEloeGh4QUNYdkFMS2lU?=
 =?utf-8?B?ZDk5NkRDME84b09OekluWU0yQzBuaDVSWmdITXNqNHprYnNNdDBJQ05OQ3Nm?=
 =?utf-8?B?Z29ySy9ub0JuN05OREhTUkRnNUlZbUpXMi84Qi9qdFRndjhoaU5rWXBvUHBL?=
 =?utf-8?B?eHFJQldsYXJoMUJ1aTUrSGMrNjVhdkIyejBHQjgzQlNYUGRiZUVkeU1ObURj?=
 =?utf-8?B?NTdxQVZVd2xWUU9lNUVaMWhEM1FTQkxmQ25Cb29tVkd6ZEZFMmhBRXpabGdG?=
 =?utf-8?B?MGpnL09CclRjQS9rcVpQWVZldTJRbkhLdzBhR2VoWjQ2Vmt0REhuWlFFSCtn?=
 =?utf-8?B?YmVmZ2w5RXovOHlhUGJnUE0vUS96UzJVUlF6WFNsVzdDMkdNcHFpWkFtODRq?=
 =?utf-8?B?dSs0ekxMaURBVUpUNFBBb2xOemtoNGpQRjlTd0kyQUd2Tmpna2hLUXZHMEtM?=
 =?utf-8?B?WjFaNmJzbEdJMzFnZ1FDUGQ4TUlnckxtaHYraTRXSmZ1UXh5SlJyR3dDVkc0?=
 =?utf-8?B?UXIrb2FUVmNaUDI0dFZKNTUxQk1QSUJRd1RxejRwQi9VRTdJcEFYcy9JZlRr?=
 =?utf-8?B?SjJROTU0dGFHSi9mVHpZMlFuNFdoVDZsbERlNit1VDkwdnUzMXgxbS94MGtJ?=
 =?utf-8?B?MUhTUFUzR3hweEVPNXVwaGp3QmFabmc2eGJXQndac2dTMVRXNjZ6b1dSRVdK?=
 =?utf-8?B?WHB5VnNRU3QzWDJWcTYzMHNMWjJXQ1FpbUYwcWdFeVVaTnd2eWJxcGJpL0xB?=
 =?utf-8?B?cGc9PQ==?=
X-OriginatorOrg: wolfvision.net
X-MS-Exchange-CrossTenant-Network-Message-Id: 671ab9fd-9f8d-4a7a-4bbc-08dc219963dc
X-MS-Exchange-CrossTenant-AuthSource: VE1PR08MB4974.eurprd08.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Jan 2024 13:43:07.0223
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: e94ec9da-9183-471e-83b3-51baa8eb804f
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: iIN31rIO+6tFVJ0XLwIccjDpP/jfliNZ4b3qmeYXqEBNa92riwMgT1jPePZ2HAsU26c0a2qFfMbQDwrap6WidE8SqVGTVnfj4DPduXpl2ig=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR08MB7777

On 30.01.24 13:34, Krzysztof Kozlowski wrote:
> On 30/01/2024 13:26, Javier Carrasco wrote:
>> The XMOS XVF3500 VocalFusion Voice Processor[1] is a low-latency, 32-bit
>> multicore controller for voice processing.
>>
>> Add new bindings to define the device properties.
>>
>> [1] https://www.xmos.com/xvf3500/
>>
>> Signed-off-by: Javier Carrasco <javier.carrasco@wolfvision.net>
>> ---
> 
> This should be v2. Also, please provide changelog either here or in
> cover letter.
> 
That would also have saved me from giving a reference to a previous
discussion. In that case I will use v3 for the next version and the
previous series for the sound subsystem will be mentioned in the
changelog as v1.
>>  .../devicetree/bindings/sound/xmos,xvf3500.yaml    | 51 ++++++++++++++++++++++
>>  1 file changed, 51 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/sound/xmos,xvf3500.yaml b/Documentation/devicetree/bindings/sound/xmos,xvf3500.yaml
>> new file mode 100644
>> index 000000000000..d7d5bda23b1b
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/sound/xmos,xvf3500.yaml
>> @@ -0,0 +1,51 @@
>> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/sound/xmos,xvf3500.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: XMOS XVF3500 VocalFusion Voice Processor
>> +
>> +maintainers:
>> +  - Javier Carrasco <javier.carrasco@wolfvision.net>
>> +
>> +description:
>> +  The XMOS XVF3500 VocalFusion Voice Processor is a low-latency, 32-bit
>> +  multicore controller for voice processing.
>> +  https://www.xmos.com/xvf3500/
>> +
>> +properties:
>> +  compatible:
>> +    const: usb20b1,0013
>> +
>> +  reset-gpios:
>> +    maxItems: 1
>> +
>> +  vdd-supply:
>> +    description:
>> +      Regulator for the 1V0 supply.
>> +
>> +  vdd2-supply:
>> +    description:
>> +      Regulator for the 3V3 supply.
>> +
>> +required:
>> +  - compatible
>> +  - reset-gpios
>> +  - vdd-supply
>> +  - vdd2-supply
>> +
>> +additionalProperties: false
>> +
>> +examples:
>> +  - |
>> +    #include <dt-bindings/gpio/gpio.h>
>> +
>> +    xvf3500 {
> 
> Node names should be generic. See also an explanation and list of
> examples (not exhaustive) in DT specification:
> https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation
> 
> Previous version had different code here, so I don't understand why this
> became model number.
> 
Thanks for the reference, I will change it to the previous "voice-processor"
> Best regards,
> Krzysztof
> 

Best regards,
Javier Carrasco