Received-SPF: pass (google.com: domain of linux-kernel+bounces-44790-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <c41143ae-4e1f-4190-bbb4-5cf0d9ebdcef@intel.com>
Date: Tue, 30 Jan 2024 23:00:31 +0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v9 05/27] x86/fpu/xstate: Introduce fpu_guest_cfg for
 guest FPU configuration
Content-Language: en-US
To: "Edgecombe, Rick P" <rick.p.edgecombe@intel.com>
CC: "Hansen, Dave" <dave.hansen@intel.com>, "seanjc@google.com"
	<seanjc@google.com>, "x86@kernel.org" <x86@kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"kvm@vger.kernel.org" <kvm@vger.kernel.org>, "pbonzini@redhat.com"
	<pbonzini@redhat.com>, "yuan.yao@linux.intel.com" <yuan.yao@linux.intel.com>,
	"john.allen@amd.com" <john.allen@amd.com>, "peterz@infradead.org"
	<peterz@infradead.org>, "Gao, Chao" <chao.gao@intel.com>,
	"mlevitsk@redhat.com" <mlevitsk@redhat.com>
References: <20240124024200.102792-1-weijiang.yang@intel.com>
 <20240124024200.102792-6-weijiang.yang@intel.com>
 <0221fdbd07cd35f954faa466a851cb063db57d03.camel@intel.com>
From: "Yang, Weijiang" <weijiang.yang@intel.com>
In-Reply-To: <0221fdbd07cd35f954faa466a851cb063db57d03.camel@intel.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YXNNWUZMSC9tRTJsZ2MyQzJkTUV0SG9HVmprWHFBK2E2VjZucm9lcmdITEIw?=
 =?utf-8?B?SDhmdkE2bUFHUDJDeGs1V3BmcjV6WFJtS001U2hOOE9aYmJnWGVyek1JTkxE?=
 =?utf-8?B?bmVzMUdaYmhhNE0rSDVtcWQraGZKb3pFMjV5c2lTT3YxbERwQ2hEdHRtbGhW?=
 =?utf-8?B?TUhOK0pZb2RRNStzdC9YK2ZWalRFOHQ4N1lyblQvQTFoVFVjTmN0c1Y3emw1?=
 =?utf-8?B?VGZ5THM1Q1RVbjNCK0xQamY1SGlxcmRZckdjODMzNXgzTkZEdjMrVWRuRXJq?=
 =?utf-8?B?SW05Uld5eER2Vk9ISEV6c2l1cWljamYzSEdxWjBCSnhBS1hXWll3VnJrR1d2?=
 =?utf-8?B?UU9HYVlyS1ozNkRVOXN4WmlVY1cwRXBRaGNqWTErY2k3ZmxRZ2VXc3hodDVy?=
 =?utf-8?B?RUJxQzRmTzNtK2sxQWRaTHgvTWo4UnRLOFd1QXY5VUlxcU5tRmp3a0EzQ0tj?=
 =?utf-8?B?dSswT0JRemN5eURBUkZtRnVvNDR1VVdDdGJSVFlMQUtJMlNiT2hVVm9McUtG?=
 =?utf-8?B?VmhZbHM0dUxnYUFjb0RXUVRjdERDcUN2WDJ6NjY0Zkd5MkdNSEY4QmpsV3NC?=
 =?utf-8?B?SGczUlhCcVdnWkNCVERqM3RhRjNLN2huMngvYWRLSlJBM3V2dEFuNC9TdFFZ?=
 =?utf-8?B?aTU3MXVyZ2hySzYyK2F0emo4enZRV0h1ZGpFdGdOYWxxWXVGcXZmbmsrOWV2?=
 =?utf-8?B?Q0N6QUwvRUpENVZoeGR2VjNwdnl4bWNXTXkyYXJ3RDZ1bUZJWGpCajE3QjFF?=
 =?utf-8?B?T1R4VW4zY2FleXVYU21taGdKUzgramtXMEZJbnNuM2RQK24xclRULyt5bWJz?=
 =?utf-8?B?bFVLT2VwbWdxMlZlK05wTDhOUi8vakViNkFiY1VoekdnTENoNW1rS1JmcWJp?=
 =?utf-8?B?ZFJlU0grcmx6THpweHJZZVhUSFp6aEw2TlQ0R204Z2F0TDlWcTkzUEYyc0xo?=
 =?utf-8?B?NkI1VzM0K2NDQytsRnA2SHZWNWxaQTdtaXo0d1R5N0p0N3dRdXhFOFZja2wx?=
 =?utf-8?B?NGsvRE4zVlJmSlRaVk0ydjcyYWlDNUNFakdkRHdmOVlQUnJDazdTSXlFUUgx?=
 =?utf-8?B?ZjYyaGIvOE45dTVraEZSV0g5Unk2OTBQS0I4VXFya1g3eHFtQ2VIZm1XbWZ6?=
 =?utf-8?B?Z2pmeWQ4dFg0LzRIVWN6NnFwUE04T091S3F1YkdjVHIzbkppZWgwQ01paWl0?=
 =?utf-8?B?amY0dGVENHVOdGg4NVpPYVAzbmNFakZqYXlrT0VVY3hkVU1PVGdBZ256NUdu?=
 =?utf-8?B?R0p3MVE3OXo0bEoxczJTZUV5SkxSYXJtbUJVK0JwblZPR0c3bEMyNWphbjlL?=
 =?utf-8?B?dkMwemdkQ2hVaUNFVHBjeTVyblgzOUtWMTh3S28xSlhMaUpGRmtaVG1reGxq?=
 =?utf-8?B?OERMdmJBbFJ2Z3FSdTNSelhHdURBZDJVdnJKYU0wdG1COFlPNTArK1ZXYXlr?=
 =?utf-8?B?VHZtVGpLU3BGN0VDdFRGUFJhYktCczVNNCthSGZnZ3Fxdjg4VTQ0bVJvOW1P?=
 =?utf-8?B?YUJENllEWG5OVEVoS0doK0F0VG9XR05rZjEzRnp1OTdmMmlpY25QWVBZUW9B?=
 =?utf-8?B?SHg5M1FOZmVFQ1pKMmp6OVJRR21vbzhiVnpqMUt1bi9zYWhOSGE5Q21RS3Zs?=
 =?utf-8?B?TVByQm5xUHJENElDL2xmR2RmQ2E3RGdpMnczV084elFvWnZuRnVGbFA2Zzg3?=
 =?utf-8?B?NmU0UHE4c09ZeUhRNytpUEg3ZStBdGYxVFpPY051eXRIdXBlMjVyQ3VMR3Aw?=
 =?utf-8?B?STVMZUl5LzNvdGtjRTkxWWwveE8yQXowU2N5NXFQYkJmRkJKMElEbU1nakJL?=
 =?utf-8?B?ODh1SVBHT3JGcUJWUlRlRE1HM01qeFVkWi9SbFRqbmRhbDhMUlNyOWFxbURP?=
 =?utf-8?B?eElGYnpDdERXS3VnNjZwNElBNTFVN09jV0JjUW5kcDJsYUQ0OHpjcEl2K0JW?=
 =?utf-8?B?RVhsMGcvOE9WZFJjMnIvVTV2andLUW5hZjJSY0hwUUg5dkdaTkhNV3dJdG05?=
 =?utf-8?B?TUNwYlFTb21vRlQxeVduU3hRQXdMelhFclJiR3FwMG1hbnZ3Q0pHYWxmQXpT?=
 =?utf-8?B?anFWaGhxNFRQeXJ4a21sc1g5OUtJOUJOUkFSak42SVhVaitXRnZmdktTMHdK?=
 =?utf-8?B?RVc1UnRiMDNEcUdkTmJMSXYwZmZaZjNETWt0U1FpOThrR1o4djFmRTlWQjUr?=
 =?utf-8?B?MEE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: b5c23a9d-cec9-4af4-3669-08dc21a43bd5
X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB4965.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Jan 2024 15:00:44.4879
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 5jaj/WEAlGcofVjwq657KXp5Euu1cl2SQmz92wFkibBzmES1fjYxosv02O5beT8Wl1808xTAQ/bjdMqK9346aQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM8PR11MB5623
X-OriginatorOrg: intel.com

On 1/30/2024 9:29 AM, Edgecombe, Rick P wrote:
> On Tue, 2024-01-23 at 18:41 -0800, Yang Weijiang wrote:
>> Define new fpu_guest_cfg to hold all guest FPU settings so that it
>> can
>> differ from generic kernel FPU settings, e.g., enabling CET
>> supervisor
>> xstate by default for guest fpstate while it's remained disabled in
>> kernel FPU config.
>>
>> The kernel dynamic xfeatures are specifically used by guest fpstate
>> now,
>> add the mask for guest fpstate so that guest_perm.__state_permit ==
> I think you mean 'guest_perm.__state_perm'.

Yes, will change it, thanks!

>
> Otherwise:
> Reviewed-by: Rick Edgecombe <rick.p.edgecombe@intel.com>
>
>