Received-SPF: pass (google.com: domain of linux-kernel+bounces-44849-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <b4d845d8-24e3-43ce-b1d4-e121f799e26c@intel.com>
Date: Tue, 30 Jan 2024 08:34:04 -0700
User-Agent: Betterbird (Linux)
Subject: Re: [PATCH] dmaengine: idxd: Avoid unnecessary destruction of
 file_ida
To: Fenghua Yu <fenghua.yu@intel.com>, Vinod Koul <vkoul@kernel.org>
CC: <dmaengine@vger.kernel.org>, linux-kernel <linux-kernel@vger.kernel.org>,
	Lijun Pan <lijun.pan@intel.com>
References: <20240130013954.2024231-1-fenghua.yu@intel.com>
Content-Language: en-US
From: Dave Jiang <dave.jiang@intel.com>
In-Reply-To: <20240130013954.2024231-1-fenghua.yu@intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Zm43b0Q1blZlclk1RDFBcUpoVjAwVEJiNUtzdDB0RkIrL1NGZzU2TElGVFNt?=
 =?utf-8?B?dkJWRW1kZmlQQXFWN1dNbXRjeFQxTFZIZVE1c0tKbTZqcmx2S3pFMStMc3Vz?=
 =?utf-8?B?aHpYUzBFdmtUbXM0Q0JsKzRSSU1EdmJxK3NmN2xrWE04WUlZbFBlOVFpUFgr?=
 =?utf-8?B?Nnp1OHprQVhQVHhJd1l0eWhVbGVIRGd2a2xVNy92RjVwKy9jWm1IYnl0NldE?=
 =?utf-8?B?UXhaRHplQlBwUUx2amtxQUx2bTRNVEwyR1JMSlVTYktlUTVtcE9XS0hUUkoy?=
 =?utf-8?B?YlpkVktUdzBscVRPaHM4dTRxQ0l2SVdBY2J6RUFpWjZMMllFOG9CVHpWQlh0?=
 =?utf-8?B?NmVYV2xMVEQyOGZJRERHSUVRdGRpZDU1UmU2Zi9BMFUyYm8zUG9TNjk2NUpM?=
 =?utf-8?B?UXJseHZwRENyRGRsbkRBRDU1TU94a2xjUWJuUlpvamVZd2VBU3Bid094dHRp?=
 =?utf-8?B?TWNwTXJBa0JmS0tnMDVuY3V3Rm4rcjIwVERsSUtZb2VDYzVSZEdORUd5cUpn?=
 =?utf-8?B?V21vVVovanc5ak0vS2M5bnAyZVBBTysvM1k0RWlXMlVXR25DVi9HRVpoNXo3?=
 =?utf-8?B?MEd5Z1BVeDBqK2VqNm1SM08xWENLR3djQ1hUUkM0YmRIekJGWWIxT2xhVU1a?=
 =?utf-8?B?L1NxZnBaeUc5T0p6NWVoa2lINFpyazEzSW5aejNKd3JvWE1sMjM2UmpBdUdE?=
 =?utf-8?B?VEZSMjNYMnZyWjJNUmpEUlVOWGxDeWJVczE4T05XdkNUN0pkYlpVMk5Bd2ZQ?=
 =?utf-8?B?Yk1xK1lST0JsYXRUR3dxSjdpdm82RnlhUlRmMmVZaEFNTGFQUzFIcUJORUV1?=
 =?utf-8?B?a3RWK2RuMGtMaUpPR3Y5emJ1UC9lcmw2czh6ay93SUxOY1VCSFF5RWlQdk9X?=
 =?utf-8?B?RFZSZk5LTVo2TEVPZzUwL2xtZnhvQlNFMExrWGV1VndNaG5vcjArK3ovZkgw?=
 =?utf-8?B?SlZEb2RYbG5NMG9SUlN0S3ptUmdaZjAycDMrU0pHT0t6cXZqM0prT2NKRHBO?=
 =?utf-8?B?QittUnFVaXN1L3FhNVlFMjc1MDBjT0R6bFdzUlVhRkJaeDI1YWo1ZGRCeVFD?=
 =?utf-8?B?RzlucTdwR0x4K0NiK3EyN053NTh1ZzloUjd6TkNVWjhGaDVJMWlBMkZkd3k4?=
 =?utf-8?B?R1ZvWHUrenZDWjR2ZTc2eGdncURORjZqdjFxdjFqcTNLOWNoNXNsZEx3TlBv?=
 =?utf-8?B?RHpRQkNPdXJnbUdhaWJKamZZdy9Wb3FvUUV0Yk1LaWtSZzRUd1ZGUzlGcmZX?=
 =?utf-8?B?bkhSZWNCS3dlaXlqZDVlSXM1eTBZdkZLeEEvb05la1pPUEFNTmgzYlFQUTlr?=
 =?utf-8?B?Zm1aN3g3dmptcjFCb3JhWEtMVno1cjU5MStEWnRLQjMrb2VkUHFwaUlhZE5O?=
 =?utf-8?B?ZDFUZ2pHaFh5a0ZLYk4zQ1ZqVlVRTzRLMGxRcWZPaVV2M1hzSG1oK0NDYWFL?=
 =?utf-8?B?TUdYREVTQWplSU1Zd2J1SmpQQ2dxUFJOSExleFljdGZkSkRiYzNWZHYwV2o3?=
 =?utf-8?B?Y2NWdWI0MlVJajNKTTltd0J3NHRwdWVvTUR5Z3pPTjdaS3d6dmRaZkducWRV?=
 =?utf-8?B?MjhRUTZwdzQ5SzFNM0VOZVA3YmJCY3RCeWVhT3VPeE9DcGtFTFNPUk1DU2Zt?=
 =?utf-8?B?MzZ3ZnBsY3FtQ0Q0cWxnRUxRWGV5SlhRS0JLWldId0FvVU0zVldYR2dkcDNW?=
 =?utf-8?B?YnVqazY5SDJBcExpd2VVWXA0VndJbitwVW1FcHVvelBVeFFXRDZORTNydFVh?=
 =?utf-8?B?aHNMNElOeHFCeHE3V1RSd0ltTG9OZVRkVjRkanIwQ09KNlZrZVczN0hCODdo?=
 =?utf-8?B?R25DVmRKZlZzSXorUDhzVkV5K3RHUGdlSysyMjQzZHlrUUFzSWNZTWdZUy94?=
 =?utf-8?B?ck1ZUG10V2Jsd0xiRWdNWjQvVWhVbktrbHZ0T0RJTGlKV01yenVid0k1K2tG?=
 =?utf-8?B?MUI4RnZncEZ6VVNLUUQxU0tDbkgrdDA5Ni81cXhra003OUcyUHFuYmswU1Z4?=
 =?utf-8?B?aTFPckFhZGJtSnNvQ2ZFd0RuOGFMZDBwTFB4am1OL1FMS01GR253RXkyR3Nw?=
 =?utf-8?B?eDE0K2kvOXUwL0d4dTB0NHpXb3p6TExSd0JrTFJ1TnBYaGQxWlc0L0lTVS9Q?=
 =?utf-8?Q?gGxX/xOZMoVRM20cqqiodj06A?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 59efc91e-f1f5-40c6-16fd-08dc21a8e6ca
X-MS-Exchange-CrossTenant-AuthSource: PH7PR11MB5984.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Jan 2024 15:34:09.3405
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: vyyNUd8oCcmJidyAdKy52azSbviHK9+UtI36LJZwIm0Q+rqc3rMCS32Oi5PUu/iXZ0UM8+L/BJ9+dl2jSSh6Jg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR11MB6135
X-OriginatorOrg: intel.com


On 1/29/24 18:39, Fenghua Yu wrote:
> file_ida is allocated during cdev open and is freed accordingly
> during cdev release. This sequence is guaranteed by driver file
> operations. Therefore, there is no need to destroy an already empty
> file_ida when the WQ cdev is removed.
> 
> Worse, ida_free() in cdev release may happen after destruction of 
> file_ida per WQ cdev. This can lead to accessing an id in file_ida
> after it has been destroyed, resulting in a kernel panic.
> 
> Remove ida_destroy(&file_ida) to address these issues.
> 
> Fixes: e6fd6d7e5f0f ("dmaengine: idxd: add a device to represent the file opened")
> Signed-off-by: Lijun Pan <lijun.pan@intel.com>
> Signed-off-by: Fenghua Yu <fenghua.yu@intel.com>

Reviewed-by: Dave Jiang <dave.jiang@intel.com>
> ---
>  drivers/dma/idxd/cdev.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/dma/idxd/cdev.c b/drivers/dma/idxd/cdev.c
> index baa51927675c..3311c920f47a 100644
> --- a/drivers/dma/idxd/cdev.c
> +++ b/drivers/dma/idxd/cdev.c
> @@ -1272,7 +1272,6 @@ void idxd_wq_del_cdev(struct idxd_wq *wq)
>  	struct idxd_cdev *idxd_cdev;
>  
>  	idxd_cdev = wq->idxd_cdev;
> -	ida_destroy(&file_ida);
>  	wq->idxd_cdev = NULL;
>  	cdev_device_del(&idxd_cdev->cdev, cdev_dev(idxd_cdev));
>  	put_device(cdev_dev(idxd_cdev));