Received-SPF: pass (google.com: domain of linux-kernel+bounces-44893-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Tue, 30 Jan 2024 11:01:12 -0500
From: Gregory Price <gregory.price@memverge.com>
To: "Huang, Ying" <ying.huang@intel.com>
Cc: Gregory Price <gourry.memverge@gmail.com>, linux-mm@kvack.org,
	linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org,
	linux-fsdevel@vger.kernel.org, linux-api@vger.kernel.org,
	corbet@lwn.net, akpm@linux-foundation.org, honggyu.kim@sk.com,
	rakie.kim@sk.com, hyeongtak.ji@sk.com, mhocko@kernel.org,
	vtavarespetr@micron.com, jgroves@micron.com,
	ravis.opensrc@micron.com, sthanneeru@micron.com,
	emirakhur@micron.com, Hasan.Maruf@amd.com, seungjun.ha@samsung.com,
	hannes@cmpxchg.org, dan.j.williams@intel.com
Subject: Re: [PATCH v3 4/4] mm/mempolicy: change cur_il_weight to atomic and
 carry the node with it
Message-ID: <ZbkdSFWNuoHuDtll@memverge.com>
References: <20240125184345.47074-1-gregory.price@memverge.com>
 <20240125184345.47074-5-gregory.price@memverge.com>
 <87sf2klez8.fsf@yhuang6-desk2.ccr.corp.intel.com>
 <ZbPf6d2cQykdl3Eb@memverge.com>
 <877cjsk0yd.fsf@yhuang6-desk2.ccr.corp.intel.com>
 <ZbfI3+nhgQlNKMPG@memverge.com>
 <ZbfqVHA9+38/j3Mq@memverge.com>
 <875xzbika0.fsf@yhuang6-desk2.ccr.corp.intel.com>
 <ZbhuJTBp68e8eLRv@memverge.com>
 <871q9ziel5.fsf@yhuang6-desk2.ccr.corp.intel.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <871q9ziel5.fsf@yhuang6-desk2.ccr.corp.intel.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?T1mOio2Jk2nHZ1YMohF/ttVyPygV4EsRULDKs2TRZ/uoYceFvH2LVPFKv0A0?=
 =?us-ascii?Q?ukeM0+1oNSRa1bqH0vnfWmeH85aNT86MU/KlUzFGeUsAnnAwt1IvY73wi5Ca?=
 =?us-ascii?Q?2LnD8Kt6s5CWq8QLAX/PPFOArlR9PLSZ7vMCYCodYILW5DAO0BER1z7OhYxz?=
 =?us-ascii?Q?20xggUcsjWO6lWwvmTtko3HVq6NtBtPAUMgTfmZR2qFEPLATpgG/36wEq2s0?=
 =?us-ascii?Q?OOMYQBqHXziamusRwxaTk+o+k0L9qP9ScXSKjppdP74HrmEM6uBv1avtAbhe?=
 =?us-ascii?Q?8VZdHRmojb35dbXd4B8RmAW69KgoG9L7BNKcudKXUIG/1D5H4nC5m3rWnBDU?=
 =?us-ascii?Q?76ZsNvcMKlzYrDwi6PZSE9lvrccd1AcOcY3EOlwmg5Sk8bxT5b/G4crt4KHh?=
 =?us-ascii?Q?OSaKZQiOsNcnUXjyb0q4ksQGUI/i9vZkDbHnALuqoTpf64tL2lLpLSn0ZlY3?=
 =?us-ascii?Q?I0CSdLLBWZW1dJIZxwJ2yy4EehqiYy3Ylhoz+2BkmsT7C/CfuR4SHNvHnw90?=
 =?us-ascii?Q?/0cL6WlC6FWzsmmU0eXnO5bDWSWNIixBjvkIH9y9t9JixTXRtp+JB3wcUa65?=
 =?us-ascii?Q?iyA79EhlKeGBSPdcHUguFV65nk32F5SRxhEZoslZIkUlp2SfCzfuXZ1DYhtT?=
 =?us-ascii?Q?5FMKhelIbVORFG/0xqJAltJdncrNCbop0DjmLKl+4X2mWLJzKoguHitEx7bG?=
 =?us-ascii?Q?g9FvTMgUIG8JhDWCVLPJransK/kplmWJjLBDTAccXulN/SbctvFbLVibgioc?=
 =?us-ascii?Q?iQh22E3WLwyOx1aqb659WVAywIfUaevMg/MjpzYMSyaVV1iNFqJlYBYKZxAX?=
 =?us-ascii?Q?wRUAQ0BB61R8irgqy5DGBMe+cXbCQPT/7FeKJoWFGilguNmxjAee+hrzcyp2?=
 =?us-ascii?Q?/lM6RW+QMwRM3eubbLZ5iqSEpozvz1ulbLRflFnrtrNfJWFpiMiQEfFVBs/H?=
 =?us-ascii?Q?irSLIZRx4qouTXfLOn7CLJ1pscZ2TeVRTvOiTZ8+90NHRNd4wmLtQfwjEzOD?=
 =?us-ascii?Q?jWNRDnqTDdmrFzSkIpdYKcvBbuTCD0edn++R6JdgCHm+idZUGhOs7QQ3Qdyp?=
 =?us-ascii?Q?ACH7MP/n3vcPQY9NXPYVfOHoxpXnjdGMJiMl4ZodOgDirsvStqQ1ELZeeyNT?=
 =?us-ascii?Q?njSePnKy1TebVWQYISeJK3gPVxdukxwZIQbkP7EdxtE//sUCCe8iDWZ7Oj72?=
 =?us-ascii?Q?Va3/l2Djx/VkcPbZytd0K4rIdaCLvILrSLstue6slWqqe8/O1a5WaqO6sso/?=
 =?us-ascii?Q?JTYG7UA0/1BtyeRYmtnGO5IQrq2lKye0JMdKZruBAr8b1ehQkjdiULEJMz4X?=
 =?us-ascii?Q?Cc/19wHFZ69BGb0EPkHoZT2xA0wvmtuOKvANVog7SO/WOH/bJQYn97kt2NPa?=
 =?us-ascii?Q?zTUD71ZpOESQDWYsA0CnsjB2k7fkU08ZeI20men/bwtkjMErEGAEs06sQQtE?=
 =?us-ascii?Q?nmEvP19sy5M6KNfXz2cB90QVoMXcIpsSdP4R28CuYDm+MFpCpv+MnxBDLBCl?=
 =?us-ascii?Q?zlWrBEGJLsJ6rKy+bbU7N98UYf0i6+Jd030vVH/Wq3i9c2SQlO3WgHPdpKA4?=
 =?us-ascii?Q?5pXnIBnTmNYlU22CUL1N689M09mFKDco9lhu5fArsikuMJP5TdYX8YqmNpfL?=
 =?us-ascii?Q?bg=3D=3D?=
X-OriginatorOrg: memverge.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 72d8323d-0182-41a4-1515-08dc21acb117
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR17MB5512.namprd17.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Jan 2024 16:01:17.0956
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 5c90cb59-37e7-4c81-9c07-00473d5fb682
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: iNjqhtuVvyxPopGgRVZJtSt7WpQvYqHs9D6Dj/eeEbpcuddi+O4Dpue3J/z+ahQDM7krL7JL3VRMb7jxkaqOy3eGgkBf+kv07qg6UJmH6bA=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR17MB3739

On Tue, Jan 30, 2024 at 01:18:30PM +0800, Huang, Ying wrote:
> Gregory Price <gregory.price@memverge.com> writes:
> 
> > For normal interleave, this isn't an issue because it always proceeds to
> > the next node. The same is not true of weighted interleave, which may
> > have a hanging weight in task->il_weight.
> 
> So, I added a check as follows,
> 
> node_isset(current->il_prev, policy->nodes)
> 
> If prev node is removed from nodemask, allocation will proceed to the
> next node.  Otherwise, it's safe to use current->il_weight.  
> 

Funny enough I have this on one of my branches and dropped it, but after
digging through everything - this should be sufficient.

I'll just add il_weight next to il_prev and have a new set of patches
out today. Code is already there, just needs one last cleanup pass.

~Gregory