Received-SPF: pass (google.com: domain of linux-kernel+bounces-44954-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Precedence: bulk
MIME-Version: 1.0
References: <20240130014208.565554-1-hannes@cmpxchg.org> <20240130014208.565554-7-hannes@cmpxchg.org>
In-Reply-To: <20240130014208.565554-7-hannes@cmpxchg.org>
From: Nhat Pham <nphamcs@gmail.com>
Date: Tue, 30 Jan 2024 08:33:18 -0800
Message-ID: <CAKEwX=N-n8Eps4ohERxRYAPSRYzpxpOW_1fzUfrpUq7P=1DZFg@mail.gmail.com>
Subject: Re: [PATCH 06/20] mm: zswap: rename __zswap_load() to zswap_decompress()
To: Johannes Weiner <hannes@cmpxchg.org>
Cc: Andrew Morton <akpm@linux-foundation.org>, Yosry Ahmed <yosryahmed@google.com>, 
	Chengming Zhou <zhouchengming@bytedance.com>, linux-mm@kvack.org, 
	linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Mon, Jan 29, 2024 at 5:42=E2=80=AFPM Johannes Weiner <hannes@cmpxchg.org=
> wrote:
>
> Signed-off-by: Johannes Weiner <hannes@cmpxchg.org>
> ---
>  mm/zswap.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/mm/zswap.c b/mm/zswap.c
> index 7a7e8da2b4f8..bdc9f82fe4b9 100644
> --- a/mm/zswap.c
> +++ b/mm/zswap.c
> @@ -1316,7 +1316,7 @@ static int zswap_enabled_param_set(const char *val,
>         return ret;
>  }
>
> -static void __zswap_load(struct zswap_entry *entry, struct page *page)
> +static void zswap_decompress(struct zswap_entry *entry, struct page *pag=
e)

This is a much better name. Was gonna point this out in the original
series - it's clearly just decompression :)
Reviewed-by: Nhat Pham <nphamcs@gmail.com>

>  {
>         struct zpool *zpool =3D zswap_find_zpool(entry);
>         struct scatterlist input, output;
> @@ -1411,7 +1411,7 @@ static int zswap_writeback_entry(struct zswap_entry=
 *entry,
>         zswap_entry_get(entry);
>         spin_unlock(&tree->lock);
>
> -       __zswap_load(entry, &folio->page);
> +       zswap_decompress(entry, &folio->page);
>
>         count_vm_event(ZSWPWB);
>         if (entry->objcg)
> @@ -1702,7 +1702,7 @@ bool zswap_load(struct folio *folio)
>         spin_unlock(&tree->lock);
>
>         if (entry->length)
> -               __zswap_load(entry, page);
> +               zswap_decompress(entry, page);
>         else {
>                 dst =3D kmap_local_page(page);
>                 zswap_fill_page(dst, entry->value);
> --
> 2.43.0
>