Received-SPF: pass (google.com: domain of linux-kernel+bounces-45000-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Tue, 30 Jan 2024 16:55:00 +0000
From: Conor Dooley <conor@kernel.org>
To: Michal Simek <michal.simek@amd.com>
Cc: linux-kernel@vger.kernel.org, monstr@monstr.eu, michal.simek@xilinx.com,
	git@xilinx.com, Conor Dooley <conor+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Rob Herring <robh+dt@kernel.org>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" <devicetree@vger.kernel.org>,
	kishore Manne <nava.kishore.manne@amd.com>,
	"moderated list:ARM/ZYNQ ARCHITECTURE" <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] dt-bindings: firmware: xilinx: Describe soc-vvmem subnode
Message-ID: <20240130-synthetic-passerby-44bab0ad9e1a@spud>
References: <3869498c995cbb123127122f429e90de0a3f4014.1706531104.git.michal.simek@amd.com>
 <20240129-vastly-hunk-0680e152c03c@spud>
 <ec0f347c-483d-47d2-b868-0c64070cc153@amd.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="BU7b17+mVNT7itsx"
Content-Disposition: inline
In-Reply-To: <ec0f347c-483d-47d2-b868-0c64070cc153@amd.com>


--BU7b17+mVNT7itsx
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Jan 30, 2024 at 08:13:09AM +0100, Michal Simek wrote:
>=20
>=20
> On 1/29/24 17:57, Conor Dooley wrote:
> > On Mon, Jan 29, 2024 at 01:25:06PM +0100, Michal Simek wrote:
> > > Describe soc-nvmem subnode as the part of firmware node. The name can=
't be
> > > pure nvmem because dt-schema already defines it as array property tha=
t's
> > > why different name should be used.
> > >=20
> > > Signed-off-by: Michal Simek <michal.simek@amd.com>
> > > ---
> > >=20
> > > Dt binding for nvmem node has been already merged and it is the part =
of
> > > linux-next tree.
> > > Here is the reference to it just in case:
> > > https://lore.kernel.org/r/170635581622.41421.8980881999042944764.b4-t=
y@linaro.org
> > >=20
> > > ---
> > >   .../bindings/firmware/xilinx/xlnx,zynqmp-firmware.yaml   | 9 ++++++=
+++
> > >   1 file changed, 9 insertions(+)
> > >=20
> > > diff --git a/Documentation/devicetree/bindings/firmware/xilinx/xlnx,z=
ynqmp-firmware.yaml b/Documentation/devicetree/bindings/firmware/xilinx/xln=
x,zynqmp-firmware.yaml
> > > index 7586fbff7ad6..108772ef574f 100644
> > > --- a/Documentation/devicetree/bindings/firmware/xilinx/xlnx,zynqmp-f=
irmware.yaml
> > > +++ b/Documentation/devicetree/bindings/firmware/xilinx/xlnx,zynqmp-f=
irmware.yaml
> > > @@ -62,6 +62,12 @@ properties:
> > >         interface.
> > >       type: object
> > > +  soc-nvmem:
> > > +    $ref: /schemas/nvmem/xlnx,zynqmp-nvmem.yaml#
> > > +    description: The ZynqMP MPSoC provides access to the hardware re=
lated data
> > > +      like SOC revision, IDCODE and specific purpose efuses.
> > > +    type: object
> > > +
> > >     pcap:
> > >       $ref: /schemas/fpga/xlnx,zynqmp-pcap-fpga.yaml
> > >       description: The ZynqMP SoC uses the PCAP (Processor Configurat=
ion Port) to
> > > @@ -110,6 +116,9 @@ examples:
> > >       firmware {
> > >         zynqmp_firmware: zynqmp-firmware {
> > >           #power-domain-cells =3D <1>;
> > > +        soc-nvmem {
> > > +          compatible =3D "xlnx,zynqmp-nvmem-fw";
> > > +        };
> >=20
> > Would it not be better to have an actual nvmem-layout in here? The
> > ~empty node here looks rather odd.
>=20
> No issue. Do you want full or just nvmem-layout with compatible string (w=
hich is
> required)?


What you have below here seems like a much more useful example. I'd go
with that.

Cheers,
Conor.

>        soc-nvmem {
>            compatible =3D "xlnx,zynqmp-nvmem-fw";
>            nvmem-layout {
>                compatible =3D "fixed-layout";
>                #address-cells =3D <1>;
>                #size-cells =3D <1>;
>=20
>                soc_revision: soc-revision@0 {
>                    reg =3D <0x0 0x4>;
>                };
>            };
>        };


--BU7b17+mVNT7itsx
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZbkp5AAKCRB4tDGHoIJi
0jQLAQCOeib5tcX6tEcKKUiRouIu3/C9GTGk2X/tIfQzaGKcxQD6AkDiq9g327L9
BZRRAwIsfJ0/zkLp6eBqjTbywmmPjgI=
=/dwj
-----END PGP SIGNATURE-----

--BU7b17+mVNT7itsx--