Received-SPF: pass (google.com: domain of linux-kernel+bounces-45015-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Tue, 30 Jan 2024 18:08:09 +0100
From: Henrik Grimler <henrik@grimler.se>
To: Tudor Ambarus <tudor.ambarus@linaro.org>
Cc: krzysztof.kozlowski+dt@linaro.org, broonie@kernel.org,
	robh+dt@kernel.org, conor+dt@kernel.org, alim.akhtar@samsung.com,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-spi@vger.kernel.org, andre.draszik@linaro.org,
	peter.griffin@linaro.org, semen.protsenko@linaro.org,
	kernel-team@android.com, willmcvicker@google.com
Subject: Re: [PATCH 5/7] ARM: dts: samsung: exynos5450: specify the SPI
 fifosize
Message-ID: <Zbks+eihEIK+Jyd2@L14.lan>
References: <20240125151630.753318-1-tudor.ambarus@linaro.org>
 <20240125151630.753318-6-tudor.ambarus@linaro.org>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240125151630.753318-6-tudor.ambarus@linaro.org>

Hi Tudor,

There is a typo in the subject of this patch, exynos 5450 instead of
5420.  Maybe that is something krzk can fix when applying.

Best regards,
Henrik Grimler

On Thu, Jan 25, 2024 at 03:16:28PM +0000, Tudor Ambarus wrote:
> Up to now the SPI alias was used as an index into an array defined in
> the SPI driver to determine the SPI FIFO size. Drop the dependency on
> the SPI alias and specify the SPI FIFO size directly into the SPI node.
> 
> Signed-off-by: Tudor Ambarus <tudor.ambarus@linaro.org>
> ---
>  arch/arm/boot/dts/samsung/exynos5420.dtsi | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/samsung/exynos5420.dtsi b/arch/arm/boot/dts/samsung/exynos5420.dtsi
> index 25ed90374679..e22692063aa9 100644
> --- a/arch/arm/boot/dts/samsung/exynos5420.dtsi
> +++ b/arch/arm/boot/dts/samsung/exynos5420.dtsi
> @@ -658,6 +658,7 @@ spi_0: spi@12d20000 {
>  			pinctrl-0 = <&spi0_bus>;
>  			clocks = <&clock CLK_SPI0>, <&clock CLK_SCLK_SPI0>;
>  			clock-names = "spi", "spi_busclk0";
> +			samsung,spi-fifosize = <256>;
>  			status = "disabled";
>  		};
>  
> @@ -674,6 +675,7 @@ spi_1: spi@12d30000 {
>  			pinctrl-0 = <&spi1_bus>;
>  			clocks = <&clock CLK_SPI1>, <&clock CLK_SCLK_SPI1>;
>  			clock-names = "spi", "spi_busclk0";
> +			samsung,spi-fifosize = <64>;
>  			status = "disabled";
>  		};
>  
> @@ -690,6 +692,7 @@ spi_2: spi@12d40000 {
>  			pinctrl-0 = <&spi2_bus>;
>  			clocks = <&clock CLK_SPI2>, <&clock CLK_SCLK_SPI2>;
>  			clock-names = "spi", "spi_busclk0";
> +			samsung,spi-fifosize = <64>;
>  			status = "disabled";
>  		};
>  
> -- 
> 2.43.0.429.g432eaa2c6b-goog
> 
>