Received: by 2002:a05:7412:d1aa:b0:fc:a2b0:25d7 with SMTP id ba42csp1149300rdb; Tue, 30 Jan 2024 09:13:15 -0800 (PST) X-Google-Smtp-Source: AGHT+IEPSXHJR+mXj2G6uT1UHV4+apwCfSmf5jihc7JNXLdS6Q4YfnBuACwhl4Kj7LnVwHtsjUaW X-Received: by 2002:a92:c012:0:b0:363:8249:589 with SMTP id q18-20020a92c012000000b0036382490589mr5322956ild.8.1706634795680; Tue, 30 Jan 2024 09:13:15 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1706634795; cv=pass; d=google.com; s=arc-20160816; b=JPPnZkSLnW/3fQgRNcG8OXHp2z4tF3vUbSZqNKU0CtlQQRfTud3M9+jTaM7YqApvSY T1FIiCek6X4A3Fht4vxh9RP9P8efHb51T3dcLiiwMMJV0ITBWlScq1Ha+ROyHRTl1i1b FUy9jnF50aNZ0vnAxh7c8uRuT319HKEz7W7ObiCl42+FPDMrv9GP7uFxyJITiCW0iToB vM+pd75i1A/1RQRgXsQzzQHkcCTv49MgB/8zsFn28NxMaPPScMxi5/UC0/MvDCp12WE0 Ex6L8X2JCK+U0mLjfGHzFbub3RtLCt1JM6dlyenhhYJFGztjBbumjGYF4HvtyOi05O7z QrEA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:list-unsubscribe:list-subscribe :list-id:precedence:dkim-signature; bh=WaNq4krNLHt6a61UcNpi0mjlOnPPbIzoJTFazPx30HM=; fh=nQ58/qv1uOygkFz0vvydh+mBWY2DyJCHMRDNyKQnfOk=; b=fFzv/4XvurYIMWUSGeJzzOYldxzoUSBMfi8jdV3arMBvhqlPeSw3sBBRtAVpywWYcu qnQ+xA5Jb/R+cj9OfjGuR/myVgiuaAC7yduoUnGGRlambdT2twRKJ9V/f+LdQLYyFYRt n/INRtPWw+w/kPrR5bAu8WuzfBlcwTR5EcUDC/Lff+24/QNeU2QvLt4OiBt5jUaMY+gz RuMMquPI9tn2bbUVMm8vfvd02QtTHo7Lt8uhyK0Ulj+1UNNdrOxXPye/vCjG9jVihVgc 1hHNDAefr0m9PdxzFe+/rVjD6m0qFCrke32yFGVc3tripaOdOR4TuZFfFABCg4vlx48y 9vOQ== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=j+P6VWU5; arc=pass (i=1 spf=pass spfdomain=gmail.com dkim=pass dkdomain=gmail.com dmarc=pass fromdomain=gmail.com); spf=pass (google.com: domain of linux-kernel+bounces-44981-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-44981-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id l7-20020a635707000000b005d8d56cd646si2904908pgb.130.2024.01.30.09.13.15 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Jan 2024 09:13:15 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-44981-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=j+P6VWU5; arc=pass (i=1 spf=pass spfdomain=gmail.com dkim=pass dkdomain=gmail.com dmarc=pass fromdomain=gmail.com); spf=pass (google.com: domain of linux-kernel+bounces-44981-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-44981-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 08896B26954 for ; Tue, 30 Jan 2024 16:51:06 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 26B14128382; Tue, 30 Jan 2024 16:50:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="j+P6VWU5" Received: from mail-io1-f52.google.com (mail-io1-f52.google.com [209.85.166.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E33771272C7 for ; Tue, 30 Jan 2024 16:50:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.166.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706633457; cv=none; b=r3ELCmAldd2OZ+NtTw3jr+bdXIjDR2bDLxpphI1svfkU6X5NDO+ird8MIgi3HBZ5dXjXGeGA76fhTZUXo6W/4DzMc9RJfqpdwgwjGdUeQkoqB1ZmGynwSlEmSeuRtdagdAR8mtU6neAiarKW1HOHk6ANGVm6el+oTl15iaGMGMk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706633457; c=relaxed/simple; bh=WaNq4krNLHt6a61UcNpi0mjlOnPPbIzoJTFazPx30HM=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=f+5+x9p3g875I+U4yD1ZXZMmCeXJwQrCIDUsPia7VbDbaTPbhHkuqvZ2P0ZlC8ZOQEiTQx/jxp7jGX/6RTF16hDKJ75d30M9CuPeLWkuPCRm+UgL/Pwjp7yiyB9a2BPMJ5USRQYZlv0d1FC5t037eZWUZkuRkRMfOy/mE4pexJM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=j+P6VWU5; arc=none smtp.client-ip=209.85.166.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-io1-f52.google.com with SMTP id ca18e2360f4ac-7bf7e37dc60so166680539f.3 for ; Tue, 30 Jan 2024 08:50:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1706633453; x=1707238253; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=WaNq4krNLHt6a61UcNpi0mjlOnPPbIzoJTFazPx30HM=; b=j+P6VWU5i1CXbNePjWyDkmbQ0YnhlWxWrFi/To5kvZObh+PvoQBcug/ZL+wOlauT7X Silw8gfD0N7elE4eCaWX8ah9ibclDmTeaTv0OkZD/bZJ2Q8LPLgI9bPYYbRQjxJw+QQU OQGAX7vUYohruuqIUjWNrCt5jpjh8tPw3/UCf9XdkkXSZnULpaSXQcxQwQNja721w6BA y5PnBhdonX6vpgVWkxmvuud3acIDc1XdvpYSsmZEokglwYgj6tdWoVpzSKdjs1ERn9tp xEDidzdGe8ABNz+679r0s++xIJ1HZMDPhsE5CtFRbJC+BdGUWHJG1OUD7nUboK6jiYHN H4oA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706633453; x=1707238253; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=WaNq4krNLHt6a61UcNpi0mjlOnPPbIzoJTFazPx30HM=; b=rWAu54tbw7IU4BaEQVvq5KiAB2hyvO5seyMMXjKeREYF2q9fYT66yUIdooWgjOX3uR mY565lhMGKa93S4YlNd3Ogi9L8yKbiRZ4k6LJDig0B8UYb1vzP+5Oe0ZwxnFI7LmWcoo eqqlKrjsBHPwX4Ff7TJeYU2unz6U8uSMjIznVXqbTF9JzXgbIXGJ08v4FJzja5nNhYxu LAlcjulVQsucUDSIVfSHYd93gUnCt2okOfwvxpRkuuARmsxtyvKGxvJJuirwbl4WaxGs Q9/qq5BJBo2H6OQ7bI3XTfgFdqJYC0lBIDvdo5jVv9s5a5fEyIi1WkKprfWVchQfvC7y 93og== X-Gm-Message-State: AOJu0YyaobRoqY8RpFIgV0+JfoB0BOegrKVUCcHEdKuwCbbp5JuciLNe qXpGx6s4xtR16/PWVhBhcy9w06ndWZGAgw9UZC7XZ4Kuzi5C7SloPTZX1LjP35aqzlibuIXpRfI 3V+9Ods/nieyJpPx9n8s87I/uoTU= X-Received: by 2002:a5e:cb01:0:b0:7c0:19e5:f33d with SMTP id p1-20020a5ecb01000000b007c019e5f33dmr170708iom.9.1706633453613; Tue, 30 Jan 2024 08:50:53 -0800 (PST) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20240130014208.565554-1-hannes@cmpxchg.org> <20240130014208.565554-10-hannes@cmpxchg.org> In-Reply-To: <20240130014208.565554-10-hannes@cmpxchg.org> From: Nhat Pham Date: Tue, 30 Jan 2024 08:50:42 -0800 Message-ID: Subject: Re: [PATCH 09/20] mm: zswap: simplify zswap_invalidate() To: Johannes Weiner Cc: Andrew Morton , Yosry Ahmed , Chengming Zhou , linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, Jan 29, 2024 at 5:42=E2=80=AFPM Johannes Weiner wrote: > > The branching is awkward and duplicates code. The comment about > writeback is also misleading: yes, the entry might have been written > back. Or it might have never been stored in zswap to begin with due to > a rejection - zswap_invalidate() is called on all exiting swap entries. > > Signed-off-by: Johannes Weiner Reviewed-by: Nhat Pham