Received-SPF: pass (google.com: domain of linux-kernel+bounces-45035-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Tue, 30 Jan 2024 17:23:12 +0000
From: Conor Dooley <conor@kernel.org>
To: Naresh Solanki <naresh.solanki@9elements.com>
Cc: Peter Rosin <peda@axentia.se>, Jonathan Cameron <jic23@kernel.org>,
	Lars-Peter Clausen <lars@metafoo.de>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>, mazziesaccount@gmail.com,
	linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] dt-bindings: iio: afe: voltage-divider: Add
 io-channel-cells
Message-ID: <20240130-abroad-repeater-7966f998e1f6@spud>
References: <20240130115651.457800-1-naresh.solanki@9elements.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="toQvdWVCqzr+Zex9"
Content-Disposition: inline
In-Reply-To: <20240130115651.457800-1-naresh.solanki@9elements.com>


--toQvdWVCqzr+Zex9
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hey,

On Tue, Jan 30, 2024 at 05:26:50PM +0530, Naresh Solanki wrote:
> voltage-divider is always an iio consumer at the same time it is
> optionally an iio provider.
> Hence add #io-channel-cells
> Also update example.
>=20
> Signed-off-by: Naresh Solanki <naresh.solanki@9elements.com>
> ---
>  .../bindings/iio/afe/voltage-divider.yaml          | 14 +++++++++++++-
>  1 file changed, 13 insertions(+), 1 deletion(-)
>=20
> diff --git a/Documentation/devicetree/bindings/iio/afe/voltage-divider.ya=
ml b/Documentation/devicetree/bindings/iio/afe/voltage-divider.yaml
> index dddf97b50549..98fec8548cc3 100644
> --- a/Documentation/devicetree/bindings/iio/afe/voltage-divider.yaml
> +++ b/Documentation/devicetree/bindings/iio/afe/voltage-divider.yaml
> @@ -39,6 +39,13 @@ properties:
>      description: |
>        Channel node of a voltage io-channel.
> =20
> +  '#io-channel-cells':
> +    description:
> +      In addition to consuming the measurement services of a voltage out=
put
> +      channel the voltage divider can act as a provider of measurement
> +      services to other devices.

Did you miss:
https://lore.kernel.org/all/20240127165542.6eeb23e9@jic23-huawei/
Where I said that I would like to have an example of where this would be
used in the description? Peter gave a good example that you can draw on.

> +    const: 1
> +
>    output-ohms:
>      description:
>        Resistance Rout over which the output voltage is measured. See ful=
l-ohms.
> @@ -75,12 +82,17 @@ examples:
>              spi-max-frequency =3D <1000000>;
>          };
>      };
> -    sysv {
> +    p12v_vd: sysv {
>          compatible =3D "voltage-divider";
>          io-channels =3D <&maxadc 1>;
> +        #io-channel-cells =3D <1>;
> =20
>          /* Scale the system voltage by 22/222 to fit the ADC range. */
>          output-ohms =3D <22>;
>          full-ohms =3D <222>; /* 200 + 22 */
>      };

Blank line here please.

Thanks,
Conor.

> +    iio-hwmon {
> +        compatible =3D "iio-hwmon";
> +        io-channels =3D <&p12v_vd 0>;
> +    };
>  ...
>=20
> base-commit: 861c0981648f5b64c86fd028ee622096eb7af05a
> --=20
> 2.42.0
>=20

--toQvdWVCqzr+Zex9
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZbkwgAAKCRB4tDGHoIJi
0jh0AQCf42G+DhRYSRloF1zdFV1JWBEczufKUo+D/M8fqdW7EAEAgG/RyQdQq3a2
vGwwXqVD8ZruqcgkkjX7oJJIcPhIcwE=
=t3ag
-----END PGP SIGNATURE-----

--toQvdWVCqzr+Zex9--