Received-SPF: pass (google.com: domain of linux-kernel+bounces-45064-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Tue, 30 Jan 2024 17:56:37 +0000
From: Conor Dooley <conor@kernel.org>
To: Bastien Curutchet <bastien.curutchet@bootlin.com>
Cc: "David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Richard Cochran <richardcochran@gmail.com>,
	Andrew Lunn <andrew@lunn.ch>,
	Heiner Kallweit <hkallweit1@gmail.com>,
	Russell King <linux@armlinux.org.uk>, netdev@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
	Herve Codina <herve.codina@bootlin.com>
Subject: Re: [PATCH 1/2] dt-bindings: net: Add TI DP83640
Message-ID: <20240130-impulsive-widow-9142a069b7fd@spud>
References: <20240130085935.33722-1-bastien.curutchet@bootlin.com>
 <20240130085935.33722-2-bastien.curutchet@bootlin.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="Y5GnecSt1OF2hlII"
Content-Disposition: inline
In-Reply-To: <20240130085935.33722-2-bastien.curutchet@bootlin.com>


--Y5GnecSt1OF2hlII
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

Hey,

On Tue, Jan 30, 2024 at 09:59:34AM +0100, Bastien Curutchet wrote:
> +description: |
> +  The DP83640 Precision PHYTER device delivers the highest level of precision

This is not a marketing document.

> +  clock synchronization for real time industrial connectivity based on the
> +  IEEE 1588 standard. The DP83640 has deterministic, low latency and allows
> +  choice of microcontroller with no hardware customization required
> +
> +  This device interfaces directly to the MAC layer through the
> +  IEEE 802.3 Standard Media Independent Interface (MII), or Reduced MII (RMII).
> +
> +  Specifications about the Ethernet PHY can be found at:
> +    https://www.ti.com/lit/gpn/dp83640
> +
> +properties:
> +  reg:
> +    maxItems: 1
> +
> +  ti,clk-output:
> +    $ref: /schemas/types.yaml#/definitions/uint32
> +    enum: [0, 1]
> +    description: |
> +      If present, enables or disables the CLK_OUT pin.
> +      CLK_OUT pin disabling can also be strapped. If the strap pin is not set
> +      correctly or not set at all then this can be used to configure it.
> +       - 0     = CLK_OUT pin disabled
> +       - 1     = CLK_OUT pin enabled
> +       - unset = Configured by straps

If you are providing a clock, why is there no clock-controller property
here? I don't think the 3-way nature of this property is needed, if you
make this a "real" clock controller.

> +  ti,fiber-mode:
> +    $ref: /schemas/types.yaml#/definitions/uint32
> +    enum: [0, 1]
> +    description: |
> +      If present, enables or disables the FX Fiber Mode.
> +      Fiber mode support can also be strapped. If the strap pin is not set
> +      correctly or not set at all then this can be used to configure it.
> +       - 0     = FX Fiber Mode disabled
> +       - 1     = FX Fiber Mode enabled
> +       - unset = Configured by straps

I don't like these properties that map meanings onto numbers. We can
have enums of strings in bindings that allow you to use something more
meaningful than "0" or "1".

Cheers,
Conor.


--Y5GnecSt1OF2hlII
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZbk4VQAKCRB4tDGHoIJi
0sc9AP9/5gdJl8glaf7X/USWmsQy+VhIxi9nZrUhkpklLAx09gEAs00QJHIiHRDu
j51c3BLSHaUypla7gPW7LWlopEKQeAs=
=Zij8
-----END PGP SIGNATURE-----

--Y5GnecSt1OF2hlII--