Received-SPF: pass (google.com: domain of linux-kernel+bounces-45128-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Feedback-ID: iad51458e:Fastmail
Date: Tue, 30 Jan 2024 10:42:16 -0800
From: Boqun Feng <boqun.feng@gmail.com>
To: Frederic Weisbecker <frederic@kernel.org>
Cc: linux-kernel@vger.kernel.org, rcu@vger.kernel.org,
	"Paul E . McKenney" <paulmck@kernel.org>,
	Neeraj Upadhyay <neeraj.iitr10@gmail.com>,
	Joel Fernandes <joel@joelfernandes.org>,
	Josh Triplett <josh@joshtriplett.org>,
	Steven Rostedt <rostedt@goodmis.org>,
	Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
	Lai Jiangshan <jiangshanlai@gmail.com>,
	Zqiang <qiang.zhang1211@gmail.com>
Subject: Re: [PATCH 1/8] rcu/exp: Remove full barrier upon main thread wakeup
Message-ID: <ZblDCPrr9fPgEi2P@boqun-archlinux>
References: <20240129232349.3170819-1-boqun.feng@gmail.com>
 <20240129232349.3170819-2-boqun.feng@gmail.com>
 <ZbkaBO99-6ZuNCcR@localhost.localdomain>
 <ZbkaWbpufZ6q-jLZ@localhost.localdomain>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <ZbkaWbpufZ6q-jLZ@localhost.localdomain>

On Tue, Jan 30, 2024 at 04:48:41PM +0100, Frederic Weisbecker wrote:
> Le Tue, Jan 30, 2024 at 04:47:16PM +0100, Frederic Weisbecker a ?crit :
> > Le Mon, Jan 29, 2024 at 03:23:39PM -0800, Boqun Feng a ?crit :
> > > From: Frederic Weisbecker <frederic@kernel.org>
> > > 
> > > When an expedited grace period is ending, care must be taken so that all
> > > the quiescent states propagated up to the root are correctly ordered
> > > against the wake up of the main expedited grace period workqueue.
> > > 
> > > This ordering is already carried through the root rnp locking augmented
> > > by an smp_mb__after_unlock_lock() barrier.
> > > 
> > > Therefore the explicit smp_mb() placed before the wake up is not needed
> > > and can be removed.
> > > 
> > > Signed-off-by: Frederic Weisbecker <frederic@kernel.org>
> > > Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
> > 
> > [Offlist]
> 
> And yes that was not offlist, my fingers betrayed me!
> 

Thanks for the reminder anyway ;-)

Regards,
Boqun

> > 
> > For further posting, don't forget to add your own SoB while posting patches :-)
> > 
> > Thanks!
> >