Received: by 2002:a05:7412:d1aa:b0:fc:a2b0:25d7 with SMTP id ba42csp1202390rdb; Tue, 30 Jan 2024 10:48:09 -0800 (PST) X-Google-Smtp-Source: AGHT+IEsJQGoDAhOq/ZQGqQCMKHl3MMIJUawH0HKZCoAREyJvUQUUs5aqGL3wy9KFiozzwWcZ7bH X-Received: by 2002:a17:90a:9313:b0:290:16e6:deeb with SMTP id p19-20020a17090a931300b0029016e6deebmr6621680pjo.47.1706640489533; Tue, 30 Jan 2024 10:48:09 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1706640489; cv=pass; d=google.com; s=arc-20160816; b=PTxDXuXZ6MvUhv0pFtSrWEeZF435Whb5joDJUijBFLPcd/FRSFvzjT7rJQHZOCcIBj 7zsTJJNrfYRmPOio6dUmvc/kiqSdKDXEWK9U1LzjDbGuY7lZCZxl+6Rk+Ucgb5NskpKH KPiAoj3hfGPtvCJUHwVUjjDWRhg0tges8nt5XRCyEljh4CAFlyw5zJG/UnVEHS0EJEwV vOq6TBZ+9UKJf5r5TH83nZE3UXfX4LSuZ9qjZxmOS/oU8G8nmdRLvoNjUSkfNiCP4Vsc Ht2ALpRUtkbdnRZjAOjAbimWxxWsGL3TkkOqVSOvvt7CsMoyXClRI6LKYOwlVIK7OLAm Cp1Q== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:lines:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=tKah+8+gLlI58xWYm3bbiE4YxfGliv2jaO5Qu9FoufQ=; fh=ZUcPkiVf4gvMgVDOUhavBu3WqSDJFLN7Q4rE5Smm1Ig=; b=qOYlvVb/8jGbmNzfptufBpf4BJzxt+rUNSB40cEpXgo7uDgxoG7b0lToZbgqqj3o47 bf4RzAg8DL+O6HHkvG9VPDkiNu4lcmBT+p3wFG6koqonbllNGDAFSZGesyzqsLGSBq7o mpZaY4sAiPp+PzjQek49HQnFEhERf0sOeOHcRLYH3gFh2veYdm7X8WkzSFVMXNKVYuZX f3WdYV4h7CAFOAVhB6Wh7A6NHgBy8fulOBZ/qfG1zY+iztfWrT9obht2OiPsClHFGPBD CP4j5MSCy7svRECTxaF8tnjylclrGKlkchxLmc/OyJsDftSp0SW0/QzRKao1mnHyni7y B1Ug== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b="cvR/3SDG"; arc=pass (i=1 dkim=pass dkdomain=linuxfoundation.org); spf=pass (google.com: domain of linux-kernel+bounces-45137-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-45137-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id ne12-20020a17090b374c00b00290be1473d9si9907332pjb.3.2024.01.30.10.48.09 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Jan 2024 10:48:09 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-45137-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b="cvR/3SDG"; arc=pass (i=1 dkim=pass dkdomain=linuxfoundation.org); spf=pass (google.com: domain of linux-kernel+bounces-45137-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-45137-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 4273E281140 for ; Tue, 30 Jan 2024 18:47:47 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 25A8679926; Tue, 30 Jan 2024 18:46:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="cvR/3SDG" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4AEC012BEBD for ; Tue, 30 Jan 2024 18:46:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706640406; cv=none; b=AXCoUlo8Yvo2206uSxFk/Ur+uPoY7U1bqtvFlEzZYXNi0Lg7/Gms8iS2kRVXD/wMX6kdJV0JADjXhy6DH2wObfOCa9pIQfxkitEAteKcwBRG1zF4IhGPm3Gn7QVuWKK99zc9LGQqbboPnB3LwZCrkNn8hrqzLVwE+GHnZnxeTpw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706640406; c=relaxed/simple; bh=EAByQhXyu/+Nq0/YEitbsn1bxLp9uFAhGiUot7pVcwI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=dLVxHr7QLenwoU5E9QKNG+znOz3LNZ22zC3fLBpzunYW+dLx+6VQJEt3B9jyx524brlj1lmCCMKXc8NZrFkZHgBGNTQUfpn8oERZH00/LK0MHzl5QA43L/Xz+nzWk0qUlq7zoTHsW3B304gvojuGx0eo6oxOTPsLFYcWRds+hQc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=cvR/3SDG; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id A08DDC433B1; Tue, 30 Jan 2024 18:46:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1706640405; bh=EAByQhXyu/+Nq0/YEitbsn1bxLp9uFAhGiUot7pVcwI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=cvR/3SDGO4jTwkZ5iAip4p0J9YwtCR4gfiJOQ9HwN9++C/impGwuYy17Bk7FeEZon WKSLPpavHEe8u1jGIknmoYjShSFbVOiObMq9ssSXYRazX9QZlvNco91PnEPTt0sXeR tk/EuoyJMviDztCrMyCIMX4qrzbPrsCQE//z1wwI= From: Greg Kroah-Hartman To: alsa-devel@alsa-project.org Cc: linux-kernel@vger.kernel.org, Greg Kroah-Hartman , Dan Williams , Vinod Koul , Bard Liao , Pierre-Louis Bossart , Sanyog Kale Subject: [PATCH 6/6] soundwire: sysfs: remove unneeded ATTRIBUTE_GROUPS() comments Date: Tue, 30 Jan 2024 10:46:32 -0800 Message-ID: <2024013031-tranquil-matador-a554@gregkh> X-Mailer: git-send-email 2.43.0 In-Reply-To: <2024013025-spoiling-exact-ad20@gregkh> References: <2024013025-spoiling-exact-ad20@gregkh> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Lines: 43 X-Developer-Signature: v=1; a=openpgp-sha256; l=1455; i=gregkh@linuxfoundation.org; h=from:subject:message-id; bh=EAByQhXyu/+Nq0/YEitbsn1bxLp9uFAhGiUot7pVcwI=; b=owGbwMvMwCRo6H6F97bub03G02pJDKk7Xdg/LmraJeW/8MSxm48mi0WrKM6cWl/kw3Jtq4FSw rbUW9P4OmJZGASZGGTFFFm+bOM5ur/ikKKXoe1pmDmsTCBDGLg4BWAi5ecZ5sd8rV52tMg7taio 0EfyyJ6VXXvD+hgWTBezWyW2vSXnLv/X/6saZFKXHT9sDwA= X-Developer-Key: i=gregkh@linuxfoundation.org; a=openpgp; fpr=F4B60CC5BF78C2214A313DCB3147D40DDB2DFB29 Content-Transfer-Encoding: 8bit Now that we manually created our own attribute group list, the outdated ATTRIBUTE_GROUPS() comments can be removed as they are not needed at all. Cc: Vinod Koul Cc: Bard Liao Cc: Pierre-Louis Bossart Cc: Sanyog Kale Cc: alsa-devel@alsa-project.org Cc: linux-kernel@vger.kernel.org Signed-off-by: Greg Kroah-Hartman --- drivers/soundwire/sysfs_slave.c | 8 -------- 1 file changed, 8 deletions(-) diff --git a/drivers/soundwire/sysfs_slave.c b/drivers/soundwire/sysfs_slave.c index 0eefc205f697..f4259710dd0f 100644 --- a/drivers/soundwire/sysfs_slave.c +++ b/drivers/soundwire/sysfs_slave.c @@ -129,10 +129,6 @@ static struct attribute *slave_dev_attrs[] = { NULL, }; -/* - * we don't use ATTRIBUTES_GROUP here since we want to add a subdirectory - * for device-level properties - */ static const struct attribute_group sdw_slave_dev_attr_group = { .attrs = slave_dev_attrs, .name = "dev-properties", @@ -204,10 +200,6 @@ static bool dp0_group_visible(struct kobject *kobj) } DEFINE_SYSFS_GROUP_VISIBLE(dp0); -/* - * we don't use ATTRIBUTES_GROUP here since we want to add a subdirectory - * for dp0-level properties - */ static const struct attribute_group dp0_group = { .attrs = dp0_attrs, .is_visible = SYSFS_GROUP_VISIBLE(dp0), -- 2.43.0